refactor: major codebase cleanup - BDD comments, file splitting, bug fixes (#1350)

* style(tests): normalize BDD comments from '// #given' to '// given'

- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given

* fix(rules-injector): prefer output.metadata.filePath over output.title

- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label

* feat(slashcommand): add optional user_message parameter

- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage

* feat(hooks): restore compaction-context-injector hook

- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
  Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry

* refactor(background-agent): split manager.ts into focused modules

- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports

* refactor(agents): split prometheus-prompt.ts into subdirectory

- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports

* refactor(delegate-task): split tools.ts into focused modules

- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns

* refactor(builtin-skills): split skills.ts into individual skill files

- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules

* chore: update import paths and lockfile

- Update prometheus import path after refactor
- Update bun.lock

* fix(tests): complete BDD comment normalization

- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts

---------

Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>

src/cli/doctor/checks/config.test.ts

@@ -4,11 +4,11 @@ import * as config from "./config"
 describe("config check", () => {
   describe("validateConfig", () => {
     it("returns valid: false for non-existent file", () => {
-      // #given non-existent file path
-      // #when validating
+      // given non-existent file path
+      // when validating
       const result = config.validateConfig("/non/existent/path.json")
 
-      // #then should indicate invalid
+      // then should indicate invalid
       expect(result.valid).toBe(false)
       expect(result.errors.length).toBeGreaterThan(0)
     })
@@ -16,11 +16,11 @@ describe("config check", () => {
 
   describe("getConfigInfo", () => {
     it("returns exists: false when no config found", () => {
-      // #given no config file exists
-      // #when getting config info
+      // given no config file exists
+      // when getting config info
       const info = config.getConfigInfo()
 
-      // #then should handle gracefully
+      // then should handle gracefully
       expect(typeof info.exists).toBe("boolean")
       expect(typeof info.valid).toBe("boolean")
     })
@@ -34,7 +34,7 @@ describe("config check", () => {
     })
 
     it("returns pass when no config exists (uses defaults)", async () => {
-      // #given no config file
+      // given no config file
       getInfoSpy = spyOn(config, "getConfigInfo").mockReturnValue({
         exists: false,
         path: null,
@@ -43,16 +43,16 @@ describe("config check", () => {
         errors: [],
       })
 
-      // #when checking validity
+      // when checking validity
       const result = await config.checkConfigValidity()
 
-      // #then should pass with default message
+      // then should pass with default message
       expect(result.status).toBe("pass")
       expect(result.message).toContain("default")
     })
 
     it("returns pass when config is valid", async () => {
-      // #given valid config
+      // given valid config
       getInfoSpy = spyOn(config, "getConfigInfo").mockReturnValue({
         exists: true,
         path: "/home/user/.config/opencode/oh-my-opencode.json",
@@ -61,16 +61,16 @@ describe("config check", () => {
         errors: [],
       })
 
-      // #when checking validity
+      // when checking validity
       const result = await config.checkConfigValidity()
 
-      // #then should pass
+      // then should pass
       expect(result.status).toBe("pass")
       expect(result.message).toContain("JSON")
     })
 
     it("returns fail when config has validation errors", async () => {
-      // #given invalid config
+      // given invalid config
       getInfoSpy = spyOn(config, "getConfigInfo").mockReturnValue({
         exists: true,
         path: "/home/user/.config/opencode/oh-my-opencode.json",
@@ -79,10 +79,10 @@ describe("config check", () => {
         errors: ["agents.oracle: Invalid model format"],
       })
 
-      // #when checking validity
+      // when checking validity
       const result = await config.checkConfigValidity()
 
-      // #then should fail with errors
+      // then should fail with errors
       expect(result.status).toBe("fail")
       expect(result.details?.some((d) => d.includes("Error"))).toBe(true)
     })
@@ -90,11 +90,11 @@ describe("config check", () => {
 
   describe("getConfigCheckDefinition", () => {
     it("returns valid check definition", () => {
-      // #given
-      // #when getting definition
+      // given
+      // when getting definition
       const def = config.getConfigCheckDefinition()
 
-      // #then should have required properties
+      // then should have required properties
       expect(def.id).toBe("config-validation")
       expect(def.category).toBe("configuration")
       expect(def.critical).toBe(false)