refactor: major codebase cleanup - BDD comments, file splitting, bug fixes (#1350)

* style(tests): normalize BDD comments from '// #given' to '// given'

- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given

* fix(rules-injector): prefer output.metadata.filePath over output.title

- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label

* feat(slashcommand): add optional user_message parameter

- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage

* feat(hooks): restore compaction-context-injector hook

- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
  Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry

* refactor(background-agent): split manager.ts into focused modules

- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports

* refactor(agents): split prometheus-prompt.ts into subdirectory

- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports

* refactor(delegate-task): split tools.ts into focused modules

- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns

* refactor(builtin-skills): split skills.ts into individual skill files

- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules

* chore: update import paths and lockfile

- Update prometheus import path after refactor
- Update bun.lock

* fix(tests): complete BDD comment normalization

- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts

---------

Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>

src/features/opencode-skill-loader/blocking.test.ts

@@ -17,7 +17,7 @@ afterEach(() => {
 
 describe("discoverAllSkillsBlocking", () => {
   it("returns skills synchronously from valid directories", () => {
-    // #given valid skill directory
+    // given valid skill directory
     const skillDir = join(TEST_DIR, "skills")
     mkdirSync(skillDir, { recursive: true })
 
@@ -34,10 +34,10 @@ This is test skill content.`
     const dirs = [skillDir]
     const scopes: SkillScope[] = ["opencode-project"]
 
-    // #when discoverAllSkillsBlocking called
+    // when discoverAllSkillsBlocking called
     const skills = discoverAllSkillsBlocking(dirs, scopes)
 
-    // #then returns skills synchronously
+    // then returns skills synchronously
     expect(skills).toBeArray()
     expect(skills.length).toBe(1)
     expect(skills[0].name).toBe("test-skill")
@@ -45,38 +45,38 @@ This is test skill content.`
   })
 
   it("returns empty array for empty directories", () => {
-    // #given empty directory
+    // given empty directory
     const emptyDir = join(TEST_DIR, "empty")
     mkdirSync(emptyDir, { recursive: true })
 
     const dirs = [emptyDir]
     const scopes: SkillScope[] = ["opencode-project"]
 
-    // #when discoverAllSkillsBlocking called
+    // when discoverAllSkillsBlocking called
     const skills = discoverAllSkillsBlocking(dirs, scopes)
 
-    // #then returns empty array
+    // then returns empty array
     expect(skills).toBeArray()
     expect(skills.length).toBe(0)
   })
 
   it("returns empty array for non-existent directories", () => {
-    // #given non-existent directory
+    // given non-existent directory
     const nonExistentDir = join(TEST_DIR, "does-not-exist")
 
     const dirs = [nonExistentDir]
     const scopes: SkillScope[] = ["opencode-project"]
 
-    // #when discoverAllSkillsBlocking called
+    // when discoverAllSkillsBlocking called
     const skills = discoverAllSkillsBlocking(dirs, scopes)
 
-    // #then returns empty array (no throw)
+    // then returns empty array (no throw)
     expect(skills).toBeArray()
     expect(skills.length).toBe(0)
   })
 
   it("handles multiple directories with mixed content", () => {
-    // #given multiple directories with valid and invalid skills
+    // given multiple directories with valid and invalid skills
     const dir1 = join(TEST_DIR, "dir1")
     const dir2 = join(TEST_DIR, "dir2")
     mkdirSync(dir1, { recursive: true })
@@ -103,10 +103,10 @@ Skill 2 content.`
     const dirs = [dir1, dir2]
     const scopes: SkillScope[] = ["opencode-project"]
 
-    // #when discoverAllSkillsBlocking called
+    // when discoverAllSkillsBlocking called
     const skills = discoverAllSkillsBlocking(dirs, scopes)
 
-    // #then returns all valid skills
+    // then returns all valid skills
     expect(skills).toBeArray()
     expect(skills.length).toBe(2)
     
@@ -115,7 +115,7 @@ Skill 2 content.`
   })
 
   it("skips invalid YAML files", () => {
-    // #given directory with invalid YAML
+    // given directory with invalid YAML
     const skillDir = join(TEST_DIR, "skills")
     mkdirSync(skillDir, { recursive: true })
 
@@ -142,17 +142,17 @@ Invalid content.`
     const dirs = [skillDir]
     const scopes: SkillScope[] = ["opencode-project"]
 
-    // #when discoverAllSkillsBlocking called
+    // when discoverAllSkillsBlocking called
     const skills = discoverAllSkillsBlocking(dirs, scopes)
 
-    // #then skips invalid, returns valid
+    // then skips invalid, returns valid
     expect(skills).toBeArray()
     expect(skills.length).toBe(1)
     expect(skills[0].name).toBe("valid-skill")
   })
 
   it("handles directory-based skills with SKILL.md", () => {
-    // #given directory-based skill structure
+    // given directory-based skill structure
     const skillsDir = join(TEST_DIR, "skills")
     const mySkillDir = join(skillsDir, "my-skill")
     mkdirSync(mySkillDir, { recursive: true })
@@ -170,17 +170,17 @@ This is a directory-based skill.`
     const dirs = [skillsDir]
     const scopes: SkillScope[] = ["opencode-project"]
 
-    // #when discoverAllSkillsBlocking called
+    // when discoverAllSkillsBlocking called
     const skills = discoverAllSkillsBlocking(dirs, scopes)
 
-    // #then returns skill from SKILL.md
+    // then returns skill from SKILL.md
     expect(skills).toBeArray()
     expect(skills.length).toBe(1)
     expect(skills[0].name).toBe("my-skill")
   })
 
   it("processes large skill sets without timeout", () => {
-    // #given directory with many skills (20+)
+    // given directory with many skills (20+)
     const skillDir = join(TEST_DIR, "many-skills")
     mkdirSync(skillDir, { recursive: true })
 
@@ -200,10 +200,10 @@ Content for skill ${i}.`
     const dirs = [skillDir]
     const scopes: SkillScope[] = ["opencode-project"]
 
-    // #when discoverAllSkillsBlocking called
+    // when discoverAllSkillsBlocking called
     const skills = discoverAllSkillsBlocking(dirs, scopes)
 
-    // #then completes without timeout
+    // then completes without timeout
     expect(skills).toBeArray()
     expect(skills.length).toBe(skillCount)
   })