luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: major codebase cleanup - BDD comments, file splitting, bug fixes (#1350)

Browse Source 
* style(tests): normalize BDD comments from '// #given' to '// given'

- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given

* fix(rules-injector): prefer output.metadata.filePath over output.title

- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label

* feat(slashcommand): add optional user_message parameter

- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage

* feat(hooks): restore compaction-context-injector hook

- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
  Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry

* refactor(background-agent): split manager.ts into focused modules

- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports

* refactor(agents): split prometheus-prompt.ts into subdirectory

- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports

* refactor(delegate-task): split tools.ts into focused modules

- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns

* refactor(builtin-skills): split skills.ts into individual skill files

- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules

* chore: update import paths and lockfile

- Update prometheus import path after refactor
- Update bun.lock

* fix(tests): complete BDD comment normalization

- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts

---------

Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
This commit is contained in:
YeonGyu-Kim
2026-02-01 16:47:50 +09:00
committed by GitHub
parent c83150d9ea
commit f146aeff0f
145 changed files with 10307 additions and 9562 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/hooks/auto-update-checker/index.test.ts
+66 -66
View File
@@ -4,250 +4,250 @@ import { isPrereleaseVersion, isDistTag, isPrereleaseOrDistTag, extractChannel }
describe("auto-update-checker", () => {
describe("isPrereleaseVersion", () => {
test("returns true for beta versions", () => {
// #given a beta version
// given a beta version
const version = "3.0.0-beta.1"
// #when checking if prerelease
// when checking if prerelease
const result = isPrereleaseVersion(version)
// #then returns true
// then returns true
expect(result).toBe(true)
})
test("returns true for alpha versions", () => {
// #given an alpha version
// given an alpha version
const version = "1.0.0-alpha"
// #when checking if prerelease
// when checking if prerelease
const result = isPrereleaseVersion(version)
// #then returns true
// then returns true
expect(result).toBe(true)
})
test("returns true for rc versions", () => {
// #given an rc version
// given an rc version
const version = "2.0.0-rc.1"
// #when checking if prerelease
// when checking if prerelease
const result = isPrereleaseVersion(version)
// #then returns true
// then returns true
expect(result).toBe(true)
})
test("returns false for stable versions", () => {
// #given a stable version
// given a stable version
const version = "2.14.0"
// #when checking if prerelease
// when checking if prerelease
const result = isPrereleaseVersion(version)
// #then returns false
// then returns false
expect(result).toBe(false)
})
})
describe("isDistTag", () => {
test("returns true for beta dist-tag", () => {
// #given beta dist-tag
// given beta dist-tag
const version = "beta"
// #when checking if dist-tag
// when checking if dist-tag
const result = isDistTag(version)
// #then returns true
// then returns true
expect(result).toBe(true)
})
test("returns true for next dist-tag", () => {
// #given next dist-tag
// given next dist-tag
const version = "next"
// #when checking if dist-tag
// when checking if dist-tag
const result = isDistTag(version)
// #then returns true
// then returns true
expect(result).toBe(true)
})
test("returns true for canary dist-tag", () => {
// #given canary dist-tag
// given canary dist-tag
const version = "canary"
// #when checking if dist-tag
// when checking if dist-tag
const result = isDistTag(version)
// #then returns true
// then returns true
expect(result).toBe(true)
})
test("returns false for semver versions", () => {
// #given a semver version
// given a semver version
const version = "2.14.0"
// #when checking if dist-tag
// when checking if dist-tag
const result = isDistTag(version)
// #then returns false
// then returns false
expect(result).toBe(false)
})
test("returns false for latest (handled separately)", () => {
// #given latest tag
// given latest tag
const version = "latest"
// #when checking if dist-tag
// when checking if dist-tag
const result = isDistTag(version)
// #then returns true (but latest is filtered before this check)
// then returns true (but latest is filtered before this check)
expect(result).toBe(true)
})
})
describe("isPrereleaseOrDistTag", () => {
test("returns false for null", () => {
// #given null version
// given null version
const version = null
// #when checking
// when checking
const result = isPrereleaseOrDistTag(version)
// #then returns false
// then returns false
expect(result).toBe(false)
})
test("returns true for prerelease version", () => {
// #given prerelease version
// given prerelease version
const version = "3.0.0-beta.1"
// #when checking
// when checking
const result = isPrereleaseOrDistTag(version)
// #then returns true
// then returns true
expect(result).toBe(true)
})
test("returns true for dist-tag", () => {
// #given dist-tag
// given dist-tag
const version = "beta"
// #when checking
// when checking
const result = isPrereleaseOrDistTag(version)
// #then returns true
// then returns true
expect(result).toBe(true)
})
test("returns false for stable version", () => {
// #given stable version
// given stable version
const version = "2.14.0"
// #when checking
// when checking
const result = isPrereleaseOrDistTag(version)
// #then returns false
// then returns false
expect(result).toBe(false)
})
})
describe("extractChannel", () => {
test("extracts beta from dist-tag", () => {
// #given beta dist-tag
// given beta dist-tag
const version = "beta"
// #when extracting channel
// when extracting channel
const result = extractChannel(version)
// #then returns beta
// then returns beta
expect(result).toBe("beta")
})
test("extracts next from dist-tag", () => {
// #given next dist-tag
// given next dist-tag
const version = "next"
// #when extracting channel
// when extracting channel
const result = extractChannel(version)
// #then returns next
// then returns next
expect(result).toBe("next")
})
test("extracts canary from dist-tag", () => {
// #given canary dist-tag
// given canary dist-tag
const version = "canary"
// #when extracting channel
// when extracting channel
const result = extractChannel(version)
// #then returns canary
// then returns canary
expect(result).toBe("canary")
})
test("extracts beta from prerelease version", () => {
// #given beta prerelease version
// given beta prerelease version
const version = "3.0.0-beta.1"
// #when extracting channel
// when extracting channel
const result = extractChannel(version)
// #then returns beta
// then returns beta
expect(result).toBe("beta")
})
test("extracts alpha from prerelease version", () => {
// #given alpha prerelease version
// given alpha prerelease version
const version = "1.0.0-alpha"
// #when extracting channel
// when extracting channel
const result = extractChannel(version)
// #then returns alpha
// then returns alpha
expect(result).toBe("alpha")
})
test("extracts rc from prerelease version", () => {
// #given rc prerelease version
// given rc prerelease version
const version = "2.0.0-rc.1"
// #when extracting channel
// when extracting channel
const result = extractChannel(version)
// #then returns rc
// then returns rc
expect(result).toBe("rc")
})
test("returns latest for stable version", () => {
// #given stable version
// given stable version
const version = "2.14.0"
// #when extracting channel
// when extracting channel
const result = extractChannel(version)
// #then returns latest
// then returns latest
expect(result).toBe("latest")
})
test("returns latest for null", () => {
// #given null version
// given null version
const version = null
// #when extracting channel
// when extracting channel
const result = extractChannel(version)
// #then returns latest
// then returns latest
expect(result).toBe("latest")
})
test("handles complex prerelease identifiers", () => {
// #given complex prerelease
// given complex prerelease
const version = "3.0.0-beta.1.experimental"
// #when extracting channel
// when extracting channel
const result = extractChannel(version)
// #then returns beta
// then returns beta
expect(result).toBe("beta")
})
})