refactor: major codebase cleanup - BDD comments, file splitting, bug fixes (#1350)
* style(tests): normalize BDD comments from '// #given' to '// given'
- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given
* fix(rules-injector): prefer output.metadata.filePath over output.title
- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label
* feat(slashcommand): add optional user_message parameter
- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage
* feat(hooks): restore compaction-context-injector hook
- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry
* refactor(background-agent): split manager.ts into focused modules
- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports
* refactor(agents): split prometheus-prompt.ts into subdirectory
- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports
* refactor(delegate-task): split tools.ts into focused modules
- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns
* refactor(builtin-skills): split skills.ts into individual skill files
- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules
* chore: update import paths and lockfile
- Update prometheus import path after refactor
- Update bun.lock
* fix(tests): complete BDD comment normalization
- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts
---------
Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
This commit is contained in:
YeonGyu-Kim
@@ -4,33 +4,33 @@ import { applyAgentVariant, resolveAgentVariant, resolveVariantForModel } from "
|
||||
|
||||
describe("resolveAgentVariant", () => {
|
||||
test("returns undefined when agent name missing", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {} as OhMyOpenCodeConfig
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveAgentVariant(config)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBeUndefined()
|
||||
})
|
||||
|
||||
test("returns agent override variant", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {
|
||||
agents: {
|
||||
sisyphus: { variant: "low" },
|
||||
},
|
||||
} as OhMyOpenCodeConfig
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveAgentVariant(config, "sisyphus")
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBe("low")
|
||||
})
|
||||
|
||||
test("returns category variant when agent uses category", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {
|
||||
agents: {
|
||||
sisyphus: { category: "ultrabrain" },
|
||||
@@ -40,17 +40,17 @@ describe("resolveAgentVariant", () => {
|
||||
},
|
||||
} as OhMyOpenCodeConfig
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveAgentVariant(config, "sisyphus")
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBe("xhigh")
|
||||
})
|
||||
})
|
||||
|
||||
describe("applyAgentVariant", () => {
|
||||
test("sets variant when message is undefined", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {
|
||||
agents: {
|
||||
sisyphus: { variant: "low" },
|
||||
@@ -58,15 +58,15 @@ describe("applyAgentVariant", () => {
|
||||
} as OhMyOpenCodeConfig
|
||||
const message: { variant?: string } = {}
|
||||
|
||||
// #when
|
||||
// when
|
||||
applyAgentVariant(config, "sisyphus", message)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(message.variant).toBe("low")
|
||||
})
|
||||
|
||||
test("does not override existing variant", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {
|
||||
agents: {
|
||||
sisyphus: { variant: "low" },
|
||||
@@ -74,89 +74,89 @@ describe("applyAgentVariant", () => {
|
||||
} as OhMyOpenCodeConfig
|
||||
const message = { variant: "max" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
applyAgentVariant(config, "sisyphus", message)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(message.variant).toBe("max")
|
||||
})
|
||||
})
|
||||
|
||||
describe("resolveVariantForModel", () => {
|
||||
test("returns correct variant for anthropic provider", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {} as OhMyOpenCodeConfig
|
||||
const model = { providerID: "anthropic", modelID: "claude-opus-4-5" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveVariantForModel(config, "sisyphus", model)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBe("max")
|
||||
})
|
||||
|
||||
test("returns correct variant for openai provider", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {} as OhMyOpenCodeConfig
|
||||
const model = { providerID: "openai", modelID: "gpt-5.2" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveVariantForModel(config, "sisyphus", model)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBe("medium")
|
||||
})
|
||||
|
||||
test("returns undefined for provider with no variant in chain", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {} as OhMyOpenCodeConfig
|
||||
const model = { providerID: "google", modelID: "gemini-3-pro" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveVariantForModel(config, "sisyphus", model)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBeUndefined()
|
||||
})
|
||||
|
||||
test("returns undefined for provider not in chain", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {} as OhMyOpenCodeConfig
|
||||
const model = { providerID: "unknown-provider", modelID: "some-model" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveVariantForModel(config, "sisyphus", model)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBeUndefined()
|
||||
})
|
||||
|
||||
test("returns undefined for unknown agent", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {} as OhMyOpenCodeConfig
|
||||
const model = { providerID: "anthropic", modelID: "claude-opus-4-5" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveVariantForModel(config, "nonexistent-agent", model)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBeUndefined()
|
||||
})
|
||||
|
||||
test("returns variant for zai-coding-plan provider without variant", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {} as OhMyOpenCodeConfig
|
||||
const model = { providerID: "zai-coding-plan", modelID: "glm-4.7" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveVariantForModel(config, "sisyphus", model)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBeUndefined()
|
||||
})
|
||||
|
||||
test("falls back to category chain when agent has no requirement", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {
|
||||
agents: {
|
||||
"custom-agent": { category: "ultrabrain" },
|
||||
@@ -164,34 +164,34 @@ describe("resolveVariantForModel", () => {
|
||||
} as OhMyOpenCodeConfig
|
||||
const model = { providerID: "openai", modelID: "gpt-5.2-codex" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveVariantForModel(config, "custom-agent", model)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBe("xhigh")
|
||||
})
|
||||
|
||||
test("returns correct variant for oracle agent with openai", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {} as OhMyOpenCodeConfig
|
||||
const model = { providerID: "openai", modelID: "gpt-5.2" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveVariantForModel(config, "oracle", model)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBe("high")
|
||||
})
|
||||
|
||||
test("returns correct variant for oracle agent with anthropic", () => {
|
||||
// #given
|
||||
// given
|
||||
const config = {} as OhMyOpenCodeConfig
|
||||
const model = { providerID: "anthropic", modelID: "claude-opus-4-5" }
|
||||
|
||||
// #when
|
||||
// when
|
||||
const variant = resolveVariantForModel(config, "oracle", model)
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(variant).toBe("max")
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user