refactor: major codebase cleanup - BDD comments, file splitting, bug fixes (#1350)
* style(tests): normalize BDD comments from '// #given' to '// given'
- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given
* fix(rules-injector): prefer output.metadata.filePath over output.title
- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label
* feat(slashcommand): add optional user_message parameter
- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage
* feat(hooks): restore compaction-context-injector hook
- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry
* refactor(background-agent): split manager.ts into focused modules
- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports
* refactor(agents): split prometheus-prompt.ts into subdirectory
- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports
* refactor(delegate-task): split tools.ts into focused modules
- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns
* refactor(builtin-skills): split skills.ts into individual skill files
- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules
* chore: update import paths and lockfile
- Update prometheus import path after refactor
- Update bun.lock
* fix(tests): complete BDD comment normalization
- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts
---------
Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
This commit is contained in:
YeonGyu-Kim
@@ -10,14 +10,14 @@ import {
|
||||
|
||||
describe("isInsideTmux", () => {
|
||||
test("returns true when TMUX env is set", () => {
|
||||
// #given
|
||||
// given
|
||||
const originalTmux = process.env.TMUX
|
||||
process.env.TMUX = "/tmp/tmux-1000/default"
|
||||
|
||||
// #when
|
||||
// when
|
||||
const result = isInsideTmux()
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(result).toBe(true)
|
||||
|
||||
// cleanup
|
||||
@@ -25,14 +25,14 @@ describe("isInsideTmux", () => {
|
||||
})
|
||||
|
||||
test("returns false when TMUX env is not set", () => {
|
||||
// #given
|
||||
// given
|
||||
const originalTmux = process.env.TMUX
|
||||
delete process.env.TMUX
|
||||
|
||||
// #when
|
||||
// when
|
||||
const result = isInsideTmux()
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(result).toBe(false)
|
||||
|
||||
// cleanup
|
||||
@@ -40,14 +40,14 @@ describe("isInsideTmux", () => {
|
||||
})
|
||||
|
||||
test("returns false when TMUX env is empty string", () => {
|
||||
// #given
|
||||
// given
|
||||
const originalTmux = process.env.TMUX
|
||||
process.env.TMUX = ""
|
||||
|
||||
// #when
|
||||
// when
|
||||
const result = isInsideTmux()
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(result).toBe(false)
|
||||
|
||||
// cleanup
|
||||
@@ -67,100 +67,100 @@ describe("isServerRunning", () => {
|
||||
})
|
||||
|
||||
test("returns true when server responds OK", async () => {
|
||||
// #given
|
||||
// given
|
||||
globalThis.fetch = mock(async () => ({ ok: true })) as any
|
||||
|
||||
// #when
|
||||
// when
|
||||
const result = await isServerRunning("http://localhost:4096")
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(result).toBe(true)
|
||||
})
|
||||
|
||||
test("returns false when server not reachable", async () => {
|
||||
// #given
|
||||
// given
|
||||
globalThis.fetch = mock(async () => {
|
||||
throw new Error("ECONNREFUSED")
|
||||
}) as any
|
||||
|
||||
// #when
|
||||
// when
|
||||
const result = await isServerRunning("http://localhost:4096")
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(result).toBe(false)
|
||||
})
|
||||
|
||||
test("returns false when fetch returns not ok", async () => {
|
||||
// #given
|
||||
// given
|
||||
globalThis.fetch = mock(async () => ({ ok: false })) as any
|
||||
|
||||
// #when
|
||||
// when
|
||||
const result = await isServerRunning("http://localhost:4096")
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(result).toBe(false)
|
||||
})
|
||||
|
||||
test("caches successful result", async () => {
|
||||
// #given
|
||||
// given
|
||||
const fetchMock = mock(async () => ({ ok: true })) as any
|
||||
globalThis.fetch = fetchMock
|
||||
|
||||
// #when
|
||||
// when
|
||||
await isServerRunning("http://localhost:4096")
|
||||
await isServerRunning("http://localhost:4096")
|
||||
|
||||
// #then - should only call fetch once due to caching
|
||||
// then - should only call fetch once due to caching
|
||||
expect(fetchMock.mock.calls.length).toBe(1)
|
||||
})
|
||||
|
||||
test("does not cache failed result", async () => {
|
||||
// #given
|
||||
// given
|
||||
const fetchMock = mock(async () => {
|
||||
throw new Error("ECONNREFUSED")
|
||||
}) as any
|
||||
globalThis.fetch = fetchMock
|
||||
|
||||
// #when
|
||||
// when
|
||||
await isServerRunning("http://localhost:4096")
|
||||
await isServerRunning("http://localhost:4096")
|
||||
|
||||
// #then - should call fetch 4 times (2 attempts per call, 2 calls)
|
||||
// then - should call fetch 4 times (2 attempts per call, 2 calls)
|
||||
expect(fetchMock.mock.calls.length).toBe(4)
|
||||
})
|
||||
|
||||
test("uses different cache for different URLs", async () => {
|
||||
// #given
|
||||
// given
|
||||
const fetchMock = mock(async () => ({ ok: true })) as any
|
||||
globalThis.fetch = fetchMock
|
||||
|
||||
// #when
|
||||
// when
|
||||
await isServerRunning("http://localhost:4096")
|
||||
await isServerRunning("http://localhost:5000")
|
||||
|
||||
// #then - should call fetch twice for different URLs
|
||||
// then - should call fetch twice for different URLs
|
||||
expect(fetchMock.mock.calls.length).toBe(2)
|
||||
})
|
||||
})
|
||||
|
||||
describe("resetServerCheck", () => {
|
||||
test("clears cache without throwing", () => {
|
||||
// #given, #when, #then
|
||||
// given, #when, #then
|
||||
expect(() => resetServerCheck()).not.toThrow()
|
||||
})
|
||||
|
||||
test("allows re-checking after reset", async () => {
|
||||
// #given
|
||||
// given
|
||||
const originalFetch = globalThis.fetch
|
||||
const fetchMock = mock(async () => ({ ok: true })) as any
|
||||
globalThis.fetch = fetchMock
|
||||
|
||||
// #when
|
||||
// when
|
||||
await isServerRunning("http://localhost:4096")
|
||||
resetServerCheck()
|
||||
await isServerRunning("http://localhost:4096")
|
||||
|
||||
// #then - should call fetch twice after reset
|
||||
// then - should call fetch twice after reset
|
||||
expect(fetchMock.mock.calls.length).toBe(2)
|
||||
|
||||
// cleanup
|
||||
@@ -170,26 +170,26 @@ describe("resetServerCheck", () => {
|
||||
|
||||
describe("tmux pane functions", () => {
|
||||
test("spawnTmuxPane is exported as function", async () => {
|
||||
// #given, #when
|
||||
// given, #when
|
||||
const result = typeof spawnTmuxPane
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(result).toBe("function")
|
||||
})
|
||||
|
||||
test("closeTmuxPane is exported as function", async () => {
|
||||
// #given, #when
|
||||
// given, #when
|
||||
const result = typeof closeTmuxPane
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(result).toBe("function")
|
||||
})
|
||||
|
||||
test("applyLayout is exported as function", async () => {
|
||||
// #given, #when
|
||||
// given, #when
|
||||
const result = typeof applyLayout
|
||||
|
||||
// #then
|
||||
// then
|
||||
expect(result).toBe("function")
|
||||
})
|
||||
})
|
||||
|
||||
Reference in New Issue
Block a user