refactor: major codebase cleanup - BDD comments, file splitting, bug fixes (#1350)

* style(tests): normalize BDD comments from '// #given' to '// given'

- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given

* fix(rules-injector): prefer output.metadata.filePath over output.title

- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label

* feat(slashcommand): add optional user_message parameter

- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage

* feat(hooks): restore compaction-context-injector hook

- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
  Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry

* refactor(background-agent): split manager.ts into focused modules

- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports

* refactor(agents): split prometheus-prompt.ts into subdirectory

- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports

* refactor(delegate-task): split tools.ts into focused modules

- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns

* refactor(builtin-skills): split skills.ts into individual skill files

- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules

* chore: update import paths and lockfile

- Update prometheus import path after refactor
- Update bun.lock

* fix(tests): complete BDD comment normalization

- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts

---------

Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
This commit is contained in:
YeonGyu-Kim
2026-02-01 16:47:50 +09:00
committed by GitHub
parent c83150d9ea
commit f146aeff0f
145 changed files with 10307 additions and 9562 deletions
+30 -30
View File
@@ -4,9 +4,9 @@ import { normalizeArgs, validateArgs, createLookAt } from "./tools"
describe("look-at tool", () => {
describe("normalizeArgs", () => {
// #given LLM이 file_path 대신 path를 사용할 수 있음
// #when path 파라미터로 호출
// #then file_path로 정규화되어야 함
// given LLM이 file_path 대신 path를 사용할 수 있음
// when path 파라미터로 호출
// then file_path로 정규화되어야 함
test("normalizes path to file_path for LLM compatibility", () => {
const args = { path: "/some/file.png", goal: "analyze" }
const normalized = normalizeArgs(args as any)
@@ -14,18 +14,18 @@ describe("look-at tool", () => {
expect(normalized.goal).toBe("analyze")
})
// #given 정상적인 file_path 사용
// #when file_path 파라미터로 호출
// #then 그대로 유지
// given 정상적인 file_path 사용
// when file_path 파라미터로 호출
// then 그대로 유지
test("keeps file_path when properly provided", () => {
const args = { file_path: "/correct/path.pdf", goal: "extract" }
const normalized = normalizeArgs(args)
expect(normalized.file_path).toBe("/correct/path.pdf")
})
// #given 둘 다 제공된 경우
// #when file_path와 path 모두 있음
// #then file_path 우선
// given 둘 다 제공된 경우
// when file_path와 path 모두 있음
// then file_path 우선
test("prefers file_path over path when both provided", () => {
const args = { file_path: "/preferred.png", path: "/fallback.png", goal: "test" }
const normalized = normalizeArgs(args as any)
@@ -34,17 +34,17 @@ describe("look-at tool", () => {
})
describe("validateArgs", () => {
// #given 유효한 인자
// #when 검증
// #then null 반환 (에러 없음)
// given 유효한 인자
// when 검증
// then null 반환 (에러 없음)
test("returns null for valid args", () => {
const args = { file_path: "/valid/path.png", goal: "analyze" }
expect(validateArgs(args)).toBeNull()
})
// #given file_path 누락
// #when 검증
// #then 명확한 에러 메시지
// given file_path 누락
// when 검증
// then 명확한 에러 메시지
test("returns error when file_path is missing", () => {
const args = { goal: "analyze" } as any
const error = validateArgs(args)
@@ -52,9 +52,9 @@ describe("look-at tool", () => {
expect(error).toContain("required")
})
// #given goal 누락
// #when 검증
// #then 명확한 에러 메시지
// given goal 누락
// when 검증
// then 명확한 에러 메시지
test("returns error when goal is missing", () => {
const args = { file_path: "/some/path.png" } as any
const error = validateArgs(args)
@@ -62,9 +62,9 @@ describe("look-at tool", () => {
expect(error).toContain("required")
})
// #given file_path가 빈 문자열
// #when 검증
// #then 에러 반환
// given file_path가 빈 문자열
// when 검증
// then 에러 반환
test("returns error when file_path is empty string", () => {
const args = { file_path: "", goal: "analyze" }
const error = validateArgs(args)
@@ -73,9 +73,9 @@ describe("look-at tool", () => {
})
describe("createLookAt error handling", () => {
// #given session.prompt에서 JSON parse 에러 발생
// #when LookAt 도구 실행
// #then 사용자 친화적 에러 메시지 반환
// given session.prompt에서 JSON parse 에러 발생
// when LookAt 도구 실행
// then 사용자 친화적 에러 메시지 반환
test("handles JSON parse error from session.prompt gracefully", async () => {
const mockClient = {
session: {
@@ -115,9 +115,9 @@ describe("look-at tool", () => {
expect(result).toContain("image/png")
})
// #given session.prompt에서 일반 에러 발생
// #when LookAt 도구 실행
// #then 원본 에러 메시지 포함한 에러 반환
// given session.prompt에서 일반 에러 발생
// when LookAt 도구 실행
// then 원본 에러 메시지 포함한 에러 반환
test("handles generic prompt error gracefully", async () => {
const mockClient = {
session: {
@@ -157,9 +157,9 @@ describe("look-at tool", () => {
})
describe("createLookAt model passthrough", () => {
// #given multimodal-looker agent has resolved model info
// #when LookAt 도구 실행
// #then session.prompt에 model 정보가 전달되어야 함
// given multimodal-looker agent has resolved model info
// when LookAt 도구 실행
// then session.prompt에 model 정보가 전달되어야 함
test("passes multimodal-looker model to session.prompt when available", async () => {
let promptBody: any