fix(agents): relax Momus input validation and tighten Prometheus Momus calls to avoid false rejections (#659)

2026-01-11 20:30:29 +11:00
parent 10a5bab94d
commit f27e93bcc8
4 changed files with 116 additions and 31 deletions
@@ -0,0 +1,57 @@
+import { describe, test, expect } from "bun:test"
+import { MOMUS_SYSTEM_PROMPT } from "./momus"
+
+function escapeRegExp(value: string) {
+  return value.replace(/[.*+?^${}()|[\]\\]/g, "\\$&")
+}
+
+describe("MOMUS_SYSTEM_PROMPT policy requirements", () => {
+  test("should treat SYSTEM DIRECTIVE as ignorable/stripped", () => {
+    // #given
+    const prompt = MOMUS_SYSTEM_PROMPT
+    
+    // #when / #then
+    expect(prompt).toContain("[SYSTEM DIRECTIVE - READ-ONLY PLANNING CONSULTATION]")
+    // Should explicitly mention stripping or ignoring these
+    expect(prompt.toLowerCase()).toMatch(/ignore|strip|system directive/)
+  })
+
+  test("should extract paths containing .sisyphus/plans/ and ending in .md", () => {
+    // #given
+    const prompt = MOMUS_SYSTEM_PROMPT
+
+    // #when / #then
+    expect(prompt).toContain(".sisyphus/plans/")
+    expect(prompt).toContain(".md")
+    // New extraction policy should be mentioned
+    expect(prompt.toLowerCase()).toMatch(/extract|search|find path/)
+  })
+
+  test("should NOT teach that 'Please review' is INVALID (conversational wrapper allowed)", () => {
+    // #given
+    const prompt = MOMUS_SYSTEM_PROMPT
+
+    // #when / #then
+    // In RED phase, this will FAIL because current prompt explicitly lists this as INVALID
+    const invalidExample = "Please review .sisyphus/plans/plan.md"
+    const rejectionTeaching = new RegExp(
+      `reject.*${escapeRegExp(invalidExample)}`,
+      "i",
+    )
+    
+    // We want the prompt to NOT reject this anymore. 
+    // If it's still in the "INVALID" list, this test should fail.
+    expect(prompt).not.toMatch(rejectionTeaching)
+  })
+
+  test("should handle ambiguity (2+ paths) and 'no path found' rejection", () => {
+    // #given
+    const prompt = MOMUS_SYSTEM_PROMPT
+
+    // #when / #then
+    // Should mention what happens when multiple paths are found
+    expect(prompt.toLowerCase()).toMatch(/multiple|ambiguous|2\+|two/)
+    // Should mention rejection if no path found
+    expect(prompt.toLowerCase()).toMatch(/no.*path.*found|reject.*no.*path/)
+  })
+})