fix(agent-names): use HTTP-header-safe display names and config keys for API calls (#3138)

Display names with parentheses like 'Atlas (Plan Executor)' cause HTTP
header validation errors in x-opencode-agent-name. This was blocking
Atlas/Prometheus from working via /start-work and auto-retry.

Changes:
- Display names: parens -> dashes ('Atlas - Plan Executor')
- Hooks (start-work, no-hephaestus-non-gpt, no-sisyphus-gpt): use
  config keys ('atlas', 'sisyphus', 'hephaestus') for agent API fields
- auto-retry: use config key instead of display name for promptAsync
- agent-override-protection: handle dash-suffix normalization
- Updated all test expectations to match new format

Closes #3138

src/cli/run/message-part-delta.test.ts

@@ -89,7 +89,7 @@ describe("message.part.delta handling", () => {
     //#given
     const ctx = createMockContext("ses_main")
     const state = createEventState()
-    state.agentColorsByName["Sisyphus (Ultraworker)"] = "#00CED1"
+    state.agentColorsByName["Sisyphus - Ultraworker"] = "#00CED1"
     const stdoutSpy = spyOn(process.stdout, "write").mockImplementation(() => true)
     const payload: EventPayload = {
       type: "message.updated",
@@ -97,7 +97,7 @@ describe("message.part.delta handling", () => {
         info: {
           sessionID: "ses_main",
           role: "assistant",
-          agent: "Sisyphus (Ultraworker)",
+          agent: "Sisyphus - Ultraworker",
           modelID: "claude-opus-4-6",
           variant: "max",
         },
@@ -115,7 +115,7 @@ describe("message.part.delta handling", () => {
     expect(rendered).toContain("\u001b[38;2;0;206;209m")
     expect(rendered).toContain("claude-opus-4-6 (max)")
     expect(rendered).toContain("└─")
-    expect(rendered).toContain("Sisyphus (Ultraworker)")
+    expect(rendered).toContain("Sisyphus - Ultraworker")
     stdoutSpy.mockRestore()
   })
 
@@ -128,7 +128,7 @@ describe("message.part.delta handling", () => {
       {
         type: "message.updated",
         properties: {
-          info: { sessionID: "ses_main", role: "assistant", agent: "Sisyphus (Ultraworker)", modelID: "claude-opus-4-6" },
+          info: { sessionID: "ses_main", role: "assistant", agent: "Sisyphus - Ultraworker", modelID: "claude-opus-4-6" },
         },
       },
       {
@@ -187,7 +187,7 @@ describe("message.part.delta handling", () => {
       {
         type: "message.updated",
         properties: {
-          info: { sessionID: "ses_main", role: "assistant", agent: "Sisyphus (Ultraworker)", modelID: "claude-opus-4-6" },
+          info: { sessionID: "ses_main", role: "assistant", agent: "Sisyphus - Ultraworker", modelID: "claude-opus-4-6" },
         },
       },
       {
@@ -242,7 +242,7 @@ describe("message.part.delta handling", () => {
       {
         type: "message.updated",
         properties: {
-          info: { id: "msg_assistant", sessionID: "ses_main", role: "assistant", agent: "Sisyphus (Ultraworker)", modelID: "claude-opus-4-6" },
+          info: { id: "msg_assistant", sessionID: "ses_main", role: "assistant", agent: "Sisyphus - Ultraworker", modelID: "claude-opus-4-6" },
         },
       },
       {
@@ -309,7 +309,7 @@ describe("message.part.delta handling", () => {
       {
         type: "message.updated",
         properties: {
-          info: { id: "msg_assistant", sessionID: "ses_main", role: "assistant", agent: "Sisyphus (Ultraworker)", modelID: "claude-opus-4-6" },
+          info: { id: "msg_assistant", sessionID: "ses_main", role: "assistant", agent: "Sisyphus - Ultraworker", modelID: "claude-opus-4-6" },
         },
       },
       {
@@ -353,7 +353,7 @@ describe("message.part.delta handling", () => {
       {
         type: "message.updated",
         properties: {
-          info: { id: "msg_assistant", sessionID: "ses_main", role: "assistant", agent: "Sisyphus (Ultraworker)", modelID: "claude-opus-4-6", variant: "max" },
+          info: { id: "msg_assistant", sessionID: "ses_main", role: "assistant", agent: "Sisyphus - Ultraworker", modelID: "claude-opus-4-6", variant: "max" },
         },
       },
       {
@@ -388,7 +388,7 @@ describe("message.part.delta handling", () => {
       {
         type: "message.updated",
         properties: {
-          info: { id: "msg_user", sessionID: "ses_main", role: "user", agent: "Sisyphus (Ultraworker)", modelID: "claude-opus-4-6" },
+          info: { id: "msg_user", sessionID: "ses_main", role: "user", agent: "Sisyphus - Ultraworker", modelID: "claude-opus-4-6" },
         },
       },
       {
@@ -410,7 +410,7 @@ describe("message.part.delta handling", () => {
       {
         type: "message.updated",
         properties: {
-          info: { id: "msg_assistant", sessionID: "ses_main", role: "assistant", agent: "Sisyphus (Ultraworker)", modelID: "claude-opus-4-6" },
+          info: { id: "msg_assistant", sessionID: "ses_main", role: "assistant", agent: "Sisyphus - Ultraworker", modelID: "claude-opus-4-6" },
         },
       },
       {

src/cli/run/runner.test.ts

@@ -31,7 +31,7 @@ describe("resolveRunAgent", () => {
     )
 
     // then
-    expect(agent).toBe("Hephaestus (Deep Agent)")
+    expect(agent).toBe("Hephaestus - Deep Agent")
   })
 
   it("uses env agent over config", () => {
@@ -43,7 +43,7 @@ describe("resolveRunAgent", () => {
     const agent = resolveRunAgent({ message: "test" }, config, env)
 
     // then
-    expect(agent).toBe("Atlas (Plan Executor)")
+    expect(agent).toBe("Atlas - Plan Executor")
   })
 
   it("uses config agent over default", () => {
@@ -54,7 +54,7 @@ describe("resolveRunAgent", () => {
     const agent = resolveRunAgent({ message: "test" }, config, {})
 
     // then
-    expect(agent).toBe("Prometheus (Plan Builder)")
+    expect(agent).toBe("Prometheus - Plan Builder")
   })
 
   it("falls back to sisyphus when none set", () => {
@@ -65,7 +65,7 @@ describe("resolveRunAgent", () => {
     const agent = resolveRunAgent({ message: "test" }, config, {})
 
     // then
-    expect(agent).toBe("Sisyphus (Ultraworker)")
+    expect(agent).toBe("Sisyphus - Ultraworker")
   })
 
   it("skips disabled sisyphus for next available core agent", () => {
@@ -76,18 +76,18 @@ describe("resolveRunAgent", () => {
     const agent = resolveRunAgent({ message: "test" }, config, {})
 
     // then
-    expect(agent).toBe("Hephaestus (Deep Agent)")
+    expect(agent).toBe("Hephaestus - Deep Agent")
   })
 
   it("maps display-name style default_run_agent values to canonical display names", () => {
     // given
-    const config = createConfig({ default_run_agent: "Sisyphus (Ultraworker)" })
+    const config = createConfig({ default_run_agent: "Sisyphus - Ultraworker" })
 
     // when
     const agent = resolveRunAgent({ message: "test" }, config, {})
 
     // then
-    expect(agent).toBe("Sisyphus (Ultraworker)")
+    expect(agent).toBe("Sisyphus - Ultraworker")
   })
 })