e5b7fd40bb
test(non-interactive-env): add idempotency test for env prefix injection
2026-02-13 21:51:38 -03:00
f146aeff0f
refactor: major codebase cleanup - BDD comments, file splitting, bug fixes ( #1350 )
...
* style(tests): normalize BDD comments from '// #given' to '// given'
- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given
* fix(rules-injector): prefer output.metadata.filePath over output.title
- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label
* feat(slashcommand): add optional user_message parameter
- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage
* feat(hooks): restore compaction-context-injector hook
- Restore hook deleted in cbbc7bd0justsisyphus@users.noreply.github.com >
2026-02-01 16:47:50 +09:00
15c4637e0a
fix(hooks): use unix shell syntax for bash tool on all platforms ( #1015 )
...
The bash tool always runs in a Unix-like shell (bash/sh), even on Windows (via Git Bash, WSL, etc.), so we should always use unix export syntax instead of detecting the shell type dynamically.
Fixes #983
Fixes #889
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode )
Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com >
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai >
2026-01-23 16:24:58 +09:00
4e8106b019
test: stabilize non-interactive env hook
...
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode )
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai >
2026-01-18 20:39:02 -05:00
c38b078c12
fix(test): isolate environment in non-interactive-env hook tests ( #822 )
...
- Delete PSModulePath in beforeEach() to prevent CI cross-platform detection
- Set SHELL=/bin/bash to ensure tests start with clean Unix-like environment
- Fixes flaky test failures on GitHub Actions CI runners
- Tests can still override these values for PowerShell-specific behavior
2026-01-16 00:54:53 +09:00
d6499cbe31
fix(non-interactive-env): add Windows/PowerShell support ( #573 )
...
* fix(non-interactive-env): add Windows/PowerShell support
- Create shared shell-env utility with cross-platform shell detection
- Detect shell type via PSModulePath, SHELL env vars, platform fallback
- Support Unix (export), PowerShell ($env:), and cmd.exe (set) syntax
- Add 41 comprehensive unit tests for shell-env utilities
- Add 5 cross-platform integration tests for hook behavior
- All 696 tests pass, type checking passes, build succeeds
Closes #566
* fix: address review feedback - add isNonInteractive check and cmd.exe % escaping
- Add isNonInteractive() check to only apply env vars in CI/non-interactive contexts (Issue #566 )
- Fix cmd.exe percent sign escaping to prevent environment variable expansion
- Update test expectations for correct % escaping behavior
Resolves feedback from @greptile-apps and @cubic-dev-ai
---------
Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com >
2026-01-15 16:04:06 +09:00
f61e1a5f2b
fix(non-interactive-env): use export for env vars to apply to all chained commands
...
Previous `VAR=val cmd` format only applied to first command in chains.
New `export VAR=val; cmd` format ensures variables persist for all commands.
Also increased test timeouts for todo-continuation-enforcer stability.
🤖 GENERATED WITH ASSISTANCE OF [OhMyOpenCode](https://github.com/code-yeongyu/oh-my-opencode )
2026-01-03 15:36:01 +09:00
4a9bdc89aa
fix(non-interactive-env): prepend env vars directly to git command string
...
OpenCode's bash tool ignores args.env and uses hardcoded process.env in spawn().
Work around this by prepending GIT_EDITOR, EDITOR, VISUAL, and PAGER env vars
directly to the command string. Only applies to git commands to avoid bloating
non-git commands.
Added shellEscape() and buildEnvPrefix() helper functions to properly escape
env var values and construct the prefix string.
🤖 GENERATED WITH ASSISTANCE OF [OhMyOpenCode](https://github.com/code-yeongyu/oh-my-opencode )
2026-01-02 22:30:55 +09:00
Strocs