d5fbada13d
Move test coercion out of a hidden global and require each test to import the helper so review tools and runtime scripts can see the unsafe boundary. Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
202 lines
7.0 KiB
TypeScript
202 lines
7.0 KiB
TypeScript
/// <reference types="bun-types" />
|
|
|
|
import { describe, expect, spyOn, test } from "bun:test"
|
|
import type { PluginInput } from "@opencode-ai/plugin"
|
|
import { _resetForTesting, updateSessionAgent } from "../../features/claude-code-session-state"
|
|
import { getAgentDisplayName } from "../../shared/agent-display-names"
|
|
import { createNoSisyphusGptHook } from "./index"
|
|
import { unsafeTestValue } from "../../../test-support/unsafe-test-value"
|
|
|
|
const SISYPHUS_DISPLAY = getAgentDisplayName("sisyphus")
|
|
const HEPHAESTUS_DISPLAY = getAgentDisplayName("hephaestus")
|
|
|
|
type HookOutput = {
|
|
message: { agent?: string; variant?: string; [key: string]: unknown }
|
|
parts: unknown[]
|
|
}
|
|
|
|
function createOutput(): HookOutput {
|
|
return {
|
|
message: {},
|
|
parts: [],
|
|
}
|
|
}
|
|
|
|
function createHookContext(showToast: (input: unknown) => Promise<unknown>): PluginInput {
|
|
return unsafeTestValue<PluginInput>({
|
|
client: { tui: { showToast } },
|
|
})
|
|
}
|
|
|
|
describe("no-sisyphus-gpt hook", () => {
|
|
test("shows toast on every chat.message when sisyphus uses gpt model", async () => {
|
|
// given - sisyphus (display name) with gpt model
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook(createHookContext(showToast))
|
|
|
|
const output1 = createOutput()
|
|
const output2 = createOutput()
|
|
|
|
// when - chat.message is called repeatedly with display name
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_1",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.3-codex" },
|
|
}, output1)
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_1",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.3-codex" },
|
|
}, output2)
|
|
|
|
// then - toast is shown for every message
|
|
expect(showToast).toHaveBeenCalledTimes(2)
|
|
expect(output1.message.agent).toBe("hephaestus")
|
|
expect(output2.message.agent).toBe("hephaestus")
|
|
const firstToastCall = (showToast.mock.calls as Array<Array<unknown>>)[0]?.[0]
|
|
expect(firstToastCall).toMatchObject({
|
|
body: {
|
|
title: "NEVER Use Sisyphus with GPT",
|
|
message: expect.stringContaining("For other GPT models, always use Hephaestus."),
|
|
variant: "error",
|
|
},
|
|
})
|
|
})
|
|
|
|
test("does not show toast for gpt-5.4 model (Sisyphus has specialized support)", async () => {
|
|
// given - sisyphus with gpt-5.4 model (should be allowed)
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook(createHookContext(showToast))
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs with gpt-5.4
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_gpt54",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.4" },
|
|
}, output)
|
|
|
|
// then - no toast, agent NOT switched to Hephaestus
|
|
expect(showToast).toHaveBeenCalledTimes(0)
|
|
expect(output.message.agent).toBeUndefined()
|
|
})
|
|
|
|
test("does not show toast for gpt-5.5 model (native Sisyphus support)", async () => {
|
|
// given - sisyphus with gpt-5.5 model (should be allowed)
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook(createHookContext(showToast))
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs with gpt-5.5
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_gpt55",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.5" },
|
|
}, output)
|
|
|
|
// then - no toast, agent NOT switched to Hephaestus
|
|
expect(showToast).toHaveBeenCalledTimes(0)
|
|
expect(output.message.agent).toBeUndefined()
|
|
})
|
|
|
|
test("sets medium variant for gpt-5.5 model when native Sisyphus support is used", async () => {
|
|
// given - sisyphus with gpt-5.5 model and no selected variant
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook(createHookContext(showToast))
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs with gpt-5.5
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_gpt55_medium",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.5" },
|
|
}, output)
|
|
|
|
// then - Sisyphus stays active and receives its configured GPT-5.5 variant
|
|
expect(showToast).toHaveBeenCalledTimes(0)
|
|
expect(output.message.agent).toBeUndefined()
|
|
expect(output.message.variant).toBe("medium")
|
|
})
|
|
|
|
test("preserves selected variant for gpt-5.5 model when native Sisyphus support is used", async () => {
|
|
// given - sisyphus with gpt-5.5 model and a selected variant
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook(createHookContext(showToast))
|
|
|
|
const output: HookOutput = { message: { variant: "high" }, parts: [] }
|
|
|
|
// when - chat.message runs with gpt-5.5
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_gpt55_high",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.5" },
|
|
}, output)
|
|
|
|
// then - user-selected variant is not overwritten
|
|
expect(showToast).toHaveBeenCalledTimes(0)
|
|
expect(output.message.agent).toBeUndefined()
|
|
expect(output.message.variant).toBe("high")
|
|
})
|
|
|
|
test("does not show toast for non-gpt model", async () => {
|
|
// given - sisyphus with claude model
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook(createHookContext(showToast))
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_2",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "anthropic", modelID: "claude-opus-4-7" },
|
|
}, output)
|
|
|
|
// then - no toast
|
|
expect(showToast).toHaveBeenCalledTimes(0)
|
|
expect(output.message.agent).toBeUndefined()
|
|
})
|
|
|
|
test("does not show toast for non-sisyphus agent", async () => {
|
|
// given - hephaestus with gpt model
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook(createHookContext(showToast))
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_3",
|
|
agent: HEPHAESTUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.4" },
|
|
}, output)
|
|
|
|
// then - no toast
|
|
expect(showToast).toHaveBeenCalledTimes(0)
|
|
expect(output.message.agent).toBeUndefined()
|
|
})
|
|
|
|
test("uses session agent fallback when input agent is missing", async () => {
|
|
// given - session agent saved with display name (as OpenCode stores it)
|
|
_resetForTesting()
|
|
updateSessionAgent("ses_4", SISYPHUS_DISPLAY)
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook(createHookContext(showToast))
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs without input.agent
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_4",
|
|
model: { providerID: "openai", modelID: "gpt-4o" },
|
|
}, output)
|
|
|
|
// then - toast shown via session-agent fallback
|
|
expect(showToast).toHaveBeenCalledTimes(1)
|
|
expect(output.message.agent).toBe("hephaestus")
|
|
})
|
|
})
|