oh-my-opencode/src/features/boulder-state/storage.test.ts

import { describe, expect, test, beforeEach, afterEach } from "bun:test"
import { existsSync, mkdirSync, rmSync, writeFileSync } from "node:fs"
import { join } from "node:path"
import { tmpdir } from "node:os"
import {
  readBoulderState,
  writeBoulderState,
  appendSessionId,
  clearBoulderState,
  getPlanProgress,
  getPlanName,
  createBoulderState,
  findPrometheusPlans,
  getTaskSessionState,
  upsertTaskSessionState,
} from "./storage"
import type { BoulderState } from "./types"
import { readCurrentTopLevelTask } from "./top-level-task"

describe("boulder-state", () => {
  const TEST_DIR = join(tmpdir(), "boulder-state-test-" + Date.now())
  const SISYPHUS_DIR = join(TEST_DIR, ".sisyphus")

  beforeEach(() => {
    if (!existsSync(TEST_DIR)) {
      mkdirSync(TEST_DIR, { recursive: true })
    }
    if (!existsSync(SISYPHUS_DIR)) {
      mkdirSync(SISYPHUS_DIR, { recursive: true })
    }
    clearBoulderState(TEST_DIR)
  })

  afterEach(() => {
    if (existsSync(TEST_DIR)) {
      rmSync(TEST_DIR, { recursive: true, force: true })
    }
  })

  describe("readBoulderState", () => {
    test("should return null when no boulder.json exists", () => {
      // given - no boulder.json file
      // when
      const result = readBoulderState(TEST_DIR)
      // then
      expect(result).toBeNull()
    })

    test("should return null for JSON null value", () => {
      //#given - boulder.json containing null
      const boulderFile = join(SISYPHUS_DIR, "boulder.json")
      writeFileSync(boulderFile, "null")

      //#when
      const result = readBoulderState(TEST_DIR)

      //#then
      expect(result).toBeNull()
    })

    test("should return null for JSON primitive value", () => {
      //#given - boulder.json containing a string
      const boulderFile = join(SISYPHUS_DIR, "boulder.json")
      writeFileSync(boulderFile, '"just a string"')

      //#when
      const result = readBoulderState(TEST_DIR)

      //#then
      expect(result).toBeNull()
    })

    test("should default session_ids to [] when missing from JSON", () => {
      //#given - boulder.json without session_ids field
      const boulderFile = join(SISYPHUS_DIR, "boulder.json")
      writeFileSync(boulderFile, JSON.stringify({
        active_plan: "/path/to/plan.md",
        started_at: "2026-01-01T00:00:00Z",
        plan_name: "plan",
      }))

      //#when
      const result = readBoulderState(TEST_DIR)

      //#then
      expect(result).not.toBeNull()
      expect(result!.session_ids).toEqual([])
    })

    test("should default session_ids to [] when not an array", () => {
      //#given - boulder.json with session_ids as a string
      const boulderFile = join(SISYPHUS_DIR, "boulder.json")
      writeFileSync(boulderFile, JSON.stringify({
        active_plan: "/path/to/plan.md",
        started_at: "2026-01-01T00:00:00Z",
        session_ids: "not-an-array",
        plan_name: "plan",
      }))

      //#when
      const result = readBoulderState(TEST_DIR)

      //#then
      expect(result).not.toBeNull()
      expect(result!.session_ids).toEqual([])
    })

    test("should default session_ids to [] for empty object", () => {
      //#given - boulder.json with empty object
      const boulderFile = join(SISYPHUS_DIR, "boulder.json")
      writeFileSync(boulderFile, JSON.stringify({}))

      //#when
      const result = readBoulderState(TEST_DIR)

      //#then
      expect(result).not.toBeNull()
      expect(result!.session_ids).toEqual([])
    })

    test("should backfill missing origin as direct only for a single tracked session", () => {
      // given
      const boulderFile = join(SISYPHUS_DIR, "boulder.json")
      writeFileSync(boulderFile, JSON.stringify({
        active_plan: "/path/to/plan.md",
        started_at: "2026-01-01T00:00:00Z",
        session_ids: ["session-1"],
        plan_name: "plan",
      }))

      // when
      const result = readBoulderState(TEST_DIR)

      // then
      expect(result?.session_origins).toEqual({ "session-1": "direct" })
    })

    test("should keep missing origins empty when multiple sessions are tracked", () => {
      // given
      const boulderFile = join(SISYPHUS_DIR, "boulder.json")
      writeFileSync(boulderFile, JSON.stringify({
        active_plan: "/path/to/plan.md",
        started_at: "2026-01-01T00:00:00Z",
        session_ids: ["session-1", "session-2"],
        plan_name: "plan",
      }))

      // when
      const result = readBoulderState(TEST_DIR)

      // then
      expect(result?.session_origins).toEqual({})
    })
    test("should read valid boulder state", () => {
      // given - valid boulder.json
      const state: BoulderState = {
        active_plan: "/path/to/plan.md",
        started_at: "2026-01-02T10:00:00Z",
        session_ids: ["session-1", "session-2"],
        plan_name: "my-plan",
      }
      writeBoulderState(TEST_DIR, state)

      // when
      const result = readBoulderState(TEST_DIR)

      // then
      expect(result).not.toBeNull()
      expect(result?.active_plan).toBe("/path/to/plan.md")
      expect(result?.session_ids).toEqual(["session-1", "session-2"])
      expect(result?.plan_name).toBe("my-plan")
    })

    test("should default task_sessions to empty object when missing from JSON", () => {
      // given - boulder.json without task_sessions field
      const boulderFile = join(SISYPHUS_DIR, "boulder.json")
      writeFileSync(boulderFile, JSON.stringify({
        active_plan: "/path/to/plan.md",
        started_at: "2026-01-01T00:00:00Z",
        session_ids: ["session-1"],
        plan_name: "plan",
      }))

      // when
      const result = readBoulderState(TEST_DIR)

      // then
      expect(result).not.toBeNull()
      expect(result!.task_sessions).toEqual({})
    })
  })

  describe("writeBoulderState", () => {
    test("should write state and create .sisyphus directory if needed", () => {
      // given - state to write
      const state: BoulderState = {
        active_plan: "/test/plan.md",
        started_at: "2026-01-02T12:00:00Z",
        session_ids: ["ses-123"],
        plan_name: "test-plan",
      }

      // when
      const success = writeBoulderState(TEST_DIR, state)
      const readBack = readBoulderState(TEST_DIR)

      // then
      expect(success).toBe(true)
      expect(readBack).not.toBeNull()
      expect(readBack?.active_plan).toBe("/test/plan.md")
    })
  })

  describe("appendSessionId", () => {
    test("should append new session id to existing state", () => {
      // given - existing state with one session
      const state: BoulderState = {
        active_plan: "/plan.md",
        started_at: "2026-01-02T10:00:00Z",
        session_ids: ["session-1"],
        plan_name: "plan",
      }
      writeBoulderState(TEST_DIR, state)

      // when
      const result = appendSessionId(TEST_DIR, "session-2")

      // then
      expect(result).not.toBeNull()
      expect(result?.session_ids).toEqual(["session-1", "session-2"])
    })

    test("should not duplicate existing session id", () => {
      // given - state with session-1 already
      const state: BoulderState = {
        active_plan: "/plan.md",
        started_at: "2026-01-02T10:00:00Z",
        session_ids: ["session-1"],
        plan_name: "plan",
      }
      writeBoulderState(TEST_DIR, state)

      // when
      appendSessionId(TEST_DIR, "session-1")
      const result = readBoulderState(TEST_DIR)

      // then
      expect(result?.session_ids).toEqual(["session-1"])
    })

    test("should return null when no state exists", () => {
      // given - no boulder.json
      // when
      const result = appendSessionId(TEST_DIR, "new-session")
      // then
      expect(result).toBeNull()
    })

    test("should not crash when boulder.json has no session_ids field", () => {
      //#given - boulder.json without session_ids
      const boulderFile = join(SISYPHUS_DIR, "boulder.json")
      writeFileSync(boulderFile, JSON.stringify({
        active_plan: "/plan.md",
        started_at: "2026-01-01T00:00:00Z",
        plan_name: "plan",
      }))

      //#when
      const result = appendSessionId(TEST_DIR, "ses-new")

      //#then - should not crash and should contain the new session
      expect(result).not.toBeNull()
      expect(result!.session_ids).toContain("ses-new")
    })

    test("should persist appended session origin when provided", () => {
      // given
      writeBoulderState(TEST_DIR, {
        active_plan: "/path/to/plan.md",
        started_at: "2026-01-02T10:00:00Z",
        session_ids: ["session-1"],
        session_origins: { "session-1": "direct" },
        plan_name: "plan",
      })

      // when
      const result = appendSessionId(TEST_DIR, "session-2", "appended")

      // then
      expect(result?.session_origins).toEqual({
        "session-1": "direct",
        "session-2": "appended",
      })
    })
  })

  describe("clearBoulderState", () => {
    test("should remove boulder.json", () => {
      // given - existing state
      const state: BoulderState = {
        active_plan: "/plan.md",
        started_at: "2026-01-02T10:00:00Z",
        session_ids: ["session-1"],
        plan_name: "plan",
      }
      writeBoulderState(TEST_DIR, state)

      // when
      const success = clearBoulderState(TEST_DIR)
      const result = readBoulderState(TEST_DIR)

      // then
      expect(success).toBe(true)
      expect(result).toBeNull()
    })

    test("should succeed even when no file exists", () => {
      // given - no boulder.json
      // when
      const success = clearBoulderState(TEST_DIR)
      // then
      expect(success).toBe(true)
    })
  })

  describe("task session state", () => {
    test("should persist and read preferred session for a top-level plan task", () => {
      // given - existing boulder state
      const state: BoulderState = {
        active_plan: "/plan.md",
        started_at: "2026-01-02T10:00:00Z",
        session_ids: ["session-1"],
        plan_name: "plan",
      }
      writeBoulderState(TEST_DIR, state)

      // when
      upsertTaskSessionState(TEST_DIR, {
        taskKey: "todo:1",
        taskLabel: "1",
        taskTitle: "Implement auth flow",
        sessionId: "ses_task_123",
        agent: "sisyphus-junior",
        category: "deep",
      })
      const result = getTaskSessionState(TEST_DIR, "todo:1")

      // then
      expect(result).not.toBeNull()
      expect(result?.session_id).toBe("ses_task_123")
      expect(result?.task_title).toBe("Implement auth flow")
      expect(result?.agent).toBe("sisyphus-junior")
      expect(result?.category).toBe("deep")
    })

    test("should overwrite preferred session for the same top-level plan task", () => {
      // given - existing boulder state with prior preferred session
      const state: BoulderState = {
        active_plan: "/plan.md",
        started_at: "2026-01-02T10:00:00Z",
        session_ids: ["session-1"],
        plan_name: "plan",
        task_sessions: {
          "todo:1": {
            task_key: "todo:1",
            task_label: "1",
            task_title: "Implement auth flow",
            session_id: "ses_old",
            updated_at: "2026-01-02T10:00:00Z",
          },
        },
      }
      writeBoulderState(TEST_DIR, state)

      // when
      upsertTaskSessionState(TEST_DIR, {
        taskKey: "todo:1",
        taskLabel: "1",
        taskTitle: "Implement auth flow",
        sessionId: "ses_new",
      })
      const result = getTaskSessionState(TEST_DIR, "todo:1")

      // then
      expect(result?.session_id).toBe("ses_new")
    })
  })

  describe("readCurrentTopLevelTask", () => {
    test("should return the first unchecked top-level task in TODOs", () => {
      // given - plan with nested and top-level unchecked tasks
      const planPath = join(TEST_DIR, "current-task-plan.md")
      writeFileSync(planPath, `# Plan

## TODOs
- [x] 1. Finished task
  - [ ] nested acceptance checkbox
- [ ] 2. Current task

## Final Verification Wave
- [ ] F1. Final review
`)

      // when
      const result = readCurrentTopLevelTask(planPath)

      // then
      expect(result).not.toBeNull()
      expect(result?.key).toBe("todo:2")
      expect(result?.title).toBe("Current task")
    })

    test("should fall back to final-wave task when implementation tasks are complete", () => {
      // given - plan with only final-wave work remaining
      const planPath = join(TEST_DIR, "final-wave-current-task-plan.md")
      writeFileSync(planPath, `# Plan

## TODOs
- [x] 1. Finished task

## Final Verification Wave
- [ ] F1. Final review
`)

      // when
      const result = readCurrentTopLevelTask(planPath)

      // then
      expect(result).not.toBeNull()
      expect(result?.key).toBe("final-wave:f1")
      expect(result?.title).toBe("Final review")
    })
  })

  describe("getPlanProgress", () => {
    test("should count only top-level tasks under TODOs and Final Verification Wave sections", () => {
      // given - plan with top-level tasks in tracked sections
      const planPath = join(TEST_DIR, "test-plan.md")
      writeFileSync(planPath, `# Plan

## TODOs
- [ ] 1. Task 1
- [x] 2. Task 2
- [ ] 3. Task 3
- [X] 4. Task 4

## Final Verification Wave
- [ ] F1. Final review
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(5)
      expect(progress.completed).toBe(2)
      expect(progress.isComplete).toBe(false)
    })

    test("should ignore nested Acceptance Criteria checkboxes under TODOs (issue #3066)", () => {
      // given - plan with 9 completed top-level tasks and unchecked nested acceptance criteria
      const planPath = join(TEST_DIR, "issue-3066-plan.md")
      writeFileSync(planPath, `# Plan

## TODOs
- [x] 1. Implement feature A

  **Acceptance Criteria**
  - [ ] criterion 1
  - [ ] criterion 2

- [x] 2. Implement feature B

  **Acceptance Criteria**
  - [ ] criterion 3
  - [ ] criterion 4

- [x] 3. Implement feature C
- [x] 4. Implement feature D
- [x] 5. Implement feature E
- [x] 6. Implement feature F
- [x] 7. Implement feature G
- [x] 8. Implement feature H
- [x] 9. Implement feature I

## Final Verification Wave
- [ ] F1. Final review
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(10)
      expect(progress.completed).toBe(9)
      expect(progress.isComplete).toBe(false)
    })

    test("should ignore checkboxes outside TODOs and Final Verification Wave sections", () => {
      // given - plan with checkboxes in Work Objectives, Success Criteria, and other sections
      const planPath = join(TEST_DIR, "ignore-other-sections-plan.md")
      writeFileSync(planPath, `# Plan

## Work Objectives

### Definition of Done
- [ ] Verifiable condition with command

## TODOs
- [x] 1. Real task one
- [ ] 2. Real task two

## Success Criteria

### Final Checklist
- [ ] All Must Have present
- [ ] All Must NOT Have absent
- [ ] All tests pass
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(2)
      expect(progress.completed).toBe(1)
      expect(progress.isComplete).toBe(false)
    })

    test("should ignore indented checkboxes under top-level tasks", () => {
      // given - plan with indented unchecked nested checkboxes
      const planPath = join(TEST_DIR, "nested-indented-plan.md")
      writeFileSync(planPath, `# Plan

## TODOs
- [x] 1. top-level completed task
  - [ ] nested unchecked task
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(1)
      expect(progress.completed).toBe(1)
      expect(progress.isComplete).toBe(true)
    })

    test("should require proper task label format in TODOs", () => {
      // given - plan with malformed labels (no numeric prefix)
      const planPath = join(TEST_DIR, "malformed-labels-plan.md")
      writeFileSync(planPath, `# Plan

## TODOs
- [ ] no number prefix
- [x] 1. Valid numbered task
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(1)
      expect(progress.completed).toBe(1)
      expect(progress.isComplete).toBe(true)
    })

    test("should require F-prefix label format in Final Verification Wave", () => {
      // given - plan with malformed final-wave labels
      const planPath = join(TEST_DIR, "malformed-final-plan.md")
      writeFileSync(planPath, `# Plan

## TODOs
- [x] 1. Implementation done

## Final Verification Wave
- [ ] missing F-prefix
- [ ] F1. Proper final review
- [x] F2. Another final review
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(3)
      expect(progress.completed).toBe(2)
      expect(progress.isComplete).toBe(false)
    })

    test("should return isComplete true when all top-level tasks checked", () => {
      // given - all top-level tasks completed
      const planPath = join(TEST_DIR, "complete-plan.md")
      writeFileSync(planPath, `# Plan

## TODOs
- [x] 1. Task 1
- [X] 2. Task 2

## Final Verification Wave
- [x] F1. Final review
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(3)
      expect(progress.completed).toBe(3)
      expect(progress.isComplete).toBe(true)
    })

    test("should return isComplete false for empty plan", () => {
      // given - plan with no checkboxes
      const planPath = join(TEST_DIR, "empty-plan.md")
      writeFileSync(planPath, "# Plan\nNo tasks here")

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(0)
      expect(progress.isComplete).toBe(false)
    })

    test("should handle non-existent file", () => {
      // given - non-existent file
      // when
      const progress = getPlanProgress("/non/existent/file.md")
      // then
      expect(progress.total).toBe(0)
      expect(progress.isComplete).toBe(true)
    })

    test("should support asterisk bullet top-level tasks", () => {
      // given - plan with asterisk bullet tasks
      const planPath = join(TEST_DIR, "asterisk-bullet-plan.md")
      writeFileSync(planPath, `# Plan

## TODOs
* [x] 1. Task using asterisk bullet
* [ ] 2. Another asterisk task
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(2)
      expect(progress.completed).toBe(1)
      expect(progress.isComplete).toBe(false)
    })

    test("should count only top-level checkboxes for simple plans with nested tasks", () => {
      // given
      const planPath = join(TEST_DIR, "simple-nested-plan.md")
      writeFileSync(planPath, `# Plan

- [ ] Top-level task 1
  - [x] Nested task ignored
- [x] Top-level task 2
    * [ ] Another nested task ignored
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(2)
      expect(progress.completed).toBe(1)
      expect(progress.isComplete).toBe(false)
    })

    test("should treat final-wave-only plans as structured mode", () => {
      // given
      const planPath = join(TEST_DIR, "final-wave-only-plan.md")
      writeFileSync(planPath, `# Plan

## Final Verification Wave
- [ ] F1. Top-level final review
  - [x] Nested verification detail ignored
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(1)
      expect(progress.completed).toBe(0)
      expect(progress.isComplete).toBe(false)
    })

    test("should ignore mixed indentation levels in simple plans", () => {
      // given
      const planPath = join(TEST_DIR, "simple-mixed-indentation-plan.md")
      writeFileSync(planPath, `# Plan

* [x] Top-level star task
 - [ ] Indented task ignored
	- [x] Tab-indented task ignored
- [ ] Top-level dash task
`)

      // when
      const progress = getPlanProgress(planPath)

      // then
      expect(progress.total).toBe(2)
      expect(progress.completed).toBe(1)
      expect(progress.isComplete).toBe(false)
    })
  })

  describe("getPlanName", () => {
    test("should extract plan name from path", () => {
      // given
      const path = "/home/user/.sisyphus/plans/project/my-feature.md"
      // when
      const name = getPlanName(path)
      // then
      expect(name).toBe("my-feature")
    })
  })

  describe("createBoulderState", () => {
    test("should create state with correct fields", () => {
      // given
      const planPath = "/path/to/auth-refactor.md"
      const sessionId = "ses-abc123"

      // when
      const state = createBoulderState(planPath, sessionId)

      // then
      expect(state.active_plan).toBe(planPath)
      expect(state.session_ids).toEqual([sessionId])
      expect(state.plan_name).toBe("auth-refactor")
      expect(state.started_at).toBeDefined()
    })

    test("should include agent field when provided", () => {
      //#given - plan path, session id, and agent type
      const planPath = "/path/to/feature.md"
      const sessionId = "ses-xyz789"
      const agent = "atlas"

      //#when - createBoulderState is called with agent
      const state = createBoulderState(planPath, sessionId, agent)

      //#then - state should include the agent field
      expect(state.agent).toBe("atlas")
      expect(state.active_plan).toBe(planPath)
      expect(state.session_ids).toEqual([sessionId])
      expect(state.plan_name).toBe("feature")
    })

    test("should mark the initial session origin as direct", () => {
      // given
      const planPath = "/path/to/feature.md"
      const sessionId = "ses-origin"

      // when
      const state = createBoulderState(planPath, sessionId)

      // then
      expect(state.session_origins).toEqual({ [sessionId]: "direct" })
    })

    test("should allow agent to be undefined", () => {
      //#given - plan path and session id without agent
      const planPath = "/path/to/legacy.md"
      const sessionId = "ses-legacy"

      //#when - createBoulderState is called without agent
      const state = createBoulderState(planPath, sessionId)

      //#then - state should not have agent field (backward compatible)
      expect(state.agent).toBeUndefined()
    })
  })
})