YeonGyu-Kim
fc70dd2492
* style(tests): normalize BDD comments from '// #given' to '// given'
- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given
* fix(rules-injector): prefer output.metadata.filePath over output.title
- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label
* feat(slashcommand): add optional user_message parameter
- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage
* feat(hooks): restore compaction-context-injector hook
- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry
* refactor(background-agent): split manager.ts into focused modules
- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports
* refactor(agents): split prometheus-prompt.ts into subdirectory
- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports
* refactor(delegate-task): split tools.ts into focused modules
- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns
* refactor(builtin-skills): split skills.ts into individual skill files
- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules
* chore: update import paths and lockfile
- Update prometheus import path after refactor
- Update bun.lock
* fix(tests): complete BDD comment normalization
- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts
---------
Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
90 lines
2.8 KiB
TypeScript
90 lines
2.8 KiB
TypeScript
import { describe, it, expect } from "bun:test"
|
|
import { createSlashcommandTool } from "./tools"
|
|
import type { CommandInfo } from "./types"
|
|
import type { LoadedSkill } from "../../features/opencode-skill-loader"
|
|
|
|
function createMockCommand(name: string, description = ""): CommandInfo {
|
|
return {
|
|
name,
|
|
metadata: {
|
|
name,
|
|
description: description || `Test command ${name}`,
|
|
},
|
|
scope: "builtin",
|
|
}
|
|
}
|
|
|
|
function createMockSkill(name: string, description = ""): LoadedSkill {
|
|
return {
|
|
name,
|
|
path: `/test/skills/${name}/SKILL.md`,
|
|
resolvedPath: `/test/skills/${name}`,
|
|
definition: {
|
|
name,
|
|
description: description || `Test skill ${name}`,
|
|
template: "Test template",
|
|
},
|
|
scope: "opencode-project",
|
|
}
|
|
}
|
|
|
|
describe("slashcommand tool - synchronous description", () => {
|
|
it("includes available_skills immediately when commands and skills are pre-provided", () => {
|
|
// given
|
|
const commands = [createMockCommand("commit", "Create a git commit")]
|
|
const skills = [createMockSkill("playwright", "Browser automation via Playwright MCP")]
|
|
|
|
// when
|
|
const tool = createSlashcommandTool({ commands, skills })
|
|
|
|
// then
|
|
expect(tool.description).toContain("<available_skills>")
|
|
expect(tool.description).toContain("commit")
|
|
expect(tool.description).toContain("playwright")
|
|
})
|
|
|
|
it("includes all pre-provided commands and skills in description immediately", () => {
|
|
// given
|
|
const commands = [
|
|
createMockCommand("commit", "Git commit"),
|
|
createMockCommand("plan", "Create plan"),
|
|
]
|
|
const skills = [
|
|
createMockSkill("playwright", "Browser automation"),
|
|
createMockSkill("frontend-ui-ux", "Frontend design"),
|
|
createMockSkill("git-master", "Git operations"),
|
|
]
|
|
|
|
// when
|
|
const tool = createSlashcommandTool({ commands, skills })
|
|
|
|
// then
|
|
expect(tool.description).toContain("commit")
|
|
expect(tool.description).toContain("plan")
|
|
expect(tool.description).toContain("playwright")
|
|
expect(tool.description).toContain("frontend-ui-ux")
|
|
expect(tool.description).toContain("git-master")
|
|
})
|
|
|
|
it("shows prefix-only description when both commands and skills are empty", () => {
|
|
// given / #when
|
|
const tool = createSlashcommandTool({ commands: [], skills: [] })
|
|
|
|
// then - even with no items, description should be built synchronously (not just prefix)
|
|
expect(tool.description).toContain("Load a skill")
|
|
})
|
|
|
|
it("includes user_message parameter documentation in description", () => {
|
|
// given
|
|
const commands = [createMockCommand("publish", "Publish package")]
|
|
const skills: LoadedSkill[] = []
|
|
|
|
// when
|
|
const tool = createSlashcommandTool({ commands, skills })
|
|
|
|
// then
|
|
expect(tool.description).toContain("user_message")
|
|
expect(tool.description).toContain("command='publish' user_message='patch'")
|
|
})
|
|
})
|