Files
oh-my-opencode/src/config/schema/athena.test.ts
T
ismeth 5e71d84a69 feat(athena): add bulk_launch config for council launch strategy
New config: agents.athena.bulk_launch (boolean, default false)
- false: launch members one-by-one via task() for TUI inspectability
- true: launch all members at once via athena_council tool

Prompt uses {BULK_LAUNCH_STEP_5_2} placeholder injected at runtime
based on config value. Schema, caller, and tests updated.
2026-04-15 16:48:47 +09:00

768 lines
21 KiB
TypeScript

import { describe, expect, it, test } from "bun:test"
import { z } from "zod"
import { AthenaConfigSchema, CouncilConfigSchema, CouncilMemberSchema } from "./athena"
describe("CouncilMemberSchema", () => {
test("accepts member config with model and name", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6", name: "member-a" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("accepts member config with all optional fields", () => {
//#given
const config = {
model: "openai/gpt-5.3-codex",
variant: "high",
name: "analyst-a",
temperature: 0.3,
}
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("rejects member config missing model", () => {
//#given
const config = { name: "no-model" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects model string without provider/model separator", () => {
//#given
const config = { model: "invalid-model", name: "test-member" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects model string with empty provider", () => {
//#given
const config = { model: "/gpt-5.3-codex", name: "test-member" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects model string with empty model ID", () => {
//#given
const config = { model: "openai/", name: "test-member" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects empty model string", () => {
//#given
const config = { model: "" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("z.infer produces expected type shape", () => {
//#given
type InferredCouncilMember = z.infer<typeof CouncilMemberSchema>
const member: InferredCouncilMember = {
model: "anthropic/claude-opus-4-6",
variant: "medium",
name: "oracle",
}
//#when
const model = member.model
//#then
expect(model).toBe("anthropic/claude-opus-4-6")
})
test("optional fields are optional without runtime defaults", () => {
//#given
const config = { model: "xai/grok-code-fast-1", name: "member-x" }
//#when
const parsed = CouncilMemberSchema.parse(config)
//#then
expect(parsed.variant).toBeUndefined()
expect(parsed.temperature).toBeUndefined()
})
test("rejects member config missing name", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects member config with empty name", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6", name: "" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("accepts member config with temperature", () => {
//#given
const config = { model: "openai/gpt-5.3-codex", name: "member-a", temperature: 0.5 }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.temperature).toBe(0.5)
}
})
test("rejects temperature below 0", () => {
//#given
const config = { model: "openai/gpt-5.3-codex", name: "test-member", temperature: -0.1 }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects temperature above 2", () => {
//#given
const config = { model: "openai/gpt-5.3-codex", name: "test-member", temperature: 2.1 }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects member config with unknown fields", () => {
//#given
const config = { model: "openai/gpt-5.3-codex", name: "test-member", unknownField: true }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("trims leading and trailing whitespace from name", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6", name: " member-a " }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.name).toBe("member-a")
}
})
test("accepts name with spaces like 'Claude Opus 4'", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6", name: "Claude Opus 4" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("accepts name with dots like 'Claude 4.6'", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6", name: "Claude 4.6" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("accepts name with hyphens like 'my-model-1'", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6", name: "my-model-1" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("rejects name with special characters like '@'", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6", name: "member@1" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects name with exclamation mark", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6", name: "member!" }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects name starting with a space after trim", () => {
//#given
const config = { model: "anthropic/claude-opus-4-6", name: " " }
//#when
const result = CouncilMemberSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
})
describe("CouncilConfigSchema", () => {
test("accepts council with 2 members", () => {
//#given
const config = {
members: [
{ model: "anthropic/claude-opus-4-6", name: "member-a" },
{ model: "openai/gpt-5.3-codex", name: "member-b" },
],
}
//#when
const result = CouncilConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("accepts council with 3 members and optional fields", () => {
//#given
const config = {
members: [
{ model: "anthropic/claude-opus-4-6", name: "a" },
{ model: "openai/gpt-5.3-codex", name: "b", variant: "high" },
{ model: "xai/grok-code-fast-1", name: "c", variant: "low" },
],
}
//#when
const result = CouncilConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("rejects council with 0 members", () => {
//#given
const config = { members: [] }
//#when
const result = CouncilConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects council with 1 member", () => {
//#given
const config = { members: [{ model: "anthropic/claude-opus-4-6", name: "member-a" }] }
//#when
const result = CouncilConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects council missing members field", () => {
//#given
const config = {}
//#when
const result = CouncilConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("accepts council with duplicate member names for graceful runtime handling", () => {
//#given - duplicate detection is handled at runtime by registerCouncilMemberAgents,
// not at schema level, to allow graceful fallback instead of hard parse failure
const config = {
members: [
{ model: "anthropic/claude-opus-4-6", name: "analyst" },
{ model: "openai/gpt-5.3-codex", name: "analyst" },
],
}
//#when
const result = CouncilConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("accepts council with case-insensitive duplicate names for graceful runtime handling", () => {
//#given - case-insensitive dedup is handled at runtime by registerCouncilMemberAgents
const config = {
members: [
{ model: "anthropic/claude-opus-4-6", name: "Claude" },
{ model: "openai/gpt-5.3-codex", name: "claude" },
],
}
//#when
const result = CouncilConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("accepts council with unique member names", () => {
//#given
const config = {
members: [
{ model: "anthropic/claude-opus-4-6", name: "analyst-a" },
{ model: "openai/gpt-5.3-codex", name: "analyst-b" },
],
}
//#when
const result = CouncilConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
})
describe("AthenaConfigSchema", () => {
test("accepts Athena config with council", () => {
//#given
const config = {
council: {
members: [
{ model: "openai/gpt-5.3-codex", name: "member-a" },
{ model: "xai/grok-code-fast-1", name: "member-b" },
],
},
}
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
test("rejects Athena config without council", () => {
//#given
const config = {}
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
test("rejects Athena config with unknown model field", () => {
//#given
const config = {
model: "anthropic/claude-opus-4-6",
council: {
members: [
{ model: "openai/gpt-5.3-codex", name: "member-a" },
{ model: "xai/grok-code-fast-1", name: "member-b" },
],
},
}
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
})
describe("CouncilConfigSchema — resilience fields", () => {
const validMembers = [
{ model: "openai/gpt-5.3-codex", name: "member-a" },
{ model: "anthropic/claude-opus-4-6", name: "member-b" },
]
describe("#given minimal config with only members", () => {
describe("#when parsed", () => {
it("#then applies default retry_on_fail of 0", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers })
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.retry_on_fail).toBe(0)
}
})
it("#then applies default retry_failed_if_others_finished of false", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers })
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.retry_failed_if_others_finished).toBe(false)
}
})
it("#then applies default cancel_retrying_on_quorum of true", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers })
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.cancel_retrying_on_quorum).toBe(true)
}
})
it("#then applies default stuck_threshold_seconds of 120", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers })
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.stuck_threshold_seconds).toBe(120)
}
})
it("#then applies default member_max_running_seconds of 1800", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers })
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.member_max_running_seconds).toBe(1800)
}
})
})
})
describe("#given config with all resilience fields set", () => {
describe("#when parsed", () => {
it("#then uses provided values instead of defaults", () => {
const config = {
members: validMembers,
retry_on_fail: 3,
retry_failed_if_others_finished: true,
cancel_retrying_on_quorum: false,
stuck_threshold_seconds: 60,
member_max_running_seconds: 2400,
}
const result = CouncilConfigSchema.safeParse(config)
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.retry_on_fail).toBe(3)
expect(result.data.retry_failed_if_others_finished).toBe(true)
expect(result.data.cancel_retrying_on_quorum).toBe(false)
expect(result.data.stuck_threshold_seconds).toBe(60)
expect(result.data.member_max_running_seconds).toBe(2400)
}
})
})
})
describe("#given retry_on_fail below minimum", () => {
describe("#when parsed with -1", () => {
it("#then fails validation", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers, retry_on_fail: -1 })
expect(result.success).toBe(false)
})
})
})
describe("#given retry_on_fail above maximum", () => {
describe("#when parsed with 6", () => {
it("#then fails validation", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers, retry_on_fail: 6 })
expect(result.success).toBe(false)
})
})
})
describe("#given stuck_threshold_seconds below minimum", () => {
describe("#when parsed with 10", () => {
it("#then fails validation", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers, stuck_threshold_seconds: 10 })
expect(result.success).toBe(false)
})
})
})
describe("#given member_max_running_seconds below minimum", () => {
describe("#when parsed with 30", () => {
it("#then fails validation", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers, member_max_running_seconds: 30 })
expect(result.success).toBe(false)
})
})
})
describe("#given backward-compatible config with only members", () => {
describe("#when parsed", () => {
it("#then succeeds without errors — new fields are optional", () => {
const result = CouncilConfigSchema.safeParse({ members: validMembers })
expect(result.success).toBe(true)
})
})
})
})
describe("AthenaConfigSchema — non-interactive fields", () => {
const validCouncil = {
members: [
{ model: "openai/gpt-5.3-codex", name: "council-opus" },
{ model: "anthropic/claude-opus-4-6", name: "council-gpt" },
],
}
describe("#given non_interactive_mode field", () => {
describe("#when parsed with 'delegation'", () => {
it("#then accepts the value", () => {
//#given
const config = { council: validCouncil, non_interactive_mode: "delegation" }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
})
describe("#when parsed with 'solo'", () => {
it("#then accepts the value", () => {
//#given
const config = { council: validCouncil, non_interactive_mode: "solo" }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
})
describe("#when parsed with an invalid value", () => {
it("#then rejects the value", () => {
//#given
const config = { council: validCouncil, non_interactive_mode: "invalid" }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
})
describe("#when parsed without non_interactive_mode", () => {
it("#then defaults to 'delegation'", () => {
//#given
const config = { council: validCouncil }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.non_interactive_mode).toBe("delegation")
}
})
})
})
describe("#given non_interactive_members field", () => {
describe("#when parsed with 'all'", () => {
it("#then accepts the value", () => {
//#given
const config = { council: validCouncil, non_interactive_members: "all" }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
})
describe("#when parsed with 'custom'", () => {
it("#then accepts the value", () => {
//#given
const config = { council: validCouncil, non_interactive_members: "custom" }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
})
})
describe("#when parsed without non_interactive_members", () => {
it("#then defaults to 'all'", () => {
//#given
const config = { council: validCouncil }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.non_interactive_members).toBe("all")
}
})
})
})
describe("#given non_interactive_member_list field", () => {
describe("#when parsed with a list of member names", () => {
it("#then accepts the value", () => {
//#given
const config = { council: validCouncil, non_interactive_member_list: ["Council: Opus"] }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.non_interactive_member_list).toEqual(["Council: Opus"])
}
})
})
describe("#when parsed without non_interactive_member_list", () => {
it("#then is undefined (optional)", () => {
//#given
const config = { council: validCouncil }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.non_interactive_member_list).toBeUndefined()
}
})
})
})
})
describe("AthenaConfigSchema — bulk_launch field", () => {
const validCouncil = {
members: [
{ model: "openai/gpt-5.3-codex", name: "council-opus" },
{ model: "anthropic/claude-opus-4-6", name: "council-gpt" },
],
}
describe("#given bulk_launch field", () => {
describe("#when parsed with true", () => {
it("#then accepts the value", () => {
//#given
const config = { council: validCouncil, bulk_launch: true }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.bulk_launch).toBe(true)
}
})
})
describe("#when parsed with false", () => {
it("#then accepts the value", () => {
//#given
const config = { council: validCouncil, bulk_launch: false }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.bulk_launch).toBe(false)
}
})
})
describe("#when parsed without bulk_launch", () => {
it("#then defaults to false", () => {
//#given
const config = { council: validCouncil }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(true)
if (result.success) {
expect(result.data.bulk_launch).toBe(false)
}
})
})
describe("#when parsed with a non-boolean value", () => {
it("#then rejects the value", () => {
//#given
const config = { council: validCouncil, bulk_launch: "yes" }
//#when
const result = AthenaConfigSchema.safeParse(config)
//#then
expect(result.success).toBe(false)
})
})
})
})