YeonGyu-Kim
4344a41eae
The auto-update-checker's version resolver hardcoded the canonical
oh-my-opencode package name in three read paths:
1. INSTALLED_PACKAGE_JSON pointed only at
cache/node_modules/oh-my-opencode/package.json
2. findPackageJsonUp() rejected any walked-up package.json whose name
did not equal PACKAGE_NAME
3. getLocalDevPath() only matched file:// plugin entries whose path
contained the canonical name
The publish pipeline ships the same code under two npm package names
(oh-my-opencode canonical, oh-my-openagent alias). Users who add
"oh-my-openagent" to their opencode config end up with
node_modules/oh-my-openagent/package.json, so every read path above
silently missed the installed version and the startup toast fell back
to "unknown".
Introduce ACCEPTED_PACKAGE_NAMES + INSTALLED_PACKAGE_JSON_CANDIDATES in
constants.ts and teach the three readers to accept both names. Writes
are untouched (sync-package-json, pinned-version-updater, cache
invalidation) because the auto-update-checker still owns its own cache
workspace and writes to the canonical name there.
Tests: 54 auto-update-checker tests pass (4 new), full 4444-test suite
passes, tsc clean. New tests cover both install paths, the walk-up
resolver, and the priority order when both candidates exist.
Closes #3257
36 lines
1.1 KiB
TypeScript
36 lines
1.1 KiB
TypeScript
import * as fs from "node:fs"
|
|
import { fileURLToPath } from "node:url"
|
|
import type { OpencodeConfig } from "../types"
|
|
import { ACCEPTED_PACKAGE_NAMES } from "../constants"
|
|
import { getConfigPaths } from "./config-paths"
|
|
import { stripJsonComments } from "./jsonc-strip"
|
|
|
|
export function isLocalDevMode(directory: string): boolean {
|
|
return getLocalDevPath(directory) !== null
|
|
}
|
|
|
|
export function getLocalDevPath(directory: string): string | null {
|
|
for (const configPath of getConfigPaths(directory)) {
|
|
try {
|
|
if (!fs.existsSync(configPath)) continue
|
|
const content = fs.readFileSync(configPath, "utf-8")
|
|
const config = JSON.parse(stripJsonComments(content)) as OpencodeConfig
|
|
const plugins = config.plugin ?? []
|
|
|
|
for (const entry of plugins) {
|
|
if (!entry.startsWith("file://")) continue
|
|
if (!ACCEPTED_PACKAGE_NAMES.some(name => entry.includes(name))) continue
|
|
try {
|
|
return fileURLToPath(entry)
|
|
} catch {
|
|
return entry.replace("file://", "")
|
|
}
|
|
}
|
|
} catch {
|
|
continue
|
|
}
|
|
}
|
|
|
|
return null
|
|
}
|