Files

T

YeonGyu-Kim 0d7c16a042 refactor(omo-codex): install agent TOMLs via symlinks at install time, drop sync-agents.py

The Python SessionStart hook (sync-agents.py) was a runtime side-effect
that copied agent TOMLs into CODEX_HOME/agents on every session start.
That design had three problems:

1. It was a Python script invoked via 'python3 ${PLUGIN_ROOT}/...' which
   is fragile on Windows where the binary may be 'python', and is the
   wrong layer for a one-shot install task.
2. Agent TOMLs landed as regular file copies, with no provenance link to
   the plugin cache and no tracking for clean uninstall.
3. An older release shipped TOMLs without the required 'name' field;
   because the current bundle no longer ships them, the hook never had
   a chance to overwrite the broken copies on disk, leaving Codex
   permanently warning at session start.

Replace the runtime hook with an install-time linker:
linkCachedPluginAgents() (src/cli/install-codex/link-cached-plugin-agents.ts).
The omo-codex CLI now calls it right after linkCachedPluginBins(). For
each 'components/*/agents/*.toml' in the plugin cache, it:

  - Linux / macOS: creates a symlink at ${CODEX_HOME}/agents/<basename>
    pointing at the cache TOML. The cache directory is the single source
    of truth; removing the cache cleanly breaks the link.
  - Windows: copies the file (symlinks require admin or Developer Mode).
  - Both platforms: writes a '.installed-agents.json' manifest under the
    plugin cache listing the installed absolute paths, so a future
    'omo uninstall --platform=codex' can remove them deterministically.

Stale regular-file copies (from the old sync-agents.py) are removed and
replaced on Unix. On Windows the existing copy is overwritten.

Tests (src/cli/install-codex/link-cached-plugin-agents.test.ts):
9 cross-platform tests that mock the 'platform' parameter to exercise
the Linux, macOS, and Windows code paths in a single 'bun test' run,
matching the existing pattern from linkCachedPluginBins. Covers symlink
creation, Windows copy, stale-file replacement, manifest writing,
idempotency, multi-component discovery, and the empty-bundle edge case.

Removed:
  - packages/omo-codex/plugin/components/ultrawork/hooks/sync-agents.py
  - packages/omo-codex/plugin/test/bundled-agents.test.mjs
    (it tested the Python hook; behaviour is now covered by the TS tests)
  - SessionStart hook entry in both ultrawork and aggregate hooks.json
  - 2 sync-agents tests + 1 manifest assertion in ultrawork-hooks.test.mjs
  - 'hooks/sync-agents.py' in ultrawork/package.json files list
  - sync-agents.py reference from aggregate.test.mjs component markers

Updated:
  - components/ultrawork/README.md, AGENTS.md: describe the install-time
    linker as the source of truth, no more SessionStart agent sync.

Verified end-to-end:
  bun run src/cli/index.ts install --no-tui --platform=codex
  ls -la ~/.codex/agents/  # all 4 TOMLs are symlinks pointing to cache
  cat ~/.codex/plugins/cache/.../omo/0.1.0/.installed-agents.json  # manifest present

2026-05-28 13:58:12 +09:00

2.0 KiB

Raw Blame History

Repository Conventions

Conventions for human contributors and AI agents working on this repository.

Style

Terse technical prose. No emojis in commits, issues, PR comments, or code.
Python: PEP 484 type hints. Hook script stays in standard-library only — no pip dependencies.
Tabs for indentation in JSON and Markdown tables. Spaces (4) for Python.
Double quotes for JSON strings.

Layout

hooks/ultrawork-detector.py — pure stdlib UserPromptSubmit hook. Reads JSON on stdin, writes the directive to stdout when the keyword matches, exits 0 otherwise.
agents/*.toml — bundled Codex agent role files. Installed into CODEX_HOME/agents/ by src/cli/install-codex/link-cached-plugin-agents.ts at install time (symlink on Unix, copy on Windows). No runtime SessionStart hook is involved.
hooks/hooks.json — registers the prompt-detector hook only.
.codex-plugin/plugin.json — Codex plugin manifest. Marketplace metadata lives here, not in package.json.

Constraints

Never let the hook block a turn — exit code is always 0.
Never make a network call from the hook.
Keep the directive in ULTRAWORK_DIRECTIVE self-contained inside the Python file. The prompt hook is a single artifact a reviewer can read top-to-bottom.
Keep bundled agent role prompts concise and model-specific; measure prompt length when changing them.
When editing ULTRAWORK_DIRECTIVE, apply the prompt-engineering skill's entropy gate: every edit must reduce uncertainty per token. Re-measure character count before committing.

Commands

# smoke test the hook
PAYLOAD='{"cwd":"/tmp","hook_event_name":"UserPromptSubmit","model":"gpt-5.5","permission_mode":"default","session_id":"x","transcript_path":"","turn_id":"y","prompt":"please ultrawork"}'
echo "$PAYLOAD" | python3 hooks/ultrawork-detector.py | head -3

# pattern boundary check (must be empty)
echo '{"hook_event_name":"UserPromptSubmit","prompt":"refactor ulw_helper.ts"}' | python3 hooks/ultrawork-detector.py | wc -c

2.0 KiB Raw Blame History

Repository Conventions

Style

Layout

Constraints

Commands

2.0 KiB

Raw Blame History