sanoyphilippe
6e700e000a
The tool-execute-after hook only processed the built-in 'task' tool.
Plugin tools (e.g. custom-agent-bridge delegate) that set
context.metadata({ metadata: { sessionId } }) were ignored by atlas
orchestration (boulder tracking, verification reminders).
- Add extractSessionIdFromMetadata() to read sessionId from tool
metadata, preferred over text-based extraction
- Extend tool-execute-after guard to also process any tool that has
metadata.sessionId set (not just tool === 'task')
- Recognize 'Background delegate launched' as a background launch
- Add tests for metadata-based session ID extraction
121 lines
3.2 KiB
TypeScript
121 lines
3.2 KiB
TypeScript
import { describe, expect, test } from "bun:test"
|
|
|
|
import { extractSessionIdFromMetadata, extractSessionIdFromOutput } from "./subagent-session-id"
|
|
|
|
describe("extractSessionIdFromOutput", () => {
|
|
test("extracts Session ID blocks from background output", () => {
|
|
// given
|
|
const output = `Background task launched.\n\nSession ID: ses_bg_12345`
|
|
|
|
// when
|
|
const result = extractSessionIdFromOutput(output)
|
|
|
|
// then
|
|
expect(result).toBe("ses_bg_12345")
|
|
})
|
|
|
|
test("extracts session_id from task metadata blocks", () => {
|
|
// given
|
|
const output = `Task completed.\n\n<task_metadata>\nsession_id: ses_sync_12345\n</task_metadata>`
|
|
|
|
// when
|
|
const result = extractSessionIdFromOutput(output)
|
|
|
|
// then
|
|
expect(result).toBe("ses_sync_12345")
|
|
})
|
|
|
|
test("extracts hyphenated session IDs from task metadata blocks", () => {
|
|
// given
|
|
const output = `Task completed.\n\n<task_metadata>\nsession_id: ses_auth-flow-123\n</task_metadata>`
|
|
|
|
// when
|
|
const result = extractSessionIdFromOutput(output)
|
|
|
|
// then
|
|
expect(result).toBe("ses_auth-flow-123")
|
|
})
|
|
|
|
test("returns undefined when no session id is present", () => {
|
|
// given
|
|
const output = "Task completed without metadata"
|
|
|
|
// when
|
|
const result = extractSessionIdFromOutput(output)
|
|
|
|
// then
|
|
expect(result).toBeUndefined()
|
|
})
|
|
|
|
test("prefers the session id inside the trailing task_metadata block", () => {
|
|
// given
|
|
const output = `The previous attempt mentioned session_id: ses_wrong_body_123 but that was only context.
|
|
|
|
<task_metadata>
|
|
session_id: ses_real_metadata_456
|
|
</task_metadata>`
|
|
|
|
// when
|
|
const result = extractSessionIdFromOutput(output)
|
|
|
|
// then
|
|
expect(result).toBe("ses_real_metadata_456")
|
|
})
|
|
|
|
test("does not let task_metadata parsing bleed into incidental body text after the closing tag", () => {
|
|
// given
|
|
const output = `<task_metadata>
|
|
session_id: ses_real_metadata_456
|
|
</task_metadata>
|
|
|
|
debug log: session_id: ses_wrong_body_789`
|
|
|
|
// when
|
|
const result = extractSessionIdFromOutput(output)
|
|
|
|
// then
|
|
expect(result).toBe("ses_real_metadata_456")
|
|
})
|
|
})
|
|
|
|
describe("extractSessionIdFromMetadata", () => {
|
|
test("extracts sessionId from tool metadata object", () => {
|
|
// given
|
|
const metadata = { sessionId: "ses_plugin_abc123" }
|
|
|
|
// when
|
|
const result = extractSessionIdFromMetadata(metadata)
|
|
|
|
// then
|
|
expect(result).toBe("ses_plugin_abc123")
|
|
})
|
|
|
|
test("returns undefined for metadata without sessionId", () => {
|
|
// given
|
|
const metadata = { title: "some task" }
|
|
|
|
// when
|
|
const result = extractSessionIdFromMetadata(metadata)
|
|
|
|
// then
|
|
expect(result).toBeUndefined()
|
|
})
|
|
|
|
test("returns undefined for non-object metadata", () => {
|
|
expect(extractSessionIdFromMetadata(null)).toBeUndefined()
|
|
expect(extractSessionIdFromMetadata(undefined)).toBeUndefined()
|
|
expect(extractSessionIdFromMetadata("string")).toBeUndefined()
|
|
})
|
|
|
|
test("rejects sessionId values that don't start with ses_", () => {
|
|
// given
|
|
const metadata = { sessionId: "not-a-session-id" }
|
|
|
|
// when
|
|
const result = extractSessionIdFromMetadata(metadata)
|
|
|
|
// then
|
|
expect(result).toBeUndefined()
|
|
})
|
|
})
|