Files
oh-my-opencode/packages/omo-codex/plugin/test/aggregate.test.mjs
T
YeonGyu-Kim 8c6e8e4986 refactor(omo-codex): rename ultragoal component to ulw-loop
Fully rename the ultragoal component to ulw-loop so the identifier
matches the ulw-loop skill it powers. Renames the component directory,
nested skill, TS identifiers (UlwLoop / ULW_LOOP_* / ulwLoop*), the
omo ulw-loop CLI subcommand, the .omo/ulw-loop state directory, the
OMO_ULW_LOOP_STEER directive token, and the @code-yeongyu/codex-ulw-loop
package. Also threads Atlas-style right-sized parallel worker delegation
and a Prometheus-style QA + maximum-parallelism plan into the ulw-loop
skill, with a critical post-subagent QA gate.

Updates aggregate wiring (plugin package components, hooks.json,
sync-skills), the install-codex agent-link test fixture, and user docs.
2026-05-29 12:38:22 +09:00

203 lines
7.1 KiB
JavaScript

import assert from "node:assert/strict";
import { readdir, readFile, stat } from "node:fs/promises";
import { basename, dirname, join } from "node:path";
import test from "node:test";
import { fileURLToPath } from "node:url";
const root = dirname(dirname(fileURLToPath(import.meta.url)));
async function readJson(relativePath) {
return JSON.parse(await readFile(join(root, relativePath), "utf8"));
}
function findSpawnAgentTypes(content) {
const agentTypes = new Set();
const regex = /spawn_agent\(agent_type="([^"]+)"/g;
for (const match of content.matchAll(regex)) {
agentTypes.add(match[1]);
}
return [...agentTypes].sort();
}
test("#given aggregate plugin manifest #when inspected #then it owns the omo namespace", async () => {
// given
const manifest = await readJson(".codex-plugin/plugin.json");
// when
const hookPath = manifest.hooks;
const skillsPath = manifest.skills;
const mcpPath = manifest.mcpServers;
// then
assert.equal(manifest.name, "omo");
assert.equal(hookPath, "./hooks/hooks.json");
assert.equal(skillsPath, "./skills/");
assert.equal(mcpPath, "./.mcp.json");
});
test("#given isolated components #when hooks are inspected #then commands stay inside component roots", async () => {
// given
const hooks = await readJson("hooks/hooks.json");
const text = JSON.stringify(hooks);
// when
const componentMarkers = [
"components/comment-checker/dist/cli.js",
"components/lsp/dist/cli.js",
"components/rules/dist/cli.js",
"components/start-work-continuation/dist/cli.js",
"components/telemetry/dist/cli.js",
"components/ulw-loop/dist/cli.js",
"components/ultrawork/dist/cli.js",
];
// then
for (const marker of componentMarkers) {
assert.match(text, new RegExp(marker.replaceAll("/", "\\/")));
}
assert.doesNotMatch(text, /codex-(comment-checker|lsp|rules|telemetry|ulw-loop|ultrawork)@/);
});
test("#given aggregate OMO plugin is enabled #when hooks are inspected #then ulw-loop guards budgeted create_goal calls", async () => {
// given
const hooks = await readJson("hooks/hooks.json");
const text = JSON.stringify(hooks);
// when
const preToolUseGroups = hooks.hooks.PreToolUse;
// then
assert.match(text, /components\/ulw-loop\/dist\/cli\.js/);
assert.match(text, /hook pre-tool-use/);
assert.deepEqual(preToolUseGroups.map((group) => group.matcher), ["^create_goal$"]);
});
test("#given aggregate MCP config #when inspected #then LSP is lazy while non-lazy code MCPs reuse root packages", async () => {
// given
const packageJson = await readJson("package.json");
const mcp = await readJson(".mcp.json");
// when
const lspServer = mcp.mcpServers.lsp;
const astGrepServer = mcp.mcpServers.ast_grep;
const codeMcpNames = Object.keys(mcp.mcpServers)
.filter((name) => name === "lsp" || name === "ast_grep")
.sort();
// then
assert.deepEqual(codeMcpNames, ["ast_grep", "lsp"]);
assert.equal(packageJson.workspaces.includes("components/lsp/packages/lsp-tools-mcp"), false);
assert.equal(packageJson.workspaces.includes("components/ast-grep/packages/ast-grep-mcp"), false);
assert.match(packageJson.scripts.build, /ast-grep-mcp/);
assert.equal(lspServer.command, "node");
assert.deepEqual(lspServer.args, ["./components/lsp/dist/cli.js", "mcp"]);
assert.equal(lspServer.cwd, ".");
assert.equal(astGrepServer.command, "node");
assert.deepEqual(astGrepServer.args, ["../../ast-grep-mcp/dist/cli.js", "mcp"]);
assert.equal(astGrepServer.cwd, ".");
});
test("#given aggregate plugin build script #when inspected #then telemetry sync runs before workspace builds", async () => {
// given
const packageJson = await readJson("package.json");
const telemetrySyncScript = await readFile(join(root, "..", "scripts", "sync-telemetry-component.mjs"), "utf8");
// when
const buildScript = packageJson.scripts.build;
// then
assert.equal(
buildScript,
"bun run --cwd ../../ast-grep-mcp build && node scripts/sync-skills.mjs && node ../scripts/sync-telemetry-component.mjs && npm run build --workspaces --if-present",
);
assert.match(telemetrySyncScript, /syncTelemetryComponent/);
});
test("#given component directories #when scanned #then only intentional resource roots declare plugin manifests", async () => {
// given
const components = await readdir(join(root, "components"), { withFileTypes: true });
const expectedComponentManifests = new Map([["rules", { hooks: "./hooks/hooks.json" }]]);
// when
const componentNames = components.filter((entry) => entry.isDirectory()).map((entry) => entry.name).sort();
// then
assert.deepEqual(componentNames, [
"comment-checker",
"lsp",
"rules",
"start-work-continuation",
"telemetry",
"ultrawork",
"ulw-loop",
]);
for (const name of componentNames) {
const expectedManifest = expectedComponentManifests.get(name);
if (expectedManifest !== undefined) {
assert.deepEqual(await readJson(join("components", name, ".codex-plugin", "plugin.json")), expectedManifest);
continue;
}
await assert.rejects(
readFile(join(root, "components", name, ".codex-plugin", "plugin.json"), "utf8"),
/code: 'ENOENT'|ENOENT/,
);
}
});
test("#given bundled Codex agents #when components/ultrawork/agents directory is scanned #then planner support TOMLs are present and match expected schema keys", async () => {
const agentsDir = join(root, "components", "ultrawork", "agents");
const entries = (await readdir(agentsDir, { withFileTypes: true }))
.filter((entry) => entry.isFile() && entry.name.endsWith(".toml"))
.map((entry) => entry.name)
.sort();
assert.deepEqual(entries, [
"codex-ultrawork-reviewer.toml",
"explorer.toml",
"librarian.toml",
"metis.toml",
"momus.toml",
"plan.toml",
]);
for (const fileName of entries) {
const content = await readFile(join(agentsDir, fileName), "utf8");
assert.match(content, /^name\s*=\s*".+"$/m);
assert.match(content, /^description\s*=\s*".+"$/m);
assert.match(content, /^nickname_candidates\s*=\s*\[.+\]$/m);
assert.match(content, /^model\s*=\s*".+"$/m);
assert.match(content, /^model_reasoning_effort\s*=\s*".+"$/m);
assert.match(content, /^developer_instructions\s*=\s*"""/m);
}
});
test("#given synced skills with Codex compatibility guidance #when a bundled agent_type is referenced #then a matching TOML is bundled", async () => {
const skillsDir = join(root, "skills");
const skillEntries = await readdir(skillsDir, { withFileTypes: true });
const skillFiles = skillEntries
.filter((entry) => entry.isDirectory())
.map((entry) => join(skillsDir, entry.name, "SKILL.md"));
const referencedAgentTypes = new Set();
for (const skillPath of skillFiles) {
const content = await readFile(skillPath, "utf8");
for (const agentType of findSpawnAgentTypes(content)) {
if (agentType === "worker" || agentType === "codex-ultrawork-reviewer") {
continue;
}
referencedAgentTypes.add(agentType);
}
}
const expected = [...referencedAgentTypes].sort();
assert.deepEqual(expected, ["explorer", "librarian", "metis", "momus", "plan"]);
for (const agentType of expected) {
const tomlPath = join(root, "components", "ultrawork", "agents", `${agentType}.toml`);
const fileStat = await stat(tomlPath);
assert.equal(fileStat.isFile(), true);
assert.equal(basename(tomlPath), `${agentType}.toml`);
}
});