YeonGyu-Kim
7cce0ad230
notepad-write-guard: - The hook was created by create-tool-guard-hooks but tool-execute-before never invoked it, so the guard was inert. - It also only matched .sisyphus/notepads, missing the current .omo/notepads layout introduced by the workspace migration. - Add the dispatch call alongside writeExistingFileGuard, and extend NOTEPAD_ROOTS to cover both paths via normalize() + sep. New integration test pins the wire and the .omo block; the existing unit test now asserts both paths. start-work session-plan-affinity: - PLAN_PATH_PATTERN only matched .sisyphus/plans, so sessions referring to plans under .omo/plans returned null and start-work missed the current session's own plan. - Extend the regex to .(sisyphus|omo)/plans and add findPrometheusPlans in packages/boulder-state to scan both directories during the transition. New regression test pins .omo/plans matching; legacy .sisyphus/plans coverage preserved.
92 lines
3.0 KiB
TypeScript
92 lines
3.0 KiB
TypeScript
import { describe, expect, test } from "bun:test"
|
|
import { createNotepadWriteGuardHook } from "./index"
|
|
|
|
const REFUSED_PREFIX = "Refused: Write to"
|
|
|
|
type Hook = ReturnType<typeof createNotepadWriteGuardHook>
|
|
|
|
async function invoke(
|
|
hook: Hook,
|
|
args: { tool: string; filePath: string },
|
|
): Promise<void> {
|
|
await hook["tool.execute.before"]?.(
|
|
{ tool: args.tool } as never,
|
|
{ args: { filePath: args.filePath } } as never,
|
|
)
|
|
}
|
|
|
|
async function expectWriteBlocked(hook: Hook, filePath: string): Promise<void> {
|
|
let caughtMessage = ""
|
|
try {
|
|
await invoke(hook, { tool: "write", filePath })
|
|
} catch (err) {
|
|
if (err instanceof Error) {
|
|
caughtMessage = err.message
|
|
} else {
|
|
throw err
|
|
}
|
|
}
|
|
|
|
expect(caughtMessage).toContain(REFUSED_PREFIX)
|
|
}
|
|
|
|
describe("createNotepadWriteGuardHook", () => {
|
|
test("#given notepad decisions.md #when write executes #then rejects with actionable error", async () => {
|
|
const hook = createNotepadWriteGuardHook()
|
|
await expectWriteBlocked(hook, ".sisyphus/notepads/foo/decisions.md")
|
|
})
|
|
|
|
test("#given notepad state.json #when write executes #then rejects (entire notepad subtree blocked)", async () => {
|
|
const hook = createNotepadWriteGuardHook()
|
|
await expectWriteBlocked(hook, ".sisyphus/notepads/foo/state.json")
|
|
})
|
|
|
|
test("#given current omo notepad file #when write executes #then rejects", async () => {
|
|
const hook = createNotepadWriteGuardHook()
|
|
await expectWriteBlocked(hook, ".omo/notepads/foo/decisions.md")
|
|
})
|
|
|
|
test("#given regular src file #when write executes #then allows (not intercepted)", async () => {
|
|
const hook = createNotepadWriteGuardHook()
|
|
await invoke(hook, {
|
|
tool: "write",
|
|
filePath: "src/index.ts",
|
|
})
|
|
})
|
|
|
|
test("#given non-write tool on notepad path #when executes #then allows", async () => {
|
|
const hook = createNotepadWriteGuardHook()
|
|
await invoke(hook, {
|
|
tool: "read",
|
|
filePath: ".sisyphus/notepads/foo/decisions.md",
|
|
})
|
|
})
|
|
|
|
test("#given sisyphus plans file (not notepads) #when write executes #then allows", async () => {
|
|
const hook = createNotepadWriteGuardHook()
|
|
await invoke(hook, {
|
|
tool: "write",
|
|
filePath: ".sisyphus/plans/my-plan.md",
|
|
})
|
|
})
|
|
|
|
test("#given absolute notepad path #when write executes #then rejects", async () => {
|
|
const hook = createNotepadWriteGuardHook()
|
|
await expectWriteBlocked(hook, "/home/user/project/.sisyphus/notepads/plan/decisions.md")
|
|
})
|
|
|
|
test("#given error message #when rejected #then message names the file and gives guidance", async () => {
|
|
const hook = createNotepadWriteGuardHook()
|
|
const filePath = ".sisyphus/notepads/foo/decisions.md"
|
|
let caughtMessage = ""
|
|
try {
|
|
await invoke(hook, { tool: "write", filePath })
|
|
} catch (err) {
|
|
caughtMessage = String(err)
|
|
}
|
|
expect(caughtMessage).toContain(filePath)
|
|
expect(caughtMessage).toContain("append-only")
|
|
expect(caughtMessage).toContain("Report the original Edit failure")
|
|
})
|
|
})
|