f146aeff0f
* style(tests): normalize BDD comments from '// #given' to '// given'
- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given
* fix(rules-injector): prefer output.metadata.filePath over output.title
- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label
* feat(slashcommand): add optional user_message parameter
- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage
* feat(hooks): restore compaction-context-injector hook
- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry
* refactor(background-agent): split manager.ts into focused modules
- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports
* refactor(agents): split prometheus-prompt.ts into subdirectory
- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports
* refactor(delegate-task): split tools.ts into focused modules
- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns
* refactor(builtin-skills): split skills.ts into individual skill files
- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules
* chore: update import paths and lockfile
- Update prometheus import path after refactor
- Update bun.lock
* fix(tests): complete BDD comment normalization
- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts
---------
Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
142 lines
5.8 KiB
TypeScript
142 lines
5.8 KiB
TypeScript
import { describe, it, expect, beforeEach, afterEach, spyOn, mock } from "bun:test"
|
|
|
|
describe("model-resolution check", () => {
|
|
describe("getModelResolutionInfo", () => {
|
|
// given: Model requirements are defined in model-requirements.ts
|
|
// when: Getting model resolution info
|
|
// then: Returns info for all agents and categories with their provider chains
|
|
|
|
it("returns agent requirements with provider chains", async () => {
|
|
const { getModelResolutionInfo } = await import("./model-resolution")
|
|
|
|
const info = getModelResolutionInfo()
|
|
|
|
// then: Should have agent entries
|
|
const sisyphus = info.agents.find((a) => a.name === "sisyphus")
|
|
expect(sisyphus).toBeDefined()
|
|
expect(sisyphus!.requirement.fallbackChain[0]?.model).toBe("claude-opus-4-5")
|
|
expect(sisyphus!.requirement.fallbackChain[0]?.providers).toContain("anthropic")
|
|
expect(sisyphus!.requirement.fallbackChain[0]?.providers).toContain("github-copilot")
|
|
})
|
|
|
|
it("returns category requirements with provider chains", async () => {
|
|
const { getModelResolutionInfo } = await import("./model-resolution")
|
|
|
|
const info = getModelResolutionInfo()
|
|
|
|
// then: Should have category entries
|
|
const visual = info.categories.find((c) => c.name === "visual-engineering")
|
|
expect(visual).toBeDefined()
|
|
expect(visual!.requirement.fallbackChain[0]?.model).toBe("gemini-3-pro")
|
|
expect(visual!.requirement.fallbackChain[0]?.providers).toContain("google")
|
|
})
|
|
})
|
|
|
|
describe("getModelResolutionInfoWithOverrides", () => {
|
|
// given: User has overrides in oh-my-opencode.json
|
|
// when: Getting resolution info with config
|
|
// then: Shows user override in Step 1 position
|
|
|
|
it("shows user override for agent when configured", async () => {
|
|
const { getModelResolutionInfoWithOverrides } = await import("./model-resolution")
|
|
|
|
// given: User has override for oracle agent
|
|
const mockConfig = {
|
|
agents: {
|
|
oracle: { model: "anthropic/claude-opus-4-5" },
|
|
},
|
|
}
|
|
|
|
const info = getModelResolutionInfoWithOverrides(mockConfig)
|
|
|
|
// then: Oracle should show the override
|
|
const oracle = info.agents.find((a) => a.name === "oracle")
|
|
expect(oracle).toBeDefined()
|
|
expect(oracle!.userOverride).toBe("anthropic/claude-opus-4-5")
|
|
expect(oracle!.effectiveResolution).toBe("User override: anthropic/claude-opus-4-5")
|
|
})
|
|
|
|
it("shows user override for category when configured", async () => {
|
|
const { getModelResolutionInfoWithOverrides } = await import("./model-resolution")
|
|
|
|
// given: User has override for visual-engineering category
|
|
const mockConfig = {
|
|
categories: {
|
|
"visual-engineering": { model: "openai/gpt-5.2" },
|
|
},
|
|
}
|
|
|
|
const info = getModelResolutionInfoWithOverrides(mockConfig)
|
|
|
|
// then: visual-engineering should show the override
|
|
const visual = info.categories.find((c) => c.name === "visual-engineering")
|
|
expect(visual).toBeDefined()
|
|
expect(visual!.userOverride).toBe("openai/gpt-5.2")
|
|
expect(visual!.effectiveResolution).toBe("User override: openai/gpt-5.2")
|
|
})
|
|
|
|
it("shows provider fallback when no override exists", async () => {
|
|
const { getModelResolutionInfoWithOverrides } = await import("./model-resolution")
|
|
|
|
// given: No overrides configured
|
|
const mockConfig = {}
|
|
|
|
const info = getModelResolutionInfoWithOverrides(mockConfig)
|
|
|
|
// then: Should show provider fallback chain
|
|
const sisyphus = info.agents.find((a) => a.name === "sisyphus")
|
|
expect(sisyphus).toBeDefined()
|
|
expect(sisyphus!.userOverride).toBeUndefined()
|
|
expect(sisyphus!.effectiveResolution).toContain("Provider fallback:")
|
|
expect(sisyphus!.effectiveResolution).toContain("anthropic")
|
|
})
|
|
})
|
|
|
|
describe("checkModelResolution", () => {
|
|
// given: Doctor check is executed
|
|
// when: Running the model resolution check
|
|
// then: Returns pass with details showing resolution flow
|
|
|
|
it("returns pass or warn status with agent and category counts", async () => {
|
|
const { checkModelResolution } = await import("./model-resolution")
|
|
|
|
const result = await checkModelResolution()
|
|
|
|
// then: Should pass (with cache) or warn (no cache) and show counts
|
|
// In CI without model cache, status is "warn"; locally with cache, status is "pass"
|
|
expect(["pass", "warn"]).toContain(result.status)
|
|
expect(result.message).toMatch(/\d+ agents?, \d+ categories?/)
|
|
})
|
|
|
|
it("includes resolution details in verbose mode details array", async () => {
|
|
const { checkModelResolution } = await import("./model-resolution")
|
|
|
|
const result = await checkModelResolution()
|
|
|
|
// then: Details should contain agent/category resolution info
|
|
expect(result.details).toBeDefined()
|
|
expect(result.details!.length).toBeGreaterThan(0)
|
|
// Should have Available Models and Configured Models headers
|
|
expect(result.details!.some((d) => d.includes("Available Models"))).toBe(true)
|
|
expect(result.details!.some((d) => d.includes("Configured Models"))).toBe(true)
|
|
expect(result.details!.some((d) => d.includes("Agents:"))).toBe(true)
|
|
expect(result.details!.some((d) => d.includes("Categories:"))).toBe(true)
|
|
// Should have legend
|
|
expect(result.details!.some((d) => d.includes("user override"))).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe("getModelResolutionCheckDefinition", () => {
|
|
it("returns valid check definition", async () => {
|
|
const { getModelResolutionCheckDefinition } = await import("./model-resolution")
|
|
|
|
const def = getModelResolutionCheckDefinition()
|
|
|
|
expect(def.id).toBe("model-resolution")
|
|
expect(def.name).toBe("Model Resolution")
|
|
expect(def.category).toBe("configuration")
|
|
expect(typeof def.check).toBe("function")
|
|
})
|
|
})
|
|
})
|