YeonGyu-Kim
d21ed3f765
Doctor checks spawned subprocesses (gh, opencode, sg) without timeouts, causing the process to hang indefinitely if any binary was stuck. The OS would then SIGKILL the process (exit code 137). - Add spawnWithTimeout utility with 10s per-spawn timeout and proper cleanup (timer cleared on success, proc.exited awaited after kill) - Capture both stdout and stderr to preserve gh auth status behavior - Add 30s overall doctor command timeout with JSON-mode support - Distinguish timeout errors from other failures in runner - Update all doctor check subprocess calls to use timeouts
74 lines
2.1 KiB
TypeScript
74 lines
2.1 KiB
TypeScript
import { describe, it, expect } from "bun:test"
|
|
import { spawnWithTimeout } from "./spawn-with-timeout"
|
|
|
|
describe("spawnWithTimeout", () => {
|
|
describe("#given a command that completes quickly", () => {
|
|
it("returns stdout and exit code", async () => {
|
|
// when
|
|
const result = await spawnWithTimeout(["echo", "hello"], { stdout: "pipe", stderr: "pipe" })
|
|
|
|
// then
|
|
expect(result.timedOut).toBe(false)
|
|
expect(result.exitCode).toBe(0)
|
|
expect(result.stdout.trim()).toBe("hello")
|
|
expect(result.stderr).toBe("")
|
|
})
|
|
})
|
|
|
|
describe("#given a command that writes to stderr", () => {
|
|
it("captures stderr output", async () => {
|
|
// when
|
|
const result = await spawnWithTimeout(
|
|
["bash", "-c", "echo err >&2"],
|
|
{ stdout: "pipe", stderr: "pipe" }
|
|
)
|
|
|
|
// then
|
|
expect(result.timedOut).toBe(false)
|
|
expect(result.stderr.trim()).toBe("err")
|
|
})
|
|
})
|
|
|
|
describe("#given a command that fails", () => {
|
|
it("returns non-zero exit code without timing out", async () => {
|
|
// when
|
|
const result = await spawnWithTimeout(["false"], { stdout: "pipe", stderr: "pipe" })
|
|
|
|
// then
|
|
expect(result.timedOut).toBe(false)
|
|
expect(result.exitCode).not.toBe(0)
|
|
})
|
|
})
|
|
|
|
describe("#given a command that exceeds timeout", () => {
|
|
it("returns timedOut true and kills the process", async () => {
|
|
// when
|
|
const result = await spawnWithTimeout(
|
|
["bash", "-c", "while true; do :; done"],
|
|
{ stdout: "pipe", stderr: "pipe" },
|
|
200
|
|
)
|
|
|
|
// then
|
|
expect(result.timedOut).toBe(true)
|
|
expect(result.stdout).toBe("")
|
|
expect(result.stderr).toBe("")
|
|
})
|
|
})
|
|
|
|
describe("#given a nonexistent command", () => {
|
|
it("handles gracefully without hanging", async () => {
|
|
// when
|
|
const result = await spawnWithTimeout(
|
|
["nonexistent-binary-that-does-not-exist-12345"],
|
|
{ stdout: "pipe", stderr: "pipe" },
|
|
2000
|
|
)
|
|
|
|
// then
|
|
expect(result.timedOut).toBe(false)
|
|
expect(result.exitCode).toBe(1)
|
|
})
|
|
})
|
|
})
|