Files
oh-my-opencode/src/plugin/hooks/create-tool-guard-hooks.ts
T
Tran Quang a1a2bb4b07 fix(rules-injector): respect claude_code config for user rule loading
When claude_code integration is disabled in oh-my-opencode.json, the
rules-injector now skips loading rules from ~/.claude/rules/ to prevent
Claude Code-specific instructions from leaking into non-Claude agents
(e.g., GPT-5.4 Sisyphus), which causes agent hallucination.

Also adds ~/.sisyphus/rules/ and ~/.opencode/rules/ as OpenCode-native
user rule directories that are always searched regardless of config.

Fixes #2920

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-03-29 10:13:55 +07:00

155 lines
6.1 KiB
TypeScript

import type { HookName, OhMyOpenCodeConfig } from "../../config"
import type { ModelCacheState } from "../../plugin-state"
import type { PluginContext } from "../types"
import {
createCommentCheckerHooks,
createToolOutputTruncatorHook,
createDirectoryAgentsInjectorHook,
createDirectoryReadmeInjectorHook,
createEmptyTaskResponseDetectorHook,
createRulesInjectorHook,
createTasksTodowriteDisablerHook,
createWriteExistingFileGuardHook,
createBashFileReadGuardHook,
createHashlineReadEnhancerHook,
createReadImageResizerHook,
createJsonErrorRecoveryHook,
createTodoDescriptionOverrideHook,
createWebFetchRedirectGuardHook,
} from "../../hooks"
import {
getOpenCodeVersion,
isOpenCodeVersionAtLeast,
log,
OPENCODE_NATIVE_AGENTS_INJECTION_VERSION,
} from "../../shared"
import { safeCreateHook } from "../../shared/safe-create-hook"
export type ToolGuardHooks = {
commentChecker: ReturnType<typeof createCommentCheckerHooks> | null
toolOutputTruncator: ReturnType<typeof createToolOutputTruncatorHook> | null
directoryAgentsInjector: ReturnType<typeof createDirectoryAgentsInjectorHook> | null
directoryReadmeInjector: ReturnType<typeof createDirectoryReadmeInjectorHook> | null
emptyTaskResponseDetector: ReturnType<typeof createEmptyTaskResponseDetectorHook> | null
rulesInjector: ReturnType<typeof createRulesInjectorHook> | null
tasksTodowriteDisabler: ReturnType<typeof createTasksTodowriteDisablerHook> | null
writeExistingFileGuard: ReturnType<typeof createWriteExistingFileGuardHook> | null
bashFileReadGuard: ReturnType<typeof createBashFileReadGuardHook> | null
hashlineReadEnhancer: ReturnType<typeof createHashlineReadEnhancerHook> | null
jsonErrorRecovery: ReturnType<typeof createJsonErrorRecoveryHook> | null
readImageResizer: ReturnType<typeof createReadImageResizerHook> | null
todoDescriptionOverride: ReturnType<typeof createTodoDescriptionOverrideHook> | null
webfetchRedirectGuard: ReturnType<typeof createWebFetchRedirectGuardHook> | null
}
export function createToolGuardHooks(args: {
ctx: PluginContext
pluginConfig: OhMyOpenCodeConfig
modelCacheState: ModelCacheState
isHookEnabled: (hookName: HookName) => boolean
safeHookEnabled: boolean
}): ToolGuardHooks {
const { ctx, pluginConfig, modelCacheState, isHookEnabled, safeHookEnabled } = args
const safeHook = <T>(hookName: HookName, factory: () => T): T | null =>
safeCreateHook(hookName, factory, { enabled: safeHookEnabled })
const commentChecker = isHookEnabled("comment-checker")
? safeHook("comment-checker", () => createCommentCheckerHooks(pluginConfig.comment_checker))
: null
const toolOutputTruncator = isHookEnabled("tool-output-truncator")
? safeHook("tool-output-truncator", () =>
createToolOutputTruncatorHook(ctx, {
modelCacheState,
experimental: pluginConfig.experimental,
}))
: null
let directoryAgentsInjector: ReturnType<typeof createDirectoryAgentsInjectorHook> | null = null
if (isHookEnabled("directory-agents-injector")) {
const currentVersion = getOpenCodeVersion()
const hasNativeSupport =
currentVersion !== null && isOpenCodeVersionAtLeast(OPENCODE_NATIVE_AGENTS_INJECTION_VERSION)
if (hasNativeSupport) {
log("directory-agents-injector auto-disabled due to native OpenCode support", {
currentVersion,
nativeVersion: OPENCODE_NATIVE_AGENTS_INJECTION_VERSION,
})
} else {
directoryAgentsInjector = safeHook("directory-agents-injector", () =>
createDirectoryAgentsInjectorHook(ctx, modelCacheState))
}
}
const directoryReadmeInjector = isHookEnabled("directory-readme-injector")
? safeHook("directory-readme-injector", () =>
createDirectoryReadmeInjectorHook(ctx, modelCacheState))
: null
const emptyTaskResponseDetector = isHookEnabled("empty-task-response-detector")
? safeHook("empty-task-response-detector", () => createEmptyTaskResponseDetectorHook(ctx))
: null
const claudeCodeDisabled = pluginConfig.claude_code
&& !pluginConfig.claude_code.hooks
&& !pluginConfig.claude_code.skills
&& !pluginConfig.claude_code.agents
const rulesInjector = isHookEnabled("rules-injector")
? safeHook("rules-injector", () =>
createRulesInjectorHook(ctx, modelCacheState, {
skipClaudeUserRules: claudeCodeDisabled ?? false,
}))
: null
const tasksTodowriteDisabler = isHookEnabled("tasks-todowrite-disabler")
? safeHook("tasks-todowrite-disabler", () =>
createTasksTodowriteDisablerHook({ experimental: pluginConfig.experimental }))
: null
const writeExistingFileGuard = isHookEnabled("write-existing-file-guard")
? safeHook("write-existing-file-guard", () => createWriteExistingFileGuardHook(ctx))
: null
const bashFileReadGuard = isHookEnabled("bash-file-read-guard")
? safeHook("bash-file-read-guard", () => createBashFileReadGuardHook())
: null
const hashlineReadEnhancer = isHookEnabled("hashline-read-enhancer")
? safeHook("hashline-read-enhancer", () => createHashlineReadEnhancerHook(ctx, { hashline_edit: { enabled: pluginConfig.hashline_edit ?? false } }))
: null
const jsonErrorRecovery = isHookEnabled("json-error-recovery")
? safeHook("json-error-recovery", () => createJsonErrorRecoveryHook(ctx))
: null
const readImageResizer = isHookEnabled("read-image-resizer")
? safeHook("read-image-resizer", () => createReadImageResizerHook(ctx))
: null
const todoDescriptionOverride = isHookEnabled("todo-description-override")
? safeHook("todo-description-override", () => createTodoDescriptionOverrideHook())
: null
const webfetchRedirectGuard = isHookEnabled("webfetch-redirect-guard")
? safeHook("webfetch-redirect-guard", () => createWebFetchRedirectGuardHook(ctx))
: null
return {
commentChecker,
toolOutputTruncator,
directoryAgentsInjector,
directoryReadmeInjector,
emptyTaskResponseDetector,
rulesInjector,
tasksTodowriteDisabler,
writeExistingFileGuard,
bashFileReadGuard,
hashlineReadEnhancer,
jsonErrorRecovery,
readImageResizer,
todoDescriptionOverride,
webfetchRedirectGuard,
}
}