oh-my-opencode/src/features/builtin-skills/skills.test.ts

/// <reference path="../../../bun-test.d.ts" />

import { describe, test, expect } from "bun:test"
import { createBuiltinSkills } from "./skills"

describe("createBuiltinSkills", () => {
	test("returns playwright skill by default", () => {
		// given - no options (default)

		// when
		const skills = createBuiltinSkills()

		// then
		const browserSkill = skills.find((s) => s.name === "playwright")
		expect(browserSkill).toBeDefined()
		expect(browserSkill!.description).toContain("browser")
		expect(browserSkill!.mcpConfig?.playwright).toBeDefined()
	})

	test("returns playwright skill when browserProvider is 'playwright'", () => {
		// given
		const options = { browserProvider: "playwright" as const }

		// when
		const skills = createBuiltinSkills(options)

		// then
		const playwrightSkill = skills.find((s) => s.name === "playwright")
		const agentBrowserSkill = skills.find((s) => s.name === "agent-browser")
		const devBrowserSkill = skills.find((s) => s.name === "dev-browser")
		expect(playwrightSkill).toBeDefined()
		expect(agentBrowserSkill).toBeUndefined()
		expect(devBrowserSkill).toBeUndefined()
	})

	test("returns dev-browser skill when browserProvider is 'dev-browser'", () => {
		// given
		const options = { browserProvider: "dev-browser" as const }

		// when
		const skills = createBuiltinSkills(options)

		// then
		const skillNames = skills.map((skill) => skill.name)
		const devBrowserSkill = skills.find((skill) => skill.name === "dev-browser")
		const playwrightSkill = skills.find((skill) => skill.name === "playwright")
		const agentBrowserSkill = skills.find((skill) => skill.name === "agent-browser")
		expect(devBrowserSkill).toBeDefined()
		expect(devBrowserSkill!.description).toContain("Browser automation")
		expect(playwrightSkill).toBeUndefined()
		expect(agentBrowserSkill).toBeUndefined()
		expect(skillNames).not.toContain("playwright-cli")
		expect(skills.some((skill) => skill.allowedTools?.includes("Bash(playwright-cli:*)"))).toBe(false)
	})

	test("returns agent-browser skill when browserProvider is 'agent-browser'", () => {
		// given
		const options = { browserProvider: "agent-browser" as const }

		// when
		const skills = createBuiltinSkills(options)

		// then
		const agentBrowserSkill = skills.find((s) => s.name === "agent-browser")
		const playwrightSkill = skills.find((s) => s.name === "playwright")
		expect(agentBrowserSkill).toBeDefined()
		expect(agentBrowserSkill!.description).toContain("browser")
		expect(agentBrowserSkill!.allowedTools).toContain("Bash(agent-browser:*)")
		expect(agentBrowserSkill!.template).toContain("agent-browser")
		expect(playwrightSkill).toBeUndefined()
	})

	test("agent-browser skill template is inlined (not loaded from file)", () => {
		// given
		const options = { browserProvider: "agent-browser" as const }

		// when
		const skills = createBuiltinSkills(options)
		const agentBrowserSkill = skills.find((s) => s.name === "agent-browser")

		// then - template should contain substantial content (inlined, not fallback)
		expect(agentBrowserSkill!.template).toContain("## Quick start")
		expect(agentBrowserSkill!.template).toContain("## Commands")
		expect(agentBrowserSkill!.template).toContain("agent-browser open")
		expect(agentBrowserSkill!.template).toContain("agent-browser snapshot")
	})

	test("always includes frontend-ui-ux, git-master, review-work, ai-slop-remover, and security-review skills", () => {
		// given - both provider options

		// when
		const defaultSkills = createBuiltinSkills()
		const agentBrowserSkills = createBuiltinSkills({ browserProvider: "agent-browser" })
		const devBrowserSkills = createBuiltinSkills({ browserProvider: "dev-browser" })

		// then
		for (const skills of [defaultSkills, agentBrowserSkills, devBrowserSkills]) {
			expect(skills.find((s) => s.name === "frontend-ui-ux")).toBeDefined()
			expect(skills.find((s) => s.name === "git-master")).toBeDefined()
			expect(skills.find((s) => s.name === "review-work")).toBeDefined()
			expect(skills.find((s) => s.name === "ai-slop-remover")).toBeDefined()
			expect(skills.find((s) => s.name === "security-review")).toBeDefined()
		}
	})

	test("returns exactly 6 skills regardless of provider", () => {
		// given

		// when
		const defaultSkills = createBuiltinSkills()
		const agentBrowserSkills = createBuiltinSkills({ browserProvider: "agent-browser" })
		const devBrowserSkills = createBuiltinSkills({ browserProvider: "dev-browser" })

		// then
		expect(defaultSkills).toHaveLength(6)
		expect(agentBrowserSkills).toHaveLength(6)
		expect(devBrowserSkills).toHaveLength(6)
	})

	test("should exclude playwright when it is in disabledSkills", () => {
		// #given
		const options = { disabledSkills: new Set(["playwright"]) }

		// #when
		const skills = createBuiltinSkills(options)

		// #then
		expect(skills.map((s) => s.name)).not.toContain("playwright")
		expect(skills.map((s) => s.name)).toContain("frontend-ui-ux")
		expect(skills.map((s) => s.name)).toContain("git-master")
		expect(skills.map((s) => s.name)).not.toContain("dev-browser")
		expect(skills.map((s) => s.name)).toContain("review-work")
		expect(skills.map((s) => s.name)).toContain("ai-slop-remover")
		expect(skills.map((s) => s.name)).toContain("security-review")
		expect(skills.length).toBe(5)
	})

	test("should exclude multiple skills when they are in disabledSkills", () => {
		// #given
		const options = { disabledSkills: new Set(["playwright", "git-master"]) }

		// #when
		const skills = createBuiltinSkills(options)

		// #then
		expect(skills.map((s) => s.name)).not.toContain("playwright")
		expect(skills.map((s) => s.name)).not.toContain("git-master")
		expect(skills.map((s) => s.name)).toContain("frontend-ui-ux")
		expect(skills.map((s) => s.name)).not.toContain("dev-browser")
		expect(skills.map((s) => s.name)).toContain("review-work")
		expect(skills.map((s) => s.name)).toContain("ai-slop-remover")
		expect(skills.map((s) => s.name)).toContain("security-review")
		expect(skills.length).toBe(4)
	})

	test("should return an empty array when all skills are disabled", () => {
		// #given
		const options = { disabledSkills: new Set(["playwright", "frontend-ui-ux", "git-master", "review-work", "ai-slop-remover", "security-review"]) }

		// #when
		const skills = createBuiltinSkills(options)

		// #then
		expect(skills.length).toBe(0)
	})

	test("should return all skills when disabledSkills set is empty", () => {
		// #given
		const options = { disabledSkills: new Set<string>() }

		// #when
		const skills = createBuiltinSkills(options)

		// #then
		expect(skills.length).toBe(6)
	})

	test("review-work skill has correct structure", () => {
		// #given - default options

		// #when
		const skills = createBuiltinSkills()
		const reviewWork = skills.find((s) => s.name === "review-work")

		// #then
		expect(reviewWork).toBeDefined()
		expect(reviewWork!.description).toContain("review")
		expect(reviewWork!.template).toContain("5-Agent Parallel Review Orchestrator")
		expect(reviewWork!.template).toContain("Goal & Constraint Verification")
		expect(reviewWork!.template).toContain("QA")
		expect(reviewWork!.template).toContain("Code Quality")
		expect(reviewWork!.template).toContain("Security")
		expect(reviewWork!.template).toContain("Context Mining")
	})

	test("review-work skill explains Codex tool compatibility before OpenCode orchestration examples", () => {
		// #given
		const skills = createBuiltinSkills()

		// #when
		const reviewWork = skills.find((s) => s.name === "review-work")
		const compatibilityIndex = reviewWork!.template.indexOf("## Codex Harness Tool Compatibility")
		const opencodeExampleIndex = reviewWork!.template.search(/\b(?:background_output|team_[a-z_]+|task)\s*\(/)

		// #then
		expect(compatibilityIndex >= 0).toBe(true)
		expect(compatibilityIndex < opencodeExampleIndex).toBe(true)
	})

	test("ai-slop-remover skill has correct structure", () => {
		// #given - default options

		// #when
		const skills = createBuiltinSkills()
		const aiSlopRemover = skills.find((s) => s.name === "ai-slop-remover")

		// #then
		expect(aiSlopRemover).toBeDefined()
		expect(aiSlopRemover!.description).toContain("AI-generated code smells")
		expect(aiSlopRemover!.template).toContain("DETECTION CRITERIA")
		expect(aiSlopRemover!.template).toContain("SAFETY RULES")
	})

	test("security-review skill has correct structure", () => {
		// #given - default options

		// #when
		const skills = createBuiltinSkills()
		const securityReview = skills.find((skill) => skill.name === "security-review")

		// #then
		expect(securityReview?.description).toContain("security review")
		expect(securityReview?.template).toContain("Team Mode Vulnerability Audit")
		expect(securityReview?.template).toContain("team_create")
		expect(securityReview?.template).toContain("Security Review Result")
	})

	test("returns playwright-cli skill when browserProvider is 'playwright-cli'", () => {
		// given
		const options = { browserProvider: "playwright-cli" as const }

		// when
		const skills = createBuiltinSkills(options)

		// then
		const playwrightSkill = skills.find((s) => s.name === "playwright")
		const agentBrowserSkill = skills.find((s) => s.name === "agent-browser")
		expect(playwrightSkill).toBeDefined()
		expect(playwrightSkill!.description).toContain("browser")
		expect(playwrightSkill!.allowedTools).toContain("Bash(playwright-cli:*)")
		expect(playwrightSkill!.mcpConfig).toBeUndefined()
		expect(agentBrowserSkill).toBeUndefined()
	})

	test("playwright-cli skill template contains CLI commands", () => {
		// given
		const options = { browserProvider: "playwright-cli" as const }

		// when
		const skills = createBuiltinSkills(options)
		const skill = skills.find((s) => s.name === "playwright")

		// then
		expect(skill!.template).toContain("playwright-cli open")
		expect(skill!.template).toContain("playwright-cli snapshot")
		expect(skill!.template).toContain("playwright-cli click")
	})
})