YeonGyu-Kim
a691a3ac0a
- Rename delegate_task tool to task across codebase (100 files) - Update model references: claude-opus-4-6 → 4-5, gpt-5.3-codex → 5.2-codex - Add tool-metadata-store to restore metadata overwritten by fromPlugin() - Add session ID polling for BackgroundManager task sessions - Await async ctx.metadata() calls in tool executors - Add ses_ prefix guard to getMessageDir for performance - Harden BackgroundManager with idle deferral and error handling - Fix duplicate task key in sisyphus-junior test object literals - Fix unawaited showOutputToUser in ast_grep_replace - Fix background=true → run_in_background=true in ultrawork prompt - Fix duplicate task/task references in docs and comments
120 lines
4.3 KiB
TypeScript
120 lines
4.3 KiB
TypeScript
import { describe, expect, it } from "bun:test"
|
|
import {
|
|
DELEGATE_TASK_ERROR_PATTERNS,
|
|
detectDelegateTaskError,
|
|
buildRetryGuidance,
|
|
} from "./index"
|
|
|
|
describe("sisyphus-task-retry", () => {
|
|
describe("DELEGATE_TASK_ERROR_PATTERNS", () => {
|
|
// given error patterns are defined
|
|
// then should include all known task error types
|
|
it("should contain all known error patterns", () => {
|
|
expect(DELEGATE_TASK_ERROR_PATTERNS.length).toBeGreaterThan(5)
|
|
|
|
const patternTexts = DELEGATE_TASK_ERROR_PATTERNS.map(p => p.pattern)
|
|
expect(patternTexts).toContain("run_in_background")
|
|
expect(patternTexts).toContain("load_skills")
|
|
expect(patternTexts).toContain("category OR subagent_type")
|
|
expect(patternTexts).toContain("Unknown category")
|
|
expect(patternTexts).toContain("Unknown agent")
|
|
})
|
|
})
|
|
|
|
describe("detectDelegateTaskError", () => {
|
|
// given tool output with run_in_background error
|
|
// when detecting error
|
|
// then should return matching error info
|
|
it("should detect run_in_background missing error", () => {
|
|
const output = "[ERROR] Invalid arguments: 'run_in_background' parameter is REQUIRED. Use run_in_background=false for task delegation."
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("missing_run_in_background")
|
|
})
|
|
|
|
it("should detect load_skills missing error", () => {
|
|
const output = "[ERROR] Invalid arguments: 'load_skills' parameter is REQUIRED. Use load_skills=[] if no skills are needed."
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("missing_load_skills")
|
|
})
|
|
|
|
it("should detect category/subagent mutual exclusion error", () => {
|
|
const output = "[ERROR] Invalid arguments: Provide EITHER category OR subagent_type, not both."
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("mutual_exclusion")
|
|
})
|
|
|
|
it("should detect unknown category error", () => {
|
|
const output = '[ERROR] Unknown category: "invalid-cat". Available: visual-engineering, ultrabrain, quick'
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("unknown_category")
|
|
})
|
|
|
|
it("should detect unknown agent error", () => {
|
|
const output = '[ERROR] Unknown agent: "fake-agent". Available agents: explore, librarian, oracle'
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("unknown_agent")
|
|
})
|
|
|
|
it("should return null for successful output", () => {
|
|
const output = "Background task launched.\n\nTask ID: bg_12345\nSession ID: ses_abc"
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe("buildRetryGuidance", () => {
|
|
// given detected error
|
|
// when building retry guidance
|
|
// then should return actionable fix instructions
|
|
it("should provide fix for missing run_in_background", () => {
|
|
const errorInfo = { errorType: "missing_run_in_background", originalOutput: "" }
|
|
|
|
const guidance = buildRetryGuidance(errorInfo)
|
|
|
|
expect(guidance).toContain("run_in_background")
|
|
expect(guidance).toContain("REQUIRED")
|
|
})
|
|
|
|
it("should provide fix for unknown category with available list", () => {
|
|
const errorInfo = {
|
|
errorType: "unknown_category",
|
|
originalOutput: '[ERROR] Unknown category: "bad". Available: visual-engineering, ultrabrain'
|
|
}
|
|
|
|
const guidance = buildRetryGuidance(errorInfo)
|
|
|
|
expect(guidance).toContain("visual-engineering")
|
|
expect(guidance).toContain("ultrabrain")
|
|
})
|
|
|
|
it("should provide fix for unknown agent with available list", () => {
|
|
const errorInfo = {
|
|
errorType: "unknown_agent",
|
|
originalOutput: '[ERROR] Unknown agent: "fake". Available agents: explore, oracle'
|
|
}
|
|
|
|
const guidance = buildRetryGuidance(errorInfo)
|
|
|
|
expect(guidance).toContain("explore")
|
|
expect(guidance).toContain("oracle")
|
|
})
|
|
})
|
|
})
|