dcda8769cc
* feat(mcp-oauth): add oauth field to ClaudeCodeMcpServer schema Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> * feat(mcp-oauth): add RFC 7591 Dynamic Client Registration * feat(mcp-oauth): add RFC 9728 PRM + RFC 8414 AS discovery * feat(mcp-oauth): add secure token storage with {host}/{resource} key format * feat(mcp-oauth): add dynamic port OAuth callback server * feat(mcp-oauth): add RFC 8707 Resource Indicators * feat(mcp-oauth): implement full-spec McpOAuthProvider * feat(mcp-oauth): add step-up authorization handler * feat(mcp-oauth): integrate authProvider into SkillMcpManager * feat(doctor): add MCP OAuth token status check * feat(cli): add mcp oauth subcommand structure * feat(cli): implement mcp oauth login command * fix(mcp-oauth): address cubic review — security, correctness, and test issues - Remove @ts-nocheck from provider.ts, storage.ts, provider.test.ts - Fix server resource leak on missing code/state (close + reject) - Fix command injection in openBrowser (spawn array args, cross-platform) - Mock McpOAuthProvider in login.test.ts for deterministic CI - Recreate auth provider with merged scopes in step-up flow - Add listAllTokens() for global status listing - Fix logout to accept --server-url for correct token deletion - Support both quoted and unquoted WWW-Authenticate params (RFC 2617) - Save/restore OPENCODE_CONFIG_DIR in storage.test.ts - Fix index.test.ts: vitest → bun:test * fix(mcp-oauth): use explorer instead of cmd /c start on Windows to prevent shell injection * fix(mcp-oauth): address remaining cubic review issues - Add 5-minute timeout to provider callback server to prevent indefinite hangs - Persist client registration from token storage across process restarts - Require --server-url for logout to match token storage key format - Use listTokensByHost for server-specific status lookups - Fix callback-server test to handle promise rejection ordering - Fix provider test port expectations (8912 → 19877) - Fix cli-guide.md duplicate Section 7 numbering - Fix manager test for login-on-missing-tokens behavior * fix(mcp-oauth): address final review issues - P1: Redact token values in status.ts output to prevent credential leakage - P2: Read OAuth error response body before throwing in token exchange - Test: Fix mcp-oauth doctor test to use epoch seconds (not milliseconds) --------- Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com> Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
122 lines
3.0 KiB
TypeScript
122 lines
3.0 KiB
TypeScript
import { describe, expect, it } from "bun:test"
|
|
import { addResourceToParams, getResourceIndicator } from "./resource-indicator"
|
|
|
|
describe("getResourceIndicator", () => {
|
|
it("returns URL unchanged when already normalized", () => {
|
|
// #given
|
|
const url = "https://mcp.example.com"
|
|
|
|
// #when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// #then
|
|
expect(result).toBe("https://mcp.example.com")
|
|
})
|
|
|
|
it("strips trailing slash", () => {
|
|
// #given
|
|
const url = "https://mcp.example.com/"
|
|
|
|
// #when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// #then
|
|
expect(result).toBe("https://mcp.example.com")
|
|
})
|
|
|
|
it("strips query parameters", () => {
|
|
// #given
|
|
const url = "https://mcp.example.com/v1?token=abc&debug=true"
|
|
|
|
// #when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// #then
|
|
expect(result).toBe("https://mcp.example.com/v1")
|
|
})
|
|
|
|
it("strips fragment", () => {
|
|
// #given
|
|
const url = "https://mcp.example.com/v1#section"
|
|
|
|
// #when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// #then
|
|
expect(result).toBe("https://mcp.example.com/v1")
|
|
})
|
|
|
|
it("strips query and trailing slash together", () => {
|
|
// #given
|
|
const url = "https://mcp.example.com/api/?key=val"
|
|
|
|
// #when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// #then
|
|
expect(result).toBe("https://mcp.example.com/api")
|
|
})
|
|
|
|
it("preserves path segments", () => {
|
|
// #given
|
|
const url = "https://mcp.example.com/org/project/v2"
|
|
|
|
// #when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// #then
|
|
expect(result).toBe("https://mcp.example.com/org/project/v2")
|
|
})
|
|
|
|
it("preserves port number", () => {
|
|
// #given
|
|
const url = "https://mcp.example.com:8443/api/"
|
|
|
|
// #when
|
|
const result = getResourceIndicator(url)
|
|
|
|
// #then
|
|
expect(result).toBe("https://mcp.example.com:8443/api")
|
|
})
|
|
})
|
|
|
|
describe("addResourceToParams", () => {
|
|
it("sets resource parameter on empty params", () => {
|
|
// #given
|
|
const params = new URLSearchParams()
|
|
const resource = "https://mcp.example.com"
|
|
|
|
// #when
|
|
addResourceToParams(params, resource)
|
|
|
|
// #then
|
|
expect(params.get("resource")).toBe("https://mcp.example.com")
|
|
})
|
|
|
|
it("adds resource alongside existing parameters", () => {
|
|
// #given
|
|
const params = new URLSearchParams({ grant_type: "authorization_code" })
|
|
const resource = "https://mcp.example.com/v1"
|
|
|
|
// #when
|
|
addResourceToParams(params, resource)
|
|
|
|
// #then
|
|
expect(params.get("grant_type")).toBe("authorization_code")
|
|
expect(params.get("resource")).toBe("https://mcp.example.com/v1")
|
|
})
|
|
|
|
it("overwrites existing resource parameter", () => {
|
|
// #given
|
|
const params = new URLSearchParams({ resource: "https://old.example.com" })
|
|
const resource = "https://new.example.com"
|
|
|
|
// #when
|
|
addResourceToParams(params, resource)
|
|
|
|
// #then
|
|
expect(params.get("resource")).toBe("https://new.example.com")
|
|
expect(params.getAll("resource")).toHaveLength(1)
|
|
})
|
|
})
|