YeonGyu-Kim
f146aeff0f
* style(tests): normalize BDD comments from '// #given' to '// given'
- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given
* fix(rules-injector): prefer output.metadata.filePath over output.title
- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label
* feat(slashcommand): add optional user_message parameter
- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage
* feat(hooks): restore compaction-context-injector hook
- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry
* refactor(background-agent): split manager.ts into focused modules
- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports
* refactor(agents): split prometheus-prompt.ts into subdirectory
- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports
* refactor(delegate-task): split tools.ts into focused modules
- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns
* refactor(builtin-skills): split skills.ts into individual skill files
- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules
* chore: update import paths and lockfile
- Update prometheus import path after refactor
- Update bun.lock
* fix(tests): complete BDD comment normalization
- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts
---------
Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
78 lines
2.8 KiB
TypeScript
78 lines
2.8 KiB
TypeScript
import { describe, test, expect, mock, beforeEach } from "bun:test"
|
|
import { truncateUntilTargetTokens } from "./storage"
|
|
import * as storage from "./storage"
|
|
|
|
// Mock the entire module
|
|
mock.module("./storage", () => {
|
|
return {
|
|
...storage,
|
|
findToolResultsBySize: mock(() => []),
|
|
truncateToolResult: mock(() => ({ success: false })),
|
|
}
|
|
})
|
|
|
|
describe("truncateUntilTargetTokens", () => {
|
|
const sessionID = "test-session"
|
|
|
|
beforeEach(() => {
|
|
// Reset mocks
|
|
const { findToolResultsBySize, truncateToolResult } = require("./storage")
|
|
findToolResultsBySize.mockReset()
|
|
truncateToolResult.mockReset()
|
|
})
|
|
|
|
test("truncates only until target is reached", () => {
|
|
const { findToolResultsBySize, truncateToolResult } = require("./storage")
|
|
|
|
// given: Two tool results, each 1000 chars. Target reduction is 500 chars.
|
|
const results = [
|
|
{ partPath: "path1", partId: "id1", messageID: "m1", toolName: "tool1", outputSize: 1000 },
|
|
{ partPath: "path2", partId: "id2", messageID: "m2", toolName: "tool2", outputSize: 1000 },
|
|
]
|
|
|
|
findToolResultsBySize.mockReturnValue(results)
|
|
truncateToolResult.mockImplementation((path: string) => ({
|
|
success: true,
|
|
toolName: path === "path1" ? "tool1" : "tool2",
|
|
originalSize: 1000
|
|
}))
|
|
|
|
// when: currentTokens=1000, maxTokens=1000, targetRatio=0.5 (target=500, reduce=500)
|
|
// charsPerToken=1 for simplicity in test
|
|
const result = truncateUntilTargetTokens(sessionID, 1000, 1000, 0.5, 1)
|
|
|
|
// then: Should only truncate the first tool
|
|
expect(result.truncatedCount).toBe(1)
|
|
expect(truncateToolResult).toHaveBeenCalledTimes(1)
|
|
expect(truncateToolResult).toHaveBeenCalledWith("path1")
|
|
expect(result.totalBytesRemoved).toBe(1000)
|
|
expect(result.sufficient).toBe(true)
|
|
})
|
|
|
|
test("truncates all if target not reached", () => {
|
|
const { findToolResultsBySize, truncateToolResult } = require("./storage")
|
|
|
|
// given: Two tool results, each 100 chars. Target reduction is 500 chars.
|
|
const results = [
|
|
{ partPath: "path1", partId: "id1", messageID: "m1", toolName: "tool1", outputSize: 100 },
|
|
{ partPath: "path2", partId: "id2", messageID: "m2", toolName: "tool2", outputSize: 100 },
|
|
]
|
|
|
|
findToolResultsBySize.mockReturnValue(results)
|
|
truncateToolResult.mockImplementation((path: string) => ({
|
|
success: true,
|
|
toolName: path === "path1" ? "tool1" : "tool2",
|
|
originalSize: 100
|
|
}))
|
|
|
|
// when: reduce 500 chars
|
|
const result = truncateUntilTargetTokens(sessionID, 1000, 1000, 0.5, 1)
|
|
|
|
// then: Should truncate both
|
|
expect(result.truncatedCount).toBe(2)
|
|
expect(truncateToolResult).toHaveBeenCalledTimes(2)
|
|
expect(result.totalBytesRemoved).toBe(200)
|
|
expect(result.sufficient).toBe(false)
|
|
})
|
|
})
|