f146aeff0f
* style(tests): normalize BDD comments from '// #given' to '// given'
- Replace 4,668 Python-style BDD comments across 107 test files
- Patterns changed: // #given -> // given, // #when -> // when, // #then -> // then
- Also handles no-space variants: //#given -> // given
* fix(rules-injector): prefer output.metadata.filePath over output.title
- Extract file path resolution to dedicated output-path.ts module
- Prefer metadata.filePath which contains actual file path
- Fall back to output.title only when metadata unavailable
- Fixes issue where rules weren't injected when tool output title was a label
* feat(slashcommand): add optional user_message parameter
- Add user_message optional parameter for command arguments
- Model can now call: command='publish' user_message='patch'
- Improves error messages with clearer format guidance
- Helps LLMs understand correct parameter usage
* feat(hooks): restore compaction-context-injector hook
- Restore hook deleted in cbbc7bd0 for session compaction context
- Injects 7 mandatory sections: User Requests, Final Goal, Work Completed,
Remaining Tasks, Active Working Context, MUST NOT Do, Agent Verification State
- Re-register in hooks/index.ts and main plugin entry
* refactor(background-agent): split manager.ts into focused modules
- Extract constants.ts for TTL values and internal types (52 lines)
- Extract state.ts for TaskStateManager class (204 lines)
- Extract spawner.ts for task creation logic (244 lines)
- Extract result-handler.ts for completion handling (265 lines)
- Reduce manager.ts from 1377 to 755 lines (45% reduction)
- Maintain backward compatible exports
* refactor(agents): split prometheus-prompt.ts into subdirectory
- Move 1196-line prometheus-prompt.ts to prometheus/ subdirectory
- Organize prompt sections into separate files for maintainability
- Update agents/index.ts exports
* refactor(delegate-task): split tools.ts into focused modules
- Extract categories.ts for category definitions and routing
- Extract executor.ts for task execution logic
- Extract helpers.ts for utility functions
- Extract prompt-builder.ts for prompt construction
- Reduce tools.ts complexity with cleaner separation of concerns
* refactor(builtin-skills): split skills.ts into individual skill files
- Move each skill to dedicated file in skills/ subdirectory
- Create barrel export for backward compatibility
- Improve maintainability with focused skill modules
* chore: update import paths and lockfile
- Update prometheus import path after refactor
- Update bun.lock
* fix(tests): complete BDD comment normalization
- Fix remaining #when/#then patterns missed by initial sed
- Affected: state.test.ts, events.test.ts
---------
Co-authored-by: justsisyphus <justsisyphus@users.noreply.github.com>
120 lines
4.3 KiB
TypeScript
120 lines
4.3 KiB
TypeScript
import { describe, expect, it } from "bun:test"
|
|
import {
|
|
DELEGATE_TASK_ERROR_PATTERNS,
|
|
detectDelegateTaskError,
|
|
buildRetryGuidance,
|
|
} from "./index"
|
|
|
|
describe("sisyphus-task-retry", () => {
|
|
describe("DELEGATE_TASK_ERROR_PATTERNS", () => {
|
|
// given error patterns are defined
|
|
// then should include all known delegate_task error types
|
|
it("should contain all known error patterns", () => {
|
|
expect(DELEGATE_TASK_ERROR_PATTERNS.length).toBeGreaterThan(5)
|
|
|
|
const patternTexts = DELEGATE_TASK_ERROR_PATTERNS.map(p => p.pattern)
|
|
expect(patternTexts).toContain("run_in_background")
|
|
expect(patternTexts).toContain("load_skills")
|
|
expect(patternTexts).toContain("category OR subagent_type")
|
|
expect(patternTexts).toContain("Unknown category")
|
|
expect(patternTexts).toContain("Unknown agent")
|
|
})
|
|
})
|
|
|
|
describe("detectDelegateTaskError", () => {
|
|
// given tool output with run_in_background error
|
|
// when detecting error
|
|
// then should return matching error info
|
|
it("should detect run_in_background missing error", () => {
|
|
const output = "[ERROR] Invalid arguments: 'run_in_background' parameter is REQUIRED. Use run_in_background=false for task delegation."
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("missing_run_in_background")
|
|
})
|
|
|
|
it("should detect load_skills missing error", () => {
|
|
const output = "[ERROR] Invalid arguments: 'load_skills' parameter is REQUIRED. Use load_skills=[] if no skills are needed."
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("missing_load_skills")
|
|
})
|
|
|
|
it("should detect category/subagent mutual exclusion error", () => {
|
|
const output = "[ERROR] Invalid arguments: Provide EITHER category OR subagent_type, not both."
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("mutual_exclusion")
|
|
})
|
|
|
|
it("should detect unknown category error", () => {
|
|
const output = '[ERROR] Unknown category: "invalid-cat". Available: visual-engineering, ultrabrain, quick'
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("unknown_category")
|
|
})
|
|
|
|
it("should detect unknown agent error", () => {
|
|
const output = '[ERROR] Unknown agent: "fake-agent". Available agents: explore, librarian, oracle'
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).not.toBeNull()
|
|
expect(result?.errorType).toBe("unknown_agent")
|
|
})
|
|
|
|
it("should return null for successful output", () => {
|
|
const output = "Background task launched.\n\nTask ID: bg_12345\nSession ID: ses_abc"
|
|
|
|
const result = detectDelegateTaskError(output)
|
|
|
|
expect(result).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe("buildRetryGuidance", () => {
|
|
// given detected error
|
|
// when building retry guidance
|
|
// then should return actionable fix instructions
|
|
it("should provide fix for missing run_in_background", () => {
|
|
const errorInfo = { errorType: "missing_run_in_background", originalOutput: "" }
|
|
|
|
const guidance = buildRetryGuidance(errorInfo)
|
|
|
|
expect(guidance).toContain("run_in_background")
|
|
expect(guidance).toContain("REQUIRED")
|
|
})
|
|
|
|
it("should provide fix for unknown category with available list", () => {
|
|
const errorInfo = {
|
|
errorType: "unknown_category",
|
|
originalOutput: '[ERROR] Unknown category: "bad". Available: visual-engineering, ultrabrain'
|
|
}
|
|
|
|
const guidance = buildRetryGuidance(errorInfo)
|
|
|
|
expect(guidance).toContain("visual-engineering")
|
|
expect(guidance).toContain("ultrabrain")
|
|
})
|
|
|
|
it("should provide fix for unknown agent with available list", () => {
|
|
const errorInfo = {
|
|
errorType: "unknown_agent",
|
|
originalOutput: '[ERROR] Unknown agent: "fake". Available agents: explore, oracle'
|
|
}
|
|
|
|
const guidance = buildRetryGuidance(errorInfo)
|
|
|
|
expect(guidance).toContain("explore")
|
|
expect(guidance).toContain("oracle")
|
|
})
|
|
})
|
|
})
|