YeonGyu-Kim
deaac8cb39
Plugin created managers, hooks, intervals, and process listeners on every load but had no teardown mechanism. On plugin reload, old instances remained alive causing cumulative memory leaks. - Add createPluginDispose() orchestrating shutdown sequence: backgroundManager.shutdown() → skillMcpManager.disconnectAll() → disposeHooks() - Add disposeHooks() aggregator with safe optional chaining - Wire dispose into index.ts to clean previous instance on reload - Make dispose idempotent (safe to call multiple times) Tests: 4 pass, 8 expects
88 lines
2.2 KiB
TypeScript
88 lines
2.2 KiB
TypeScript
import type { AvailableSkill } from "./agents/dynamic-agent-prompt-builder"
|
|
import type { HookName, OhMyOpenCodeConfig } from "./config"
|
|
import type { LoadedSkill } from "./features/opencode-skill-loader/types"
|
|
import type { BackgroundManager } from "./features/background-agent"
|
|
import type { PluginContext } from "./plugin/types"
|
|
import type { ModelCacheState } from "./plugin-state"
|
|
|
|
import { createCoreHooks } from "./plugin/hooks/create-core-hooks"
|
|
import { createContinuationHooks } from "./plugin/hooks/create-continuation-hooks"
|
|
import { createSkillHooks } from "./plugin/hooks/create-skill-hooks"
|
|
|
|
export type CreatedHooks = ReturnType<typeof createHooks>
|
|
|
|
type DisposableHook = { dispose?: () => void } | null | undefined
|
|
|
|
export type DisposableCreatedHooks = {
|
|
runtimeFallback?: DisposableHook
|
|
todoContinuationEnforcer?: DisposableHook
|
|
autoSlashCommand?: DisposableHook
|
|
}
|
|
|
|
export function disposeCreatedHooks(hooks: DisposableCreatedHooks): void {
|
|
hooks.runtimeFallback?.dispose?.()
|
|
hooks.todoContinuationEnforcer?.dispose?.()
|
|
hooks.autoSlashCommand?.dispose?.()
|
|
}
|
|
|
|
export function createHooks(args: {
|
|
ctx: PluginContext
|
|
pluginConfig: OhMyOpenCodeConfig
|
|
modelCacheState: ModelCacheState
|
|
backgroundManager: BackgroundManager
|
|
isHookEnabled: (hookName: HookName) => boolean
|
|
safeHookEnabled: boolean
|
|
mergedSkills: LoadedSkill[]
|
|
availableSkills: AvailableSkill[]
|
|
}) {
|
|
const {
|
|
ctx,
|
|
pluginConfig,
|
|
modelCacheState,
|
|
backgroundManager,
|
|
isHookEnabled,
|
|
safeHookEnabled,
|
|
mergedSkills,
|
|
availableSkills,
|
|
} = args
|
|
|
|
const core = createCoreHooks({
|
|
ctx,
|
|
pluginConfig,
|
|
modelCacheState,
|
|
isHookEnabled,
|
|
safeHookEnabled,
|
|
})
|
|
|
|
const continuation = createContinuationHooks({
|
|
ctx,
|
|
pluginConfig,
|
|
isHookEnabled,
|
|
safeHookEnabled,
|
|
backgroundManager,
|
|
sessionRecovery: core.sessionRecovery,
|
|
})
|
|
|
|
const skill = createSkillHooks({
|
|
ctx,
|
|
pluginConfig,
|
|
isHookEnabled,
|
|
safeHookEnabled,
|
|
mergedSkills,
|
|
availableSkills,
|
|
})
|
|
|
|
const hooks = {
|
|
...core,
|
|
...continuation,
|
|
...skill,
|
|
}
|
|
|
|
return {
|
|
...hooks,
|
|
disposeHooks: (): void => {
|
|
disposeCreatedHooks(hooks)
|
|
},
|
|
}
|
|
}
|