f8c626086e
Display names with parentheses like 'Atlas (Plan Executor)' cause HTTP
header validation errors in x-opencode-agent-name. This was blocking
Atlas/Prometheus from working via /start-work and auto-retry.
Changes:
- Display names: parens -> dashes ('Atlas - Plan Executor')
- Hooks (start-work, no-hephaestus-non-gpt, no-sisyphus-gpt): use
config keys ('atlas', 'sisyphus', 'hephaestus') for agent API fields
- auto-retry: use config key instead of display name for promptAsync
- agent-override-protection: handle dash-suffix normalization
- Updated all test expectations to match new format
Closes #3138
137 lines
4.4 KiB
TypeScript
137 lines
4.4 KiB
TypeScript
import { describe, expect, spyOn, test } from "bun:test"
|
|
import { _resetForTesting, updateSessionAgent } from "../../features/claude-code-session-state"
|
|
import { getAgentDisplayName } from "../../shared/agent-display-names"
|
|
import { createNoSisyphusGptHook } from "./index"
|
|
|
|
const SISYPHUS_DISPLAY = getAgentDisplayName("sisyphus")
|
|
const HEPHAESTUS_DISPLAY = getAgentDisplayName("hephaestus")
|
|
|
|
function createOutput() {
|
|
return {
|
|
message: {},
|
|
parts: [],
|
|
}
|
|
}
|
|
|
|
describe("no-sisyphus-gpt hook", () => {
|
|
test("shows toast on every chat.message when sisyphus uses gpt model", async () => {
|
|
// given - sisyphus (display name) with gpt model
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook({
|
|
client: { tui: { showToast } },
|
|
} as any)
|
|
|
|
const output1 = createOutput()
|
|
const output2 = createOutput()
|
|
|
|
// when - chat.message is called repeatedly with display name
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_1",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.3-codex" },
|
|
}, output1)
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_1",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.3-codex" },
|
|
}, output2)
|
|
|
|
// then - toast is shown for every message
|
|
expect(showToast).toHaveBeenCalledTimes(2)
|
|
expect(output1.message.agent).toBe("hephaestus")
|
|
expect(output2.message.agent).toBe("hephaestus")
|
|
expect(showToast.mock.calls[0]?.[0]).toMatchObject({
|
|
body: {
|
|
title: "NEVER Use Sisyphus with GPT",
|
|
message: expect.stringContaining("For GPT models (other than 5.4), always use Hephaestus."),
|
|
variant: "error",
|
|
},
|
|
})
|
|
})
|
|
|
|
test("does not show toast for gpt-5.4 model (Sisyphus has specialized support)", async () => {
|
|
// given - sisyphus with gpt-5.4 model (should be allowed)
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook({
|
|
client: { tui: { showToast } },
|
|
} as any)
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs with gpt-5.4
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_gpt54",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.4" },
|
|
}, output)
|
|
|
|
// then - no toast, agent NOT switched to Hephaestus
|
|
expect(showToast).toHaveBeenCalledTimes(0)
|
|
expect(output.message.agent).toBeUndefined()
|
|
})
|
|
|
|
test("does not show toast for non-gpt model", async () => {
|
|
// given - sisyphus with claude model
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook({
|
|
client: { tui: { showToast } },
|
|
} as any)
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_2",
|
|
agent: SISYPHUS_DISPLAY,
|
|
model: { providerID: "anthropic", modelID: "claude-opus-4-6" },
|
|
}, output)
|
|
|
|
// then - no toast
|
|
expect(showToast).toHaveBeenCalledTimes(0)
|
|
expect(output.message.agent).toBeUndefined()
|
|
})
|
|
|
|
test("does not show toast for non-sisyphus agent", async () => {
|
|
// given - hephaestus with gpt model
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook({
|
|
client: { tui: { showToast } },
|
|
} as any)
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_3",
|
|
agent: HEPHAESTUS_DISPLAY,
|
|
model: { providerID: "openai", modelID: "gpt-5.4" },
|
|
}, output)
|
|
|
|
// then - no toast
|
|
expect(showToast).toHaveBeenCalledTimes(0)
|
|
expect(output.message.agent).toBeUndefined()
|
|
})
|
|
|
|
test("uses session agent fallback when input agent is missing", async () => {
|
|
// given - session agent saved with display name (as OpenCode stores it)
|
|
_resetForTesting()
|
|
updateSessionAgent("ses_4", SISYPHUS_DISPLAY)
|
|
const showToast = spyOn({ fn: async () => ({}) }, "fn")
|
|
const hook = createNoSisyphusGptHook({
|
|
client: { tui: { showToast } },
|
|
} as any)
|
|
|
|
const output = createOutput()
|
|
|
|
// when - chat.message runs without input.agent
|
|
await hook["chat.message"]?.({
|
|
sessionID: "ses_4",
|
|
model: { providerID: "openai", modelID: "gpt-4o" },
|
|
}, output)
|
|
|
|
// then - toast shown via session-agent fallback
|
|
expect(showToast).toHaveBeenCalledTimes(1)
|
|
expect(output.message.agent).toBe("hephaestus")
|
|
})
|
|
})
|