luna/oh-my-opencode
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: fix remaining stale gpt-5.4 expectations after gpt-5.5 promotion

Browse Source 
Commit 708891dab fixed most test expectations after the gpt-5.5 model
promotion but missed 13 tests across 6 files that still expected
openai/gpt-5.4 in DEFAULT_CATEGORIES and AGENT_MODEL_REQUIREMENTS.

Updates all remaining stale expectations to openai/gpt-5.5:
- agents/utils.test.ts: atlas/metis resolution, buildAgent category,
  override.category expansion (5 tests)
- plugin-handlers/config-handler.test.ts: ultrabrain config resolution
  and fallback (2 tests)
- shared/agent-variant.test.ts: sisyphus chain variant and category
  fallback (2 tests)
- shared/model-capability-guardrails.test.ts: built-in requirement
  model ID assertion (1 test)
- tools/look-at/multimodal-fallback-chain.test.ts: multimodal-looker
  hardcoded variant metadata (1 test)
- cli/config-manager/generate-omo-config.test.ts: sisyphus model and
  fallback_models expectations (2 tests)
This commit is contained in:
acamq
2026-04-26 13:20:46 -06:00
parent 25e1fa9c3d
commit 0afacfa756
6 changed files with 22 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/agents/utils.test.ts
+10 -10
View File
@@ -1016,7 +1016,7 @@ describe("createBuiltinAgents with requiresAnyModel gating (sisyphus)", () => {
test("atlas and metis resolve to OpenAI in an OpenAI-only environment without a system default", async () => {
// #given
const fetchSpy = spyOn(shared, "fetchAvailableModels").mockResolvedValue(new Set(["openai/gpt-5.4"]))
const fetchSpy = spyOn(shared, "fetchAvailableModels").mockResolvedValue(new Set(["openai/gpt-5.5"]))
const cacheSpy = spyOn(connectedProvidersCache, "readConnectedProvidersCache").mockReturnValue(["openai"])
try {
@@ -1025,10 +1025,10 @@ describe("createBuiltinAgents with requiresAnyModel gating (sisyphus)", () => {
// #then
expect(agents.atlas).toBeDefined()
expect(agents.atlas.model).toBe("openai/gpt-5.4")
expect(agents.atlas.model).toBe("openai/gpt-5.5")
expect(agents.atlas.variant).toBe("medium")
expect(agents.metis).toBeDefined()
expect(agents.metis.model).toBe("openai/gpt-5.4")
expect(agents.metis.model).toBe("openai/gpt-5.5")
expect(agents.metis.variant).toBe("high")
} finally {
fetchSpy.mockRestore()
@@ -1185,7 +1185,7 @@ describe("buildAgent with category and skills", () => {
const agent = buildAgent(source["test-agent"], TEST_MODEL)
// #then - category's built-in model and skills are applied
expect(agent.model).toBe("openai/gpt-5.4")
expect(agent.model).toBe("openai/gpt-5.5")
expect(agent.variant).toBe("xhigh")
expect(agent.prompt).toContain("Role: Designer-Turned-Developer")
expect(agent.prompt).toContain("Task description")
@@ -1309,9 +1309,9 @@ describe("override.category expansion in createBuiltinAgents", () => {
// #when
const agents = await createBuiltinAgents([], overrides, undefined, TEST_DEFAULT_MODEL)
// #then - ultrabrain category: model=openai/gpt-5.4, variant=xhigh
// #then - ultrabrain category: model=openai/gpt-5.5, variant=xhigh
expect(agents.oracle).toBeDefined()
expect(agents.oracle.model).toBe("openai/gpt-5.4")
expect(agents.oracle.model).toBe("openai/gpt-5.5")
expect(agents.oracle.variant).toBe("xhigh")
})
@@ -1378,9 +1378,9 @@ describe("override.category expansion in createBuiltinAgents", () => {
// #when
const agents = await createBuiltinAgents([], overrides, undefined, TEST_DEFAULT_MODEL)
// #then - ultrabrain category: model=openai/gpt-5.4, variant=xhigh
// #then - ultrabrain category: model=openai/gpt-5.5, variant=xhigh
expect(agents.sisyphus).toBeDefined()
expect(agents.sisyphus.model).toBe("openai/gpt-5.4")
expect(agents.sisyphus.model).toBe("openai/gpt-5.5")
expect(agents.sisyphus.variant).toBe("xhigh")
})
@@ -1393,9 +1393,9 @@ describe("override.category expansion in createBuiltinAgents", () => {
// #when
const agents = await createBuiltinAgents([], overrides, undefined, TEST_DEFAULT_MODEL)
// #then - ultrabrain category: model=openai/gpt-5.4, variant=xhigh
// #then - ultrabrain category: model=openai/gpt-5.5, variant=xhigh
expect(agents.atlas).toBeDefined()
expect(agents.atlas.model).toBe("openai/gpt-5.4")
expect(agents.atlas.model).toBe("openai/gpt-5.5")
expect(agents.atlas.variant).toBe("xhigh")
})
src/cli/config-manager/generate-omo-config.test.ts
+3 -3
View File
@@ -96,10 +96,10 @@ describe("generateOmoConfig - model fallback system", () => {
const result = generateOmoConfig(config)
//#then
expect((result.agents as Record<string, { model: string; variant?: string }>).sisyphus.model).toBe("openai/gpt-5.4")
expect((result.agents as Record<string, { model: string; variant?: string }>).sisyphus.model).toBe("openai/gpt-5.5")
expect((result.agents as Record<string, { model: string; variant?: string }>).sisyphus.variant).toBe("medium")
expect((result.agents as Record<string, { model: string }>).oracle.model).toBe("openai/gpt-5.5")
expect((result.agents as Record<string, { model: string }>)['multimodal-looker'].model).toBe("openai/gpt-5.4")
expect((result.agents as Record<string, { model: string }>)['multimodal-looker'].model).toBe("openai/gpt-5.5")
})
test("adds fallback_models when multiple providers are available", () => {
@@ -134,7 +134,7 @@ describe("generateOmoConfig - model fallback system", () => {
expect(agents.sisyphus.model).toBe("anthropic/claude-opus-4-7")
expect(agents.sisyphus.fallback_models).toEqual([
{
model: "openai/gpt-5.4",
model: "openai/gpt-5.5",
variant: "medium",
},
])
src/plugin-handlers/config-handler.test.ts
+2 -2
View File
@@ -750,7 +750,7 @@ describe("Prometheus category config resolution", () => {
// then
expect(config).toBeDefined()
expect(config?.model).toBe("openai/gpt-5.4")
expect(config?.model).toBe("openai/gpt-5.5")
expect(config?.variant).toBe("xhigh")
})
@@ -810,7 +810,7 @@ describe("Prometheus category config resolution", () => {
// then - falls back to DEFAULT_CATEGORIES
expect(config).toBeDefined()
expect(config?.model).toBe("openai/gpt-5.4")
expect(config?.model).toBe("openai/gpt-5.5")
expect(config?.variant).toBe("xhigh")
})
src/shared/agent-variant.test.ts
+4 -4
View File
@@ -124,10 +124,10 @@ describe("resolveVariantForModel", () => {
expect(variant).toBe("medium")
})
test("returns medium for openai/gpt-5.4 in sisyphus chain", () => {
// #given openai/gpt-5.4 is now in sisyphus fallback chain with variant medium
test("returns medium for openai/gpt-5.5 in sisyphus chain", () => {
// #given openai/gpt-5.5 is now in sisyphus fallback chain with variant medium
const config = {} as OhMyOpenCodeConfig
const model = { providerID: "openai", modelID: "gpt-5.4" }
const model = { providerID: "openai", modelID: "gpt-5.5" }
// when
const variant = resolveVariantForModel(config, "sisyphus", model)
@@ -179,7 +179,7 @@ describe("resolveVariantForModel", () => {
"custom-agent": { category: "ultrabrain" },
},
} as OhMyOpenCodeConfig
const model = { providerID: "openai", modelID: "gpt-5.4" }
const model = { providerID: "openai", modelID: "gpt-5.5" }
// when
const variant = resolveVariantForModel(config, "custom-agent", model)
src/shared/model-capability-guardrails.test.ts
+1 -1
View File
@@ -20,7 +20,7 @@ describe("model-capability-guardrails", () => {
expect(modelIDs).toEqual([...modelIDs].sort())
expect(new Set(modelIDs).size).toBe(modelIDs.length)
expect(modelIDs).toContain("claude-opus-4-7")
expect(modelIDs).toContain("gpt-5.4")
expect(modelIDs).toContain("gpt-5.5")
expect(modelIDs).toContain("kimi-k2.5")
})
src/tools/look-at/multimodal-fallback-chain.test.ts
+2 -2
View File
@@ -34,7 +34,7 @@ describe("buildMultimodalLookerFallbackChain", () => {
it("preserves hardcoded variant metadata for cache-derived entries", async () => {
// given
const { buildMultimodalLookerFallbackChain } = await import("./multimodal-fallback-chain")
const visionCapableModels = [{ providerID: "openai", modelID: "gpt-5.4" }]
const visionCapableModels = [{ providerID: "openai", modelID: "gpt-5.5" }]
// when
const result = buildMultimodalLookerFallbackChain(visionCapableModels)
@@ -42,7 +42,7 @@ describe("buildMultimodalLookerFallbackChain", () => {
// then
expect(result[0]).toEqual({
providers: ["openai"],
model: "gpt-5.4",
model: "gpt-5.5",
variant: "medium",
})
})