fix(migration): persist fullMigrationSet in-config when sidecar write fails

Addresses Cubic review: configs without prior _migrations now get the
full migration set written to config as fallback when sidecar write
fails, preventing migration tracking loss.
This commit is contained in:
YeonGyu-Kim
2026-04-10 19:01:59 +09:00
parent 6ec9a2bd79
commit 5493ae226c
2 changed files with 39 additions and 6 deletions
+31 -2
View File
@@ -1488,9 +1488,12 @@ describe("migrateConfigFile with migration tracking via sidecar (#3263)", () =>
// when: Migrate config file (sidecar write will fail)
const needsWrite = migrateConfigFile(testConfigPath, rawConfig)
// then: _migrations should be preserved as fallback since sidecar write failed
// then: _migrations should contain full set (existing + new) as fallback
expect(needsWrite).toBe(true)
expect(rawConfig._migrations).toEqual(["model-version:openai/gpt-5.3-codex->openai/gpt-5.4"])
const migrations = rawConfig._migrations as string[]
expect(Array.isArray(migrations)).toBe(true)
expect(migrations).toContain("model-version:openai/gpt-5.3-codex->openai/gpt-5.4")
expect(migrations.length).toBeGreaterThanOrEqual(1)
expect((rawConfig.agents as Record<string, Record<string, unknown>>).oracle.model).toBe("anthropic/claude-opus-4-6")
// Sidecar should not exist because write failed
@@ -1499,4 +1502,30 @@ describe("migrateConfigFile with migration tracking via sidecar (#3263)", () =>
// cleanup: restore permissions for cleanup
fs.chmodSync(workdir, 0o755)
})
test("writes _migrations into config as fallback when sidecar write fails and no prior _migrations existed", () => {
// given: config WITHOUT _migrations field and a read-only dir
const testConfigPath = tempConfigPath("sidecar-fail-no-prior")
const rawConfig: Record<string, unknown> = {
agents: {
oracle: { model: "anthropic/claude-opus-4-5" },
},
}
fs.writeFileSync(testConfigPath, JSON.stringify(rawConfig, null, 2))
const workdir = path.dirname(testConfigPath)
fs.chmodSync(workdir, 0o555)
// when: migrate runs (sidecar write will fail)
const needsWrite = migrateConfigFile(testConfigPath, rawConfig)
// then: _migrations should be injected into config as fallback
expect(needsWrite).toBe(true)
expect(rawConfig._migrations).toBeDefined()
expect(Array.isArray(rawConfig._migrations)).toBe(true)
expect((rawConfig._migrations as string[]).length).toBeGreaterThan(0)
expect(fs.existsSync(sidecarPath(testConfigPath))).toBe(false)
// cleanup
fs.chmodSync(workdir, 0o755)
})
})
+8 -4
View File
@@ -75,11 +75,11 @@ export function migrateConfigFile(
// `_migrations` to downstream schema validation.
const newMigrationsToRecord = allNewMigrations.filter(mKey => !existingMigrations.has(mKey))
let sidecarWriteSucceeded = false
const fullMigrationSet = new Set<string>([
...existingMigrations,
...newMigrationsToRecord,
])
if (newMigrationsToRecord.length > 0 || hadLegacyInConfigMigrations) {
const fullMigrationSet = new Set<string>([
...existingMigrations,
...newMigrationsToRecord,
])
sidecarWriteSucceeded = writeAppliedMigrations(configPath, fullMigrationSet)
}
if (newMigrationsToRecord.length > 0) {
@@ -91,6 +91,10 @@ export function migrateConfigFile(
}
if (sidecarWriteSucceeded && "_migrations" in copy) {
delete copy._migrations
} else if (!sidecarWriteSucceeded && newMigrationsToRecord.length > 0) {
// Sidecar write failed — persist migration tracking in-config as fallback
;(copy as Record<string, unknown>)._migrations = Array.from(fullMigrationSet)
needsWrite = true
}
if (copy.omo_agent) {