Commit Graph

1168 Commits

Author SHA1 Message Date
justsisyphus a1d7acac17 fix: store session agent in chat.message for prometheus-md-only hook
The prometheus-md-only hook was not enforcing file restrictions because
getSessionAgent() returned undefined - setSessionAgent was only called
in message.updated event which doesn't always provide agent info.

- Add setSessionAgent call in chat.message hook when input.agent exists
- Add session state tests for setSessionAgent/getSessionAgent
- Add clearSessionAgent cleanup to prometheus-md-only tests

This ensures prometheus-md-only hook can reliably identify Prometheus
sessions and enforce .sisyphus/*.md write restrictions.
2026-01-16 11:35:37 +09:00
justsisyphus 8c7ec8eb24 fix: clear session agent on /start-work to allow mode transition from Prometheus
When transitioning from Prometheus (Planner) to Sisyphus via /start-work,
the session agent was not being cleared. This caused prometheus-md-only
hook to continue injecting READ-ONLY constraints into sisyphus_task calls.

- Add clearSessionAgent() call when start-work command is detected
- Add TDD test verifying clearSessionAgent is called with sessionID
2026-01-16 11:35:37 +09:00
justsisyphus 9c7854832f refactor: unify system directive prefix for keyword-detector filtering
- Add shared/system-directive.ts with SYSTEM_DIRECTIVE_PREFIX constant
- Unify all system message prefixes to [SYSTEM DIRECTIVE: OH-MY-OPENCODE - ...]
- Add isSystemDirective() filter to keyword-detector to skip system messages
- Update prometheus-md-only tests to use new prefix constants
2026-01-16 11:35:37 +09:00
justsisyphus 33a2b65518 refactor: remove dcp_for_compaction and preemptive_compaction features
- Delete src/hooks/preemptive-compaction/ entirely
- Remove dcp_for_compaction from schema and executor
- Clean up related imports, options, and test code
- Update READMEs to remove experimental options docs
2026-01-16 11:35:37 +09:00
justsisyphus 9c79f0db1c fix: ensure Sisyphus agent has call_omo_agent disabled
The tools restriction was defined in sisyphus.ts but not enforced in
config-handler.ts like other agents (orchestrator-sisyphus, Prometheus).
Added explicit tools setting to guarantee call_omo_agent is disabled.
2026-01-16 11:35:37 +09:00
justsisyphus 133be9d17c refactor(lsp): clean up lsp_servers references and update prompts to use PascalCase
- Remove dead lsp_servers function from tools.ts
- Update utils.ts to reference LspServers (OpenCode built-in)
- Update AGENTS.md: 7 tools → 3 tools
- Update init-deep.ts prompts to use PascalCase OpenCode tools
- Update refactor.ts prompts to use PascalCase OpenCode tools
2026-01-16 11:35:37 +09:00
Kenny c1e6a53fc4 Merge pull request #833 from KNN-07/fix/git-master-watermark-injection
fix(git-master): inject watermark only when enabled instead of overriding defaults
2026-01-15 20:36:18 -05:00
justsisyphus 87fa8979d9 docs: update LSP tools list in all READMEs
Remove OpenCode built-in tools (lsp_goto_definition, lsp_find_references, lsp_symbols, lsp_servers) that are not provided by oh-my-opencode. Keep only lsp_diagnostics, lsp_prepare_rename, lsp_rename.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:33:55 +09:00
justsisyphus b775da364a refactor(config): disable unused OpenCode built-in LSP tools
LspHover, LspCodeActions, LspCodeActionResolve are disabled globally as they are not needed when using oh-my-opencode's curated LSP tools.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:33:44 +09:00
justsisyphus 16398560c1 refactor(lsp): remove lsp_servers - duplicates OpenCode's LspServers
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:33:35 +09:00
justsisyphus 5dc82faf9c docs: remove OpenCode built-in LSP tools from README
lsp_goto_definition, lsp_find_references, lsp_symbols are provided by OpenCode, not oh-my-opencode. Keep only the 4 tools we actually provide: lsp_diagnostics, lsp_servers, lsp_prepare_rename, lsp_rename.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-opencode)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-16 10:25:49 +09:00
Nguyen Khac Trung Kien 79774737ba fix(git-master): inject watermark only when enabled instead of overriding defaults
The watermark (commit footer and co-author) was inconsistently applied because:
1. The skill tool didn't receive gitMasterConfig
2. The approach was 'default ON, inject DISABLED override' which LLMs sometimes ignored

This refactors to 'inject only when enabled' approach:
- Remove hardcoded watermark section from base templates
- Dynamically inject section 5.5 based on config values
- Default is still ON (both true when no config)
- When both disabled, no injection occurs (clean prompt)

Also fixes missing config propagation to skill tool and createBuiltinAgents.
2026-01-16 08:01:04 +07:00
Jeremy Gollehon 1e080fc55b Merge pull request #803 from GollyJer/concurrency-hardening
feat(concurrency): prevent background task races and leaks

Summary
Fixes race conditions and memory leaks in the background task system that could cause "all tasks complete" notifications to never fire, leaving parent sessions waiting indefinitely.

Why This Change?
When background tasks are tracked for completion notifications, the system maintains a pendingByParent map to know when all tasks for a parent session are done. Several edge cases caused "stale entries" to accumulate in this map:
1. Re-registering completed tasks added them back to pending tracking, but they'd never complete again
2. Changing a task's parent session left orphan entries in the old parent's tracking set
3. Concurrent task operations could cause double-acquisition of concurrency slots
These bugs meant the system would sometimes wait forever for tasks that were already done.

What Changed
- Concurrency management: Added proper acquire/release lifecycle with cleanup on process exit (SIGINT, SIGTERM)
- Parent session tracking: Fixed cleanup order. Now clears old parent's tracking before updating parent ID
- Stale entry prevention: Only tracks tasks that are actually running; actively cleans up completed tasks
- Renamed registerExternalTask → trackTask: Clearer name (the old name implied external API consumers, but it's internal)
2026-01-15 11:09:52 -08:00
Jeremy Gollehon da766d19ee refactor(background-agent): rename registerExternalTask to trackTask
Update BackgroundManager to rename the method for tracking external tasks, improving clarity and consistency in task management. Adjust related tests to reflect the new method name.
2026-01-15 10:53:08 -08:00
github-actions[bot] 05a42d1202 release: v3.0.0-beta.8 2026-01-15 17:50:06 +00:00
justsisyphus 3852e54665 test: skip flaky timeout test in CI 2026-01-16 02:45:41 +09:00
justsisyphus ec441bf2c3 fix(ci): skip platform packages for now (OIDC not configured) 2026-01-16 02:38:26 +09:00
justsisyphus 4de2399f22 fix(hooks): use API instead of filesystem to resolve model info for session.prompt
Previously, continuation hooks (todo-continuation, boulder-continuation, ralph-loop)
and background tasks resolved model info from filesystem cache, which could be stale
or missing. This caused session.prompt to fallback to default model (Sonnet) instead
of using the originally configured model (e.g., Opus).

Now all session.prompt calls first try API (session.messages) to get current model
info, with filesystem as fallback if API fails.

Affected files:
- todo-continuation-enforcer.ts
- sisyphus-orchestrator/index.ts
- ralph-loop/index.ts
- background-agent/manager.ts
- sisyphus-task/tools.ts
- hook-message-injector/index.ts (export ToolPermission type)
2026-01-16 02:33:44 +09:00
justsisyphus 8178e18a04 fix(ci): add NPM_TOKEN for npm publish authentication 2026-01-16 02:31:12 +09:00
justsisyphus d760b49f59 fix(ci): add registry-url to setup-node for OIDC auth 2026-01-16 02:25:51 +09:00
justsisyphus 8f5802b677 Revert "fix(ci): add NPM_TOKEN support for npm publishing"
This reverts commit 5de3d4fb7d.
2026-01-16 02:20:15 +09:00
justsisyphus 6156800262 refactor(lsp): remove duplicate LSP tools already provided by OpenCode
Remove lsp_goto_definition, lsp_find_references, lsp_symbols as they
duplicate OpenCode's built-in LspGotoDefinition, LspFindReferences,
LspDocumentSymbols, and LspWorkspaceSymbols.

Keep oh-my-opencode-specific tools:
- lsp_diagnostics (OpenCode lacks pull diagnostics)
- lsp_servers (server management)
- lsp_prepare_rename / lsp_rename (OpenCode lacks rename)

Clean up associated dead code:
- Client methods: hover, definition, references, symbols, codeAction
- Utils: formatLocation, formatSymbolKind, formatDocumentSymbol, etc.
- Types: Location, LocationLink, SymbolInfo, DocumentSymbol, etc.
- Constants: SYMBOL_KIND_MAP, DEFAULT_MAX_REFERENCES/SYMBOLS

-418 lines removed.
2026-01-16 02:17:00 +09:00
justsisyphus a736fa7691 fix(skill): unify skill resolution to support user custom skills
sisyphus_task was only loading builtin skills via resolveMultipleSkills().
Now uses resolveMultipleSkillsAsync() which merges discoverSkills() + builtin skills.

- Add getAllSkills(), extractSkillTemplate(), resolveMultipleSkillsAsync()
- Update sisyphus_task to use async skill resolution
- Refactor skill tool to reuse unified getAllSkills()
- Add async skill resolution tests
2026-01-16 01:57:57 +09:00
justsisyphus 6956a1a0ac fix(ci): add NPM_TOKEN support for npm publishing
npm revoked all classic tokens. Workflow now requires NPM_TOKEN secret
with granular access token for publishing.
2026-01-16 01:23:00 +09:00
justsisyphus fee7cb6110 fix(ci): revert publish runner to ubuntu-latest for npm OIDC
macOS runner breaks npm OIDC trusted publishing. Bun can cross-compile
all platform binaries on ubuntu, so macOS runner is not needed.
2026-01-16 01:17:22 +09:00
justsisyphus fbe1aa4280 fix(ci): add registry-url to setup-node for npm OIDC auth
setup-node requires registry-url to configure .npmrc for OIDC authentication
2026-01-16 01:10:37 +09:00
justsisyphus 0d7f0f5bde fix(ci): use bunx tsc instead of bare tsc in publish workflow
tsc is not in PATH when installed via bun - use bunx to run from node_modules/.bin
2026-01-16 00:55:12 +09:00
Jeon Suyeol 28cc4a0fb3 fix(test): isolate environment in non-interactive-env hook tests (#822)
- Delete PSModulePath in beforeEach() to prevent CI cross-platform detection
- Set SHELL=/bin/bash to ensure tests start with clean Unix-like environment
- Fixes flaky test failures on GitHub Actions CI runners
- Tests can still override these values for PowerShell-specific behavior
2026-01-16 00:54:53 +09:00
Kenny 527de942b5 Merge pull request #813 from KNN-07/fix/start-work-ultrawork-plan-confusion
fix(start-work): honor explicit plan name and strip ultrawork keywords
2026-01-15 10:42:45 -05:00
sisyphus-dev-ai f596a1a6d3 chore: changes by sisyphus-dev-ai 2026-01-15 15:34:12 +00:00
Kenny 764ee49347 feat: Bun single-file executable distribution (#819)
* feat: add Bun single-file executable distribution

- Add 7 platform packages for standalone CLI binaries
- Add bin/platform.js for shared platform detection
- Add bin/oh-my-opencode.js ESM wrapper
- Add postinstall.mjs for binary verification
- Add script/build-binaries.ts for cross-compilation
- Update publish workflow for multi-package publishing
- Add CI guard against @ast-grep/napi in CLI
- Add unit tests for platform detection (12 tests)
- Update README to remove Bun runtime requirement

Platforms supported:
- macOS ARM64 & x64
- Linux x64 & ARM64 (glibc)
- Linux x64 & ARM64 (musl/Alpine)
- Windows x64

Closes #816

* chore: remove unnecessary @ast-grep/napi CI check

* chore: gitignore compiled platform binaries

* fix: use require() instead of top-level await import() for Bun compile compatibility

* refactor: use static ESM import for package.json instead of require()
2026-01-16 00:33:07 +09:00
justsisyphus 5a522ddfac fix(ci): add missing --copilot=no flag to agent workflow 2026-01-16 00:26:44 +09:00
Kenny 3762bdc141 Merge pull request #818 from code-yeongyu/fix/sisyphus-orchestrator-test-assertions
fix(sisyphus-orchestrator): update test assertions to match new prompt text
2026-01-15 08:44:52 -05:00
Kenny d4e70b3daa fix(sisyphus-orchestrator): update test assertions to match new prompt text
Update 5 test assertions to use stable substrings following section-markers
best practice:
- "MANDATORY VERIFICATION" → "MANDATORY:" (2 places)
- "SUBAGENTS LIE" → "LIE" (1 place)
- "0 left" → "0 remaining" (1 place)
- "2 left" → "2 remaining" (1 place)

Fixes test failures introduced in 9bed597.
2026-01-15 08:40:28 -05:00
Kenny 8fe9195446 Merge pull request #817 from code-yeongyu/fix/ci-pr-tests-on-dev
fix(ci): run tests on PRs to dev branch
2026-01-15 07:48:21 -05:00
Kenny 3c49bd9235 fix(ci): run tests on PRs to dev branch 2026-01-15 07:43:43 -05:00
Kenny d8c21f6a6e Merge pull request #815 from devxoul/fix/readme-beta-version
docs: update beta version to 3.0.0-beta.7 in README
2026-01-15 07:30:15 -05:00
Suyeol Jeon 974d3cf53f docs: update beta version link to v3.0.0-beta.7 in README 2026-01-15 21:10:13 +09:00
Suyeol Jeon 14da34ecef docs: update beta version to 3.0.0-beta.7 in README 2026-01-15 20:48:39 +09:00
justsisyphus b76816e9f7 feat(prompts): strengthen post-task reminders with actionable guidance
- Rewrite VERIFICATION_REMINDER with 3-step action flow (verify → determine QA → add to todo)
- Add explicit BLOCKING directive to prevent premature task progression
- Enhance buildOrchestratorReminder with clear post-verification actions
- Improve capture-pane block message with concrete Bash examples
2026-01-15 19:40:50 +09:00
justsisyphus 4ccc0b3f26 feat(sisyphus_task): enhance error messages with detailed context
Add formatDetailedError helper that includes:
- Full args dump (description, category, agent, skills)
- Session ID and agent info
- Stack trace (first 10 lines)

Applied to all catch blocks for better debugging.
2026-01-15 19:02:28 +09:00
github-actions[bot] 6c8099e78e @mmlmt2604 has signed the CLA in code-yeongyu/oh-my-opencode#812 2026-01-15 09:57:28 +00:00
Nguyen Khac Trung Kien 62448c1148 fix(start-work): honor explicit plan name and strip ultrawork keywords
When user types '/start-work my-plan ultrawork', the hook now:

1. Extracts plan name from <user-request> section
2. Strips ultrawork/ulw keywords from the plan name
3. Searches for matching plan (exact then partial match)
4. Uses the matched plan instead of resuming stale boulder state

This fixes the bug where '/start-work [PLAN] ultrawork' would:
- Include 'ultrawork' as part of the plan name argument
- Ignore the explicit plan and resume an old stale plan from boulder.json

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-01-15 16:55:44 +07:00
sisyphus-dev-ai be5f20f4cc chore: changes by sisyphus-dev-ai 2026-01-15 09:29:01 +00:00
Jeremy Gollehon af066ff99f fix(background-agent): improve parent session ID handling in task management
Enhance the BackgroundManager to properly clean up pending tasks when the parent session ID changes. This prevents stale entries in the pending notifications and ensures that the cleanup process is only executed when necessary, improving overall task management reliability.
2026-01-15 00:16:35 -08:00
justsisyphus 314869dda8 fix(sisyphus): enforce HARD BLOCK for frontend visual changes
Restore zero-tolerance policy for visual/styling changes in frontend files.
Visual keyword detection now triggers mandatory delegation to frontend-ui-ux-engineer.
2026-01-15 17:11:30 +09:00
Jeremy Gollehon 3a1f93e5ef fix(background-agent): prevent stale entries in pending notifications
Update BackgroundManager to track batched notifications only for running tasks. Implement cleanup for completed or cancelled tasks to avoid stale entries in pending notifications. Enhance logging to include task status for better debugging.
2026-01-14 23:51:19 -08:00
Jeremy Gollehon ee601d845c feat(background-agent): implement process cleanup for BackgroundManager
Add functionality to manage process cleanup by registering and unregistering signal listeners. This ensures that BackgroundManager instances properly shut down and remove their listeners on process exit. Introduce tests to verify listener removal after shutdown.
2026-01-14 23:11:38 -08:00
Sisyphus f0a2ee7f1f fix(non-interactive-env): add Windows/PowerShell support (#573)
* fix(non-interactive-env): add Windows/PowerShell support

- Create shared shell-env utility with cross-platform shell detection
- Detect shell type via PSModulePath, SHELL env vars, platform fallback
- Support Unix (export), PowerShell ($env:), and cmd.exe (set) syntax
- Add 41 comprehensive unit tests for shell-env utilities
- Add 5 cross-platform integration tests for hook behavior
- All 696 tests pass, type checking passes, build succeeds

Closes #566

* fix: address review feedback - add isNonInteractive check and cmd.exe % escaping

- Add isNonInteractive() check to only apply env vars in CI/non-interactive contexts (Issue #566)
- Fix cmd.exe percent sign escaping to prevent environment variable expansion
- Update test expectations for correct % escaping behavior

Resolves feedback from @greptile-apps and @cubic-dev-ai

---------

Co-authored-by: sisyphus-dev-ai <sisyphus-dev-ai@users.noreply.github.com>
2026-01-15 16:04:06 +09:00
justsisyphus 2ad8173144 docs: update AGENTS documentation metadata and agent model references
- Update generated timestamp and commit hash metadata
- Normalize agent model names with provider prefixes (anthropic/, opencode/, google/)
- Remove deprecated Google OAuth/Antigravity references
- Update line counts and complexity hotspot entries
- Adjust test count from 82 to 80+ files and assertions from 2559+ to 2500+

🤖 Generated with assistance of oh-my-opencode
2026-01-15 15:53:51 +09:00