Files
oh-my-opencode/src/shared/agent-variant.test.ts
T
acamq 0afacfa756 test: fix remaining stale gpt-5.4 expectations after gpt-5.5 promotion
Commit 708891dab fixed most test expectations after the gpt-5.5 model
promotion but missed 13 tests across 6 files that still expected
openai/gpt-5.4 in DEFAULT_CATEGORIES and AGENT_MODEL_REQUIREMENTS.

Updates all remaining stale expectations to openai/gpt-5.5:
- agents/utils.test.ts: atlas/metis resolution, buildAgent category,
  override.category expansion (5 tests)
- plugin-handlers/config-handler.test.ts: ultrabrain config resolution
  and fallback (2 tests)
- shared/agent-variant.test.ts: sisyphus chain variant and category
  fallback (2 tests)
- shared/model-capability-guardrails.test.ts: built-in requirement
  model ID assertion (1 test)
- tools/look-at/multimodal-fallback-chain.test.ts: multimodal-looker
  hardcoded variant metadata (1 test)
- cli/config-manager/generate-omo-config.test.ts: sisyphus model and
  fallback_models expectations (2 tests)
2026-04-26 13:20:46 -06:00

215 lines
5.6 KiB
TypeScript

import { describe, expect, test } from "bun:test"
import type { OhMyOpenCodeConfig } from "../config"
import { applyAgentVariant, resolveAgentVariant, resolveVariantForModel } from "./agent-variant"
describe("resolveAgentVariant", () => {
test("returns undefined when agent name missing", () => {
// given
const config = {} as OhMyOpenCodeConfig
// when
const variant = resolveAgentVariant(config)
// then
expect(variant).toBeUndefined()
})
test("returns agent override variant", () => {
// given
const config = {
agents: {
sisyphus: { variant: "low" },
},
} as OhMyOpenCodeConfig
// when
const variant = resolveAgentVariant(config, "sisyphus")
// then
expect(variant).toBe("low")
})
test("returns category variant when agent uses category", () => {
// given
const config = {
agents: {
sisyphus: { category: "ultrabrain" },
},
categories: {
ultrabrain: { model: "openai/gpt-5.5", variant: "xhigh" },
},
} as OhMyOpenCodeConfig
// when
const variant = resolveAgentVariant(config, "sisyphus")
// then
expect(variant).toBe("xhigh")
})
})
describe("applyAgentVariant", () => {
test("sets variant when message is undefined", () => {
// given
const config = {
agents: {
sisyphus: { variant: "low" },
},
} as OhMyOpenCodeConfig
const message: { variant?: string } = {}
// when
applyAgentVariant(config, "sisyphus", message)
// then
expect(message.variant).toBe("low")
})
test("does not override existing variant", () => {
// given
const config = {
agents: {
sisyphus: { variant: "low" },
},
} as OhMyOpenCodeConfig
const message = { variant: "max" }
// when
applyAgentVariant(config, "sisyphus", message)
// then
expect(message.variant).toBe("max")
})
})
describe("resolveVariantForModel", () => {
test("returns agent override variant when configured", () => {
// given - use a model in sisyphus chain (claude-opus-4-7 has default variant "max")
// to verify override takes precedence over fallback chain
const config = {
agents: {
sisyphus: { variant: "high" },
},
} as OhMyOpenCodeConfig
const model = { providerID: "anthropic", modelID: "claude-opus-4-7" }
// when
const variant = resolveVariantForModel(config, "sisyphus", model)
// then
expect(variant).toBe("high")
})
test("returns correct variant for anthropic provider", () => {
// given
const config = {} as OhMyOpenCodeConfig
const model = { providerID: "anthropic", modelID: "claude-opus-4-7" }
// when
const variant = resolveVariantForModel(config, "sisyphus", model)
// then
expect(variant).toBe("max")
})
test("returns correct variant for openai provider (hephaestus agent)", () => {
// #given hephaestus has openai/gpt-5.5 with variant "medium" in its chain
const config = {} as OhMyOpenCodeConfig
const model = { providerID: "openai", modelID: "gpt-5.5" }
// #when
const variant = resolveVariantForModel(config, "hephaestus", model)
// then
expect(variant).toBe("medium")
})
test("returns medium for openai/gpt-5.5 in sisyphus chain", () => {
// #given openai/gpt-5.5 is now in sisyphus fallback chain with variant medium
const config = {} as OhMyOpenCodeConfig
const model = { providerID: "openai", modelID: "gpt-5.5" }
// when
const variant = resolveVariantForModel(config, "sisyphus", model)
// then
expect(variant).toBe("medium")
})
test("returns undefined for provider not in chain", () => {
// given
const config = {} as OhMyOpenCodeConfig
const model = { providerID: "unknown-provider", modelID: "some-model" }
// when
const variant = resolveVariantForModel(config, "sisyphus", model)
// then
expect(variant).toBeUndefined()
})
test("returns undefined for unknown agent", () => {
// given
const config = {} as OhMyOpenCodeConfig
const model = { providerID: "anthropic", modelID: "claude-opus-4-7" }
// when
const variant = resolveVariantForModel(config, "nonexistent-agent", model)
// then
expect(variant).toBeUndefined()
})
test("returns variant for zai-coding-plan provider without variant", () => {
// given
const config = {} as OhMyOpenCodeConfig
const model = { providerID: "zai-coding-plan", modelID: "glm-5" }
// when
const variant = resolveVariantForModel(config, "sisyphus", model)
// then
expect(variant).toBeUndefined()
})
test("falls back to category chain when agent has no requirement", () => {
// given
const config = {
agents: {
"custom-agent": { category: "ultrabrain" },
},
} as OhMyOpenCodeConfig
const model = { providerID: "openai", modelID: "gpt-5.5" }
// when
const variant = resolveVariantForModel(config, "custom-agent", model)
// then
expect(variant).toBe("xhigh")
})
test("returns correct variant for oracle agent with openai", () => {
// given
const config = {} as OhMyOpenCodeConfig
const model = { providerID: "openai", modelID: "gpt-5.5" }
// when
const variant = resolveVariantForModel(config, "oracle", model)
// then
expect(variant).toBe("high")
})
test("returns correct variant for oracle agent with anthropic", () => {
// given
const config = {} as OhMyOpenCodeConfig
const model = { providerID: "anthropic", modelID: "claude-opus-4-7" }
// when
const variant = resolveVariantForModel(config, "oracle", model)
// then
expect(variant).toBe("max")
})
})