Commit Graph

4498 Commits

Author SHA1 Message Date
YeonGyu-Kim db7dfa1249 Fix todo-continuation-enforcer mock isolation
- idle-event.ts: improve import patterns
- non-idle-events.ts: update for test compatibility
- resolve-message-info.ts: prevent cross-test contamination
- todo-continuation-enforcer.test.ts: narrow mock scope
- types.ts: update type definitions

🤖 GENERATED WITH ASSISTANCE OF OhMyOpenCode
2026-04-04 18:56:36 +09:00
YeonGyu-Kim 382f9b61fa Fix mock isolation in remaining hook tests
- message-builder.test.ts: improve mock isolation
- background-update-check.ts: update for test compatibility
- execute-http-hook-security.test.ts: narrow mock targets
- recover-tool-result-missing.test.ts: prevent barrel contamination

🤖 GENERATED WITH ASSISTANCE OF OhMyOpenCode
2026-04-04 18:56:34 +09:00
YeonGyu-Kim ffcd34d4c1 Fix mock target path in claude-code-mcp-loader test
- Change mock.module target from "../../shared" to "../../shared/claude-config-dir"
- Narrows mock scope to prevent barrel export contamination

🤖 GENERATED WITH ASSISTANCE OF OhMyOpenCode
2026-04-04 18:56:30 +09:00
YeonGyu-Kim 92ba31272d Fix mock isolation in system.test.ts by moving mocks to importFresh
- Move mock.module() calls from top-level into importFreshSystemModule()
- Restore real modules in afterAll to prevent cross-test contamination
- Reset mocks before each test

🤖 GENERATED WITH ASSISTANCE OF OhMyOpenCode
2026-04-04 18:56:29 +09:00
YeonGyu-Kim 89fd302db4 Update publish-workflow test for bun test command
- Change test expectation from "bun run test:ci" to "bun test"

🤖 GENERATED WITH ASSISTANCE OF OhMyOpenCode
2026-04-04 18:56:26 +09:00
YeonGyu-Kim 1071d4defb Pin Bun to 1.3.10 in CI and remove test:ci script
- Pin bun-version to 1.3.10 across all CI workflows to avoid
  mock.module() barrel export regression introduced in 1.3.11
- Remove test:ci script from package.json (use bun test directly)
- Update publish-workflow.test.ts to expect "bun test" instead

🤖 GENERATED WITH ASSISTANCE OF OhMyOpenCode
2026-04-04 18:56:25 +09:00
YeonGyu-Kim 51d2f8b3e9 fix(tmux-subagent): avoid transcript fetches during idle stability checks 2026-04-04 18:48:03 +09:00
YeonGyu-Kim 4c3f6c1a52 fix(background-notification): filter unsupported manager events
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 18:39:33 +09:00
YeonGyu-Kim f9a9a60b82 fix(background-agent): cache observed output for completion checks
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 18:39:26 +09:00
YeonGyu-Kim a71dd54f8e fix(test): isolate auto-update-checker mock.module() tests to prevent contamination
- Moved hook.test.ts, background-update-check.test.ts, workspace-resolution.test.ts, and cache.test.ts to separate sibling directories (_auc-mocks-hook, _auc-mocks-bg, _auc-mocks-ws, _auc-mocks-cache)
- Separated sync-package-json.test.ts to _auc-sync-mocks
- Fixed all relative import paths to account for new directory structure
- Bun runs same-directory test files in parallel; mock.module() calls contaminate each other. Only reliable isolation is separate directory = separate CI batch
- CI plan now creates individual isolated target for each mocking test file, preventing cross-file pollution
2026-04-04 17:53:24 +09:00
YeonGyu-Kim 8c06c8e2fe fix(test): make runner env setup test deterministic
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 17:45:26 +09:00
YeonGyu-Kim 179ad05f5f fix(test): silence expected oauth logout cli output
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 17:45:26 +09:00
YeonGyu-Kim fb7e3fd98d fix(test): silence expected oauth login cli output
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 17:45:26 +09:00
YeonGyu-Kim b3d69e71f0 Fix mock.module() CI contamination by isolating tests into separate directories
- Moved hook-integration tests → src/hooks/_auc-mocks-hook/
- Moved workspace-resolution tests → src/hooks/_auc-mocks-workspace/
- Moved background-update-check tests → src/hooks/_auc-mocks-bgupdate/
- Moved cache tests → src/hooks/_auc-mocks-cache/
- Moved sync-package-json tests → src/hooks/_auc-sync-mocks/
- Removed hook.test.ts, workspace-resolution.test.ts, background-update-check.test.ts from auto-update-checker
- Removed cache.test.ts from auto-update-checker
- Each test file with mock.module() now in its own isolated CI batch
- Bun's prefix glob matching was picking up _auc-mocks-* when running auto-update-checker
- Solution: Separate into dedicated directories prevents cross-contamination

CI Results: 3151 pass, 0 fail ✓
2026-04-04 17:42:44 +09:00
YeonGyu-Kim 0c3f8b7bfa fix(test): isolate sync-package-json test to prevent node:fs mock contamination
sync-package-json.test.ts mocks node:fs which leaks into plugin-entry.test.ts
running in the same CI batch. Move to checker/sync/ subdirectory for isolation.
2026-04-04 17:28:52 +09:00
YeonGyu-Kim 0cc263bcd1 fix(test): isolate auto-update-checker hook.test.ts to prevent checker mock leak
hook.test.ts mocks ./checker at module load time, which contaminates
checker.test.ts and invalidate-package.test.ts running in parallel in
the same CI batch. Move to hook-integration/ subdirectory for CI batch
isolation.
2026-04-04 17:24:15 +09:00
YeonGyu-Kim c91c3e6164 fix(test): move auto-slash-command-leak test to isolated subdirectory
mock.module('./executor') leaks across all files in the same batch because
Bun runs test files in a directory in parallel. The afterAll restore trick
doesn't work when other files load the module concurrently at startup.

Moving the leak test to its own subdirectory (leak/) ensures CI's batch
runner isolates it in a separate bun test invocation, preventing executor
mock contamination in executor-resolution.test.ts and index.test.ts.
2026-04-04 17:08:53 +09:00
YeonGyu-Kim 8fb22b89cf fix(test): restore real executor module in auto-slash-command-leak afterAll
mock.module('./executor') in auto-slash-command-leak.test.ts was leaking
into executor-resolution.test.ts in the same CI batch run, causing
executeSlashCommand to return the mock's raw replacement instead of the
real resolution result.

Fix: re-register the real executor exports via mock.module() in afterAll
so subsequent test files in the batch get the real implementation.
2026-04-04 17:04:26 +09:00
YeonGyu-Kim eb4060d739 fix(test): narrow mock.module() targets in background-agent tests to prevent barrel corruption
Three test files were mocking the entire '../../shared' barrel, which
corrupted exports for subsequent test files in the same batch run.
Narrow mocks to specific submodules (logger, connected-providers-cache).

Also reverts Bun version pin since the root cause was mock scope, not Bun.
2026-04-04 16:56:39 +09:00
YeonGyu-Kim 99ae6d91d0 fix(ci): pin Bun to 1.3.10 to avoid mock.module() barrel export regression in 1.3.11
Bun 1.3.11 has a regression where mock.module() leaks across test files
in isolated batch execution, causing barrel re-exports to fail with
'Export named X not found' errors. Pin to 1.3.10 until upstream fix.
2026-04-04 16:51:23 +09:00
YeonGyu-Kim a6e783adc4 fix(test): improve execute-http-hook-security test isolation
Reset mocks and process.env copy in afterEach to prevent cross-test
contamination from mock.module() isolation.
2026-04-04 16:48:12 +09:00
YeonGyu-Kim 733b54865f fix(config): handle tuple-format plugin entries in opencode.json (fixes #3122)
OpenCode supports plugin entries as [string, object] tuples for passing
options, but loadOpencodePlugins assumed all entries were strings.
When a tuple entry hit matchesKnownPlugin, it called .toLowerCase()
on an array, crashing the plugin on startup.

Extract the string name from tuple entries and skip non-string values.
Add regression test covering the tuple plugin format.
2026-04-04 16:44:40 +09:00
YeonGyu-Kim e40d3fb37a fix(session-manager): fall back to file storage on SDK outages 2026-04-04 16:42:51 +09:00
YeonGyu-Kim 119db367de Merge pull request #3120 from code-yeongyu/fix/prepublish-ci-test-isolation
fix(ci): restore isolated Bun test execution for mock.module suites
2026-04-04 16:12:55 +09:00
YeonGyu-Kim 72c8cb8d92 fix(ci): typecheck script tooling in CI workflow
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 16:12:30 +09:00
YeonGyu-Kim bedf141c5e fix(ci): include bin tests in CI plan discovery
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 16:12:22 +09:00
YeonGyu-Kim 322a360b2e Merge pull request #3119 from code-yeongyu/fix/prepublish-delegate-sync
fix(sync): forward delegated model tuning params
2026-04-04 16:11:07 +09:00
YeonGyu-Kim 5000b18909 Merge pull request #3118 from code-yeongyu/fix/prepublish-skill-schema
fix(config): allow disabling new built-in skills
2026-04-04 16:11:04 +09:00
YeonGyu-Kim dbec902e9c Merge pull request #3117 from code-yeongyu/fix/prepublish-ralph-loop
fix(ralph-loop): remove dead semantic completion fallback
2026-04-04 16:11:01 +09:00
YeonGyu-Kim 6edf705e95 Merge pull request #3116 from code-yeongyu/fix/prepublish-hook-recovery
fix(anthropic-recovery): add dispose path and fix test isolation
2026-04-04 16:10:59 +09:00
YeonGyu-Kim 8ca4ff23df Merge pull request #3115 from code-yeongyu/fix/prepublish-tmux-lifecycle
fix(tmux): clean cancel bookkeeping and unify isolated cleanup
2026-04-04 16:10:56 +09:00
github-actions[bot] 527861e246 @dihak has signed the CLA in code-yeongyu/oh-my-openagent#3114 2026-04-04 06:54:05 +00:00
YeonGyu-Kim 2c081e1999 fix(ci): restore isolated Bun test execution for mock.module suites
Running Linux CI in one Bun process still leaks mock.module registrations across files, so the workflows now use a CI-specific test runner that isolates mock-heavy targets before executing the remaining suite together.

Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:51:54 +09:00
YeonGyu-Kim 69c9ad4449 test(ralph-loop): add transcript detector coverage
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:41:50 +09:00
YeonGyu-Kim 2da5f12c1f test(ralph-loop): split session completion detector coverage
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:41:42 +09:00
YeonGyu-Kim 617abbe864 fix(ralph-loop): remove dead semantic completion fallback
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:41:36 +09:00
YeonGyu-Kim 1fae073009 fix(sync): forward delegated model tuning params
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:40:37 +09:00
YeonGyu-Kim 5d735372a4 fix(tmux): unify isolated cleanup across close paths
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:40:26 +09:00
YeonGyu-Kim b31dfa6928 fix(background-agent): clean tmux cancel bookkeeping
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:40:21 +09:00
YeonGyu-Kim 42ac82a94a test(anthropic-recovery): isolate summarize retry timer assertion
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:39:44 +09:00
YeonGyu-Kim 5e8a0ccf84 test(anthropic-recovery): cover recovery hook timer disposal
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:39:28 +09:00
YeonGyu-Kim 2b55f65c36 fix(hooks): dispose anthropic recovery hook on shutdown
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:39:12 +09:00
YeonGyu-Kim 268946d117 fix(anthropic-recovery): dispose recovery hook timers
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:39:00 +09:00
YeonGyu-Kim 0a7daa5d10 fix(anthropic-recovery): add session timeout cleanup helpers
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:38:46 +09:00
YeonGyu-Kim 8199adcb15 fix(config): allow disabling new built-in skills
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent)

Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
2026-04-04 15:37:43 +09:00
YeonGyu-Kim fd476fe9a1 Merge pull request #3112 from code-yeongyu/fix/prepublish-code-quality
refactor: replace em dashes with hyphens in test files and docs
2026-04-04 14:56:54 +09:00
YeonGyu-Kim cba9c25543 Merge pull request #3111 from code-yeongyu/fix/prepublish-config-regression
fix(config): use canonical path after legacy migration and make writes atomic
2026-04-04 14:56:52 +09:00
YeonGyu-Kim c4a5ba10cc Merge pull request #3110 from code-yeongyu/fix/prepublish-bg-race
fix(background-agent): prevent cancelled task from being revived after tmux callback
2026-04-04 14:56:49 +09:00
YeonGyu-Kim ba98be9375 Merge pull request #3109 from code-yeongyu/fix/prepublish-mcp-env
fix(security): block cloud credential env vars in MCP env cleaner
2026-04-04 14:56:47 +09:00
YeonGyu-Kim 4301e5e724 Merge pull request #3108 from code-yeongyu/fix/prepublish-tar-failopen
fix(security): make tar archive preflight fail-closed on unparsed entries
2026-04-04 14:56:44 +09:00